New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flocker volume plugin #14328

Merged
merged 1 commit into from Oct 2, 2015

Conversation

Projects
None yet
@agonzalezro
Contributor

agonzalezro commented Sep 22, 2015

Flocker [1] is an open-source container data volume manager for
Dockerized applications.

This PR adds a volume plugin for Flocker.
The plugin interfaces the Flocker Control Service REST API [2] to
request volume creation and attachment.

Each kubelet host should run Flocker agents (Container Agent and Dataset
Agent).

The kubelet will also require environment variables that contain the
host and port of the Flocker Control Service. (see Flocker architecture
[3] for more).

  • FLOCKER_CONTROL_SERVICE_HOST
  • FLOCKER_CONTROL_SERVICE_PORT

The contribution introduces a new 'flocker' volume type to the API with
fields:

  • datasetName: which indicates the name of the dataset in Flocker
    added to metadata;
  • size: a human-readable number that indicates the maximum size of the
    requested dataset.

Full documentation (including getting started guides) and e2e tests to
follow.

As the plugin is code complete, we're hoping to make version 1.1.

[1] https://clusterhq.com/flocker/introduction/
[2] https://docs.clusterhq.com/en/1.3.1/reference/api.html
[3] https://docs.clusterhq.com/en/1.3.1/concepts/architecture.html

@googlebot googlebot added the cla: yes label Sep 22, 2015

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Sep 22, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot commented Sep 22, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@mattbates mattbates referenced this pull request Sep 22, 2015

Closed

Flocker volume plugin #14327

@timothysc

This comment has been minimized.

Show comment
Hide comment
@timothysc

timothysc Sep 22, 2015

Member

cc @rootfs @markturansky - just FYI | review.

Member

timothysc commented Sep 22, 2015

cc @rootfs @markturansky - just FYI | review.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Sep 22, 2015

Contributor

Labelling this PR as size/XXL

Contributor

k8s-merge-robot commented Sep 22, 2015

Labelling this PR as size/XXL

if spec.Volume != nil && spec.Volume.Flocker != nil {
return spec.Volume.Flocker, readOnly
}
return spec.PersistentVolume.Spec.Flocker, readOnly

This comment has been minimized.

@markturansky

markturansky Sep 22, 2015

Member

Not a PV. This last line will panic.

@markturansky

markturansky Sep 22, 2015

Member

Not a PV. This last line will panic.

This comment has been minimized.

@markturansky

markturansky Sep 22, 2015

Member

Same as above. I missed flocker in PV struct. Looks good here.

@markturansky

markturansky Sep 22, 2015

Member

Same as above. I missed flocker in PV struct. Looks good here.

@thockin

This comment has been minimized.

Show comment
Hide comment
@thockin

thockin Sep 22, 2015

Member

You guys are cutting this close...

Member

thockin commented Sep 22, 2015

You guys are cutting this close...

Show outdated Hide outdated pkg/api/v1/types.go
@thockin

This comment has been minimized.

Show comment
Hide comment
@thockin

thockin Sep 22, 2015

Member

I took a quick look, nothing major jumped out. I'll leave it to Mark and Saad to pick the details.

What this is missing most is a good doc explaining how to use it, including the bits about env variables in the first comment.

Member

thockin commented Sep 22, 2015

I took a quick look, nothing major jumped out. I'll leave it to Mark and Saad to pick the details.

What this is missing most is a good doc explaining how to use it, including the bits about env variables in the first comment.

@rootfs

This comment has been minimized.

Show comment
Hide comment
@rootfs

rootfs Sep 22, 2015

Member

@agonzalezro Is flocker volume dependent on any docker release? Does it support rkt? Can you provide a working Pod and running environment in a doc?

Member

rootfs commented Sep 22, 2015

@agonzalezro Is flocker volume dependent on any docker release? Does it support rkt? Can you provide a working Pod and running environment in a doc?

return &builder, nil
}
func (p *flockerPlugin) NewCleaner(datasetName string, podUID types.UID) (volume.Cleaner, error) {

This comment has been minimized.

@rootfs

rootfs Sep 22, 2015

Member

you don't want to delete the volume?

@rootfs

rootfs Sep 22, 2015

Member

you don't want to delete the volume?

This comment has been minimized.

@agonzalezro

agonzalezro Sep 22, 2015

Contributor

The idea of Flocker is that you can move it between pods. I don't see at this stage any need for removing volume. Flocker agent will mount/dismount it when needed.

@agonzalezro

agonzalezro Sep 22, 2015

Contributor

The idea of Flocker is that you can move it between pods. I don't see at this stage any need for removing volume. Flocker agent will mount/dismount it when needed.

This comment has been minimized.

@markturansky

markturansky Sep 23, 2015

Member

But when the volume is moved between pods and between hosts, don't you want to clean up the orphaned directory on the old host?

@markturansky

markturansky Sep 23, 2015

Member

But when the volume is moved between pods and between hosts, don't you want to clean up the orphaned directory on the old host?

This comment has been minimized.

@mattbates

mattbates Sep 25, 2015

Not in this case, no. If and when the same dataset is requested elsewhere (by datasetName in the volume spec), the Flocker agent will umount/detach and reattach/mount the volume. If a volume is not required, at this stage it is a manual operation to destroy it. Hope that helps explain.

@mattbates

mattbates Sep 25, 2015

Not in this case, no. If and when the same dataset is requested elsewhere (by datasetName in the volume spec), the Flocker agent will umount/detach and reattach/mount the volume. If a volume is not required, at this stage it is a manual operation to destroy it. Hope that helps explain.

This comment has been minimized.

@pmorie

pmorie Sep 30, 2015

Member

This makes me wonder if there is any utility in using Flocker as a PV, since the semantics seem intrinsic to how the Flocker agent handles volumes.

@pmorie

pmorie Sep 30, 2015

Member

This makes me wonder if there is any utility in using Flocker as a PV, since the semantics seem intrinsic to how the Flocker agent handles volumes.

@agonzalezro

This comment has been minimized.

Show comment
Hide comment
@agonzalezro

agonzalezro Sep 22, 2015

Contributor

@rootfs Flocker is not docker/rkt dependent. We are working in documentation for it. cc: @mattbates

Contributor

agonzalezro commented Sep 22, 2015

@rootfs Flocker is not docker/rkt dependent. We are working in documentation for it. cc: @mattbates

Show outdated Hide outdated pkg/api/v1/types.go

@lavalamp lavalamp assigned dchen1107 and unassigned lavalamp Sep 22, 2015

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Sep 22, 2015

Member

@dchen1107 Can you find a code reviewer for this? I think it's mostly node stuff.

Member

lavalamp commented Sep 22, 2015

@dchen1107 Can you find a code reviewer for this? I think it's mostly node stuff.

@dchen1107 dchen1107 assigned saad-ali and unassigned dchen1107 Sep 22, 2015

@dchen1107

This comment has been minimized.

Show comment
Hide comment
@dchen1107

dchen1107 Sep 22, 2015

Member

cc/ @kubernetes/goog-cluster

Member

dchen1107 commented Sep 22, 2015

cc/ @kubernetes/goog-cluster

@agonzalezro

This comment has been minimized.

Show comment
Hide comment
@agonzalezro

agonzalezro Sep 23, 2015

Contributor

I’ve addressed all the comments I could, now we are investigating how to proceed with

  1. using VolumeConfig vs env vars
  2. size parameter
  3. volume cleaning
Contributor

agonzalezro commented Sep 23, 2015

I’ve addressed all the comments I could, now we are investigating how to proceed with

  1. using VolumeConfig vs env vars
  2. size parameter
  3. volume cleaning
@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Sep 25, 2015

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented Sep 25, 2015

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot removed the cla: yes label Sep 25, 2015

@agonzalezro

This comment has been minimized.

Show comment
Hide comment
@agonzalezro

agonzalezro Sep 30, 2015

Contributor

Hi @saad-ali I've updated the code adding your explicit err. Hoping that it looks ok now :) Thanks for the comments!

Contributor

agonzalezro commented Sep 30, 2015

Hi @saad-ali I've updated the code adding your explicit err. Hoping that it looks ok now :) Thanks for the comments!

Show outdated Hide outdated pkg/api/types.go
Show outdated Hide outdated pkg/api/types.go
Show outdated Hide outdated pkg/api/v1/types.go
Show outdated Hide outdated pkg/api/v1/types.go
@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie Sep 30, 2015

Member

LGTM mod the very minor nits about comments.

Member

pmorie commented Sep 30, 2015

LGTM mod the very minor nits about comments.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Sep 30, 2015

CLAs look good, thanks!

googlebot commented Sep 30, 2015

CLAs look good, thanks!

@agonzalezro

This comment has been minimized.

Show comment
Hide comment
@agonzalezro

agonzalezro Sep 30, 2015

Contributor

Thanks for your comments @pmorie. Everything is updated now. Hope that it looks good.

Contributor

agonzalezro commented Sep 30, 2015

Thanks for your comments @pmorie. Everything is updated now. Hope that it looks good.

@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie Sep 30, 2015

Member

LGTM, will leave to @saad-ali to tag

Member

pmorie commented Sep 30, 2015

LGTM, will leave to @saad-ali to tag

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Sep 30, 2015

Member

LGTM. Thanks @agonzalezro and @mattbates
Ok to merge on green

Member

saad-ali commented Sep 30, 2015

LGTM. Thanks @agonzalezro and @mattbates
Ok to merge on green

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Sep 30, 2015

Unit, integration and GCE e2e test build/test passed for commit e428d6f.

k8s-bot commented Sep 30, 2015

Unit, integration and GCE e2e test build/test passed for commit e428d6f.

@saad-ali saad-ali added the lgtm label Sep 30, 2015

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Sep 30, 2015

Unit, integration and GCE e2e build/test failed for commit ca8a0b7.

k8s-bot commented Sep 30, 2015

Unit, integration and GCE e2e build/test failed for commit ca8a0b7.

@agonzalezro

This comment has been minimized.

Show comment
Hide comment
@agonzalezro

agonzalezro Sep 30, 2015

Contributor

Hi, what's the problem with Jenkins? Everything looks ok in my end.

Contributor

agonzalezro commented Sep 30, 2015

Hi, what's the problem with Jenkins? Everything looks ok in my end.

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Sep 30, 2015

Member
15:15:27 Verifying ./hack/../hack/verify-generated-docs.sh
15:15:28 +++ [0930 15:15:28] Building go targets for linux/amd64:
15:15:28     cmd/gendocs
15:15:28     cmd/genman
15:15:28     cmd/genbashcomp
15:15:28     cmd/mungedocs
15:15:38 +++ [0930 15:15:38] Placing binaries
15:16:04 Some md files are missing ga-beacon analytics link:
15:16:04 /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/_gopath/src/github.com/jstemmer/go-junit-report/README.md
15:16:04 /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/_gopath/src/github.com/tools/godep/Readme.md
15:16:04 /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/_gopath/src/github.com/tools/godep/Changelog.md
15:16:04 Generated docs are out of date. Please run hack/update-generated-docs.sh
15:16:04 !!! Error in ./hack/../hack/verify-generated-docs.sh:28
15:16:04   '"${KUBE_ROOT}/hack/after-build/verify-generated-docs.sh" "$@"' exited with status 1
15:16:04 Call stack:
15:16:04   1: ./hack/../hack/verify-generated-docs.sh:28 main(...)
15:16:04 Exiting with status 1
15:16:04 FAILED
15:16:04 Verifying ./hack/../hack/verify-generated-swagger-docs.sh
15:16:07 +++ [0930 15:16:07] Building go targets for linux/amd64:
15:16:07     cmd/genswaggertypedocs
15:16:08 +++ [0930 15:16:08] Placing binaries
15:16:10 Generating swagger type docs for unversioned
15:16:12 Generating swagger type docs for v1
15:16:13 Generating swagger type docs for experimental/v1alpha1
15:16:20 +++ [0930 15:16:20] Building go targets for linux/amd64:
15:16:20     cmd/kube-apiserver
15:17:30 +++ [0930 15:17:30] Placing binaries
15:17:31 
15:17:31 etcd appears to already be running on this machine (8723 etcd.test
15:17:31 8992 etcd.test
15:17:31 9020 etcd.test
15:17:31 9056 etcd.test) (or its a zombie and you need to kill its parent).
15:17:31 
15:17:31 
15:17:31 retry after you resolve this etcd error.
15:17:31 
15:17:31 +++ [0930 15:17:31] Clean up complete
15:17:31 !!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/update-swagger-spec.sh:31
15:17:31   '"${KUBE_ROOT}/hack/after-build/update-swagger-spec.sh" "$@"' exited with status 1
15:17:31 Call stack:
15:17:31   1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/update-swagger-spec.sh:31 main(...)
15:17:31 Exiting with status 1
15:17:31 !!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/update-generated-swagger-docs.sh:68
15:17:31   '"${KUBE_ROOT}/hack/update-swagger-spec.sh"' exited with status 1
15:17:31 Call stack:
15:17:31   1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/update-generated-swagger-docs.sh:68 main(...)
15:17:31 Exiting with status 1
15:17:31 !!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/after-build/verify-generated-swagger-docs.sh:46
15:17:31   '"${KUBE_ROOT}/hack/update-generated-swagger-docs.sh"' exited with status 1
15:17:31 Call stack:
15:17:31   1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/after-build/verify-generated-swagger-docs.sh:46 main(...)
15:17:31 Exiting with status 1
15:17:31 !!! Error in ./hack/../hack/verify-generated-swagger-docs.sh:28
15:17:31   '"${KUBE_ROOT}/hack/after-build/verify-generated-swagger-docs.sh" "$@"' exited with status 1
15:17:31 Call stack:
15:17:31   1: ./hack/../hack/verify-generated-swagger-docs.sh:28 main(...)
15:17:31 Exiting with status 1
15:17:31 FAILED

Member

saad-ali commented Sep 30, 2015

15:15:27 Verifying ./hack/../hack/verify-generated-docs.sh
15:15:28 +++ [0930 15:15:28] Building go targets for linux/amd64:
15:15:28     cmd/gendocs
15:15:28     cmd/genman
15:15:28     cmd/genbashcomp
15:15:28     cmd/mungedocs
15:15:38 +++ [0930 15:15:38] Placing binaries
15:16:04 Some md files are missing ga-beacon analytics link:
15:16:04 /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/_gopath/src/github.com/jstemmer/go-junit-report/README.md
15:16:04 /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/_gopath/src/github.com/tools/godep/Readme.md
15:16:04 /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/_gopath/src/github.com/tools/godep/Changelog.md
15:16:04 Generated docs are out of date. Please run hack/update-generated-docs.sh
15:16:04 !!! Error in ./hack/../hack/verify-generated-docs.sh:28
15:16:04   '"${KUBE_ROOT}/hack/after-build/verify-generated-docs.sh" "$@"' exited with status 1
15:16:04 Call stack:
15:16:04   1: ./hack/../hack/verify-generated-docs.sh:28 main(...)
15:16:04 Exiting with status 1
15:16:04 FAILED
15:16:04 Verifying ./hack/../hack/verify-generated-swagger-docs.sh
15:16:07 +++ [0930 15:16:07] Building go targets for linux/amd64:
15:16:07     cmd/genswaggertypedocs
15:16:08 +++ [0930 15:16:08] Placing binaries
15:16:10 Generating swagger type docs for unversioned
15:16:12 Generating swagger type docs for v1
15:16:13 Generating swagger type docs for experimental/v1alpha1
15:16:20 +++ [0930 15:16:20] Building go targets for linux/amd64:
15:16:20     cmd/kube-apiserver
15:17:30 +++ [0930 15:17:30] Placing binaries
15:17:31 
15:17:31 etcd appears to already be running on this machine (8723 etcd.test
15:17:31 8992 etcd.test
15:17:31 9020 etcd.test
15:17:31 9056 etcd.test) (or its a zombie and you need to kill its parent).
15:17:31 
15:17:31 
15:17:31 retry after you resolve this etcd error.
15:17:31 
15:17:31 +++ [0930 15:17:31] Clean up complete
15:17:31 !!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/update-swagger-spec.sh:31
15:17:31   '"${KUBE_ROOT}/hack/after-build/update-swagger-spec.sh" "$@"' exited with status 1
15:17:31 Call stack:
15:17:31   1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/update-swagger-spec.sh:31 main(...)
15:17:31 Exiting with status 1
15:17:31 !!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/update-generated-swagger-docs.sh:68
15:17:31   '"${KUBE_ROOT}/hack/update-swagger-spec.sh"' exited with status 1
15:17:31 Call stack:
15:17:31   1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/update-generated-swagger-docs.sh:68 main(...)
15:17:31 Exiting with status 1
15:17:31 !!! Error in /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/after-build/verify-generated-swagger-docs.sh:46
15:17:31   '"${KUBE_ROOT}/hack/update-generated-swagger-docs.sh"' exited with status 1
15:17:31 Call stack:
15:17:31   1: /jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/hack/after-build/verify-generated-swagger-docs.sh:46 main(...)
15:17:31 Exiting with status 1
15:17:31 !!! Error in ./hack/../hack/verify-generated-swagger-docs.sh:28
15:17:31   '"${KUBE_ROOT}/hack/after-build/verify-generated-swagger-docs.sh" "$@"' exited with status 1
15:17:31 Call stack:
15:17:31   1: ./hack/../hack/verify-generated-swagger-docs.sh:28 main(...)
15:17:31 Exiting with status 1
15:17:31 FAILED

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Oct 1, 2015

CLAs look good, thanks!

googlebot commented Oct 1, 2015

CLAs look good, thanks!

@agonzalezro

This comment has been minimized.

Show comment
Hide comment
@agonzalezro

agonzalezro Oct 1, 2015

Contributor

@saad-ali I've repushed. But TBH I doubt that anything I have changed could cause the error that you pasted. Let's wait for the checks, but it should be ok! (I hope so :) Thanks!

Contributor

agonzalezro commented Oct 1, 2015

@saad-ali I've repushed. But TBH I doubt that anything I have changed could cause the error that you pasted. Let's wait for the checks, but it should be ok! (I hope so :) Thanks!

Add flocker volume plugin
Flocker [1] is an open-source container data volume manager for
Dockerized applications.

This PR adds a volume plugin for Flocker.
The plugin interfaces the Flocker Control Service REST API [2] to
attachment attach the volume to the pod.

Each kubelet host should run Flocker agents (Container Agent and Dataset
Agent).

The kubelet will also require environment variables that contain the
host and port of the Flocker Control Service. (see Flocker architecture
[3] for more).

- `FLOCKER_CONTROL_SERVICE_HOST`
- `FLOCKER_CONTROL_SERVICE_PORT`

The contribution introduces a new 'flocker' volume type to the API with
fields:

- `datasetName`: which indicates the name of the dataset in Flocker
  added to metadata;
- `size`: a human-readable number that indicates the maximum size of the
  requested dataset.

Full documentation can be found docs/user-guide/volumes.md and examples
can be found at the examples/ folder

[1] https://clusterhq.com/flocker/introduction/
[2] https://docs.clusterhq.com/en/1.3.1/reference/api.html
[3] https://docs.clusterhq.com/en/1.3.1/concepts/architecture.html
@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Oct 1, 2015

Member

Make sure to re-run hack/update-generated-docs.sh

Member

saad-ali commented Oct 1, 2015

Make sure to re-run hack/update-generated-docs.sh

@agonzalezro

This comment has been minimized.

Show comment
Hide comment
@agonzalezro

agonzalezro Oct 1, 2015

Contributor

@saad-ali I've run that & hack/update-all.sh just to be sure and nothing have changed

Contributor

agonzalezro commented Oct 1, 2015

@saad-ali I've run that & hack/update-all.sh just to be sure and nothing have changed

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Oct 1, 2015

Unit, integration and GCE e2e test build/test passed for commit 5d8fd6d.

k8s-bot commented Oct 1, 2015

Unit, integration and GCE e2e test build/test passed for commit 5d8fd6d.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Oct 1, 2015

Unit, integration and GCE e2e test build/test passed for commit fa39c2b.

k8s-bot commented Oct 1, 2015

Unit, integration and GCE e2e test build/test passed for commit fa39c2b.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 1, 2015

Contributor

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

Contributor

k8s-merge-robot commented Oct 1, 2015

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 2, 2015

Contributor

LGTM was before last commit, removing LGTM

Contributor

k8s-merge-robot commented Oct 2, 2015

LGTM was before last commit, removing LGTM

@k8s-merge-robot k8s-merge-robot removed the lgtm label Oct 2, 2015

@agonzalezro

This comment has been minimized.

Show comment
Hide comment
@agonzalezro

agonzalezro Oct 2, 2015

Contributor

Hello @saad-ali, just wondering if you need something else from me to add the LGTM label again.

Contributor

agonzalezro commented Oct 2, 2015

Hello @saad-ali, just wondering if you need something else from me to add the LGTM label again.

@saad-ali saad-ali added the lgtm label Oct 2, 2015

@saad-ali

This comment has been minimized.

Show comment
Hide comment
@saad-ali

saad-ali Oct 2, 2015

Member

LGTM re-added.
We'll let the mergebot pick this up.

Member

saad-ali commented Oct 2, 2015

LGTM re-added.
We'll let the mergebot pick this up.

@thockin

This comment has been minimized.

Show comment
Hide comment
@thockin

thockin Oct 2, 2015

Member

Manually merging

Member

thockin commented Oct 2, 2015

Manually merging

thockin added a commit that referenced this pull request Oct 2, 2015

@thockin thockin merged commit 6260759 into kubernetes:master Oct 2, 2015

3 checks passed

Jenkins GCE e2e 4460 tests run, 104 skipped, 0 failed.
Details
Shippable Shippable builds completed. 4324/4340 tests passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agonzalezro agonzalezro deleted the agonzalezro:flocker branch Oct 3, 2015

a-robinson added a commit that referenced this pull request Oct 5, 2015

Merge pull request #15036 from saad-ali/automated-cherry-pick-of-#14328
…-upstream-release-1.1

Automated cherry pick of #14328 upstream release 1.1

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

Merge pull request #15036 from saad-ali/automated-cherry-pick-of-#14328
…-upstream-release-1.1

Automated cherry pick of #14328 upstream release 1.1

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017

Merge pull request #15036 from saad-ali/automated-cherry-pick-of-#14328
…-upstream-release-1.1

Automated cherry pick of #14328 upstream release 1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment