Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make heapster config creation dynamic #16185

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Oct 23, 2015

@dchen1107 dchen1107 self-assigned this Oct 23, 2015
@dchen1107
Copy link
Member

@dchen1107 dchen1107 commented Oct 23, 2015

Could you please make sure this is cherry-pick for 1.1 release for book tracking?

LGTM

@dchen1107 dchen1107 added the lgtm label Oct 23, 2015
@k8s-github-robot k8s-github-robot added the size/M label Oct 23, 2015
@k8s-github-robot
Copy link
Contributor

@k8s-github-robot k8s-github-robot commented Oct 23, 2015

Labelling this PR as size/M

@davidopp
Copy link
Member

@davidopp davidopp commented Oct 23, 2015

Please update title to make it clear this is the cherrypick, not the original PR. Also please mention the original PR number (#16071) in the comment thread.

@k8s-bot
Copy link

@k8s-bot k8s-bot commented Oct 23, 2015

GCE e2e test build/test passed for commit eee8755.

@vishh
Copy link
Member

@vishh vishh commented Oct 23, 2015

LGTM

@k8s-github-robot
Copy link
Contributor

@k8s-github-robot k8s-github-robot commented Oct 26, 2015

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

@k8s-bot k8s-bot commented Oct 26, 2015

GCE e2e test build/test passed for commit eee8755.

@k8s-github-robot
Copy link
Contributor

@k8s-github-robot k8s-github-robot commented Oct 26, 2015

Automatic merge from submit-queue

k8s-github-robot added a commit that referenced this issue Oct 26, 2015
…-#16071-upstream-release-1.1

Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 5c1ce06 into kubernetes:release-1.1 Oct 26, 2015
4 checks passed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this issue Dec 1, 2016
…ry-pick-of-#16071-upstream-release-1.1

Auto commit by PR queue bot
shouhong pushed a commit to shouhong/kubernetes that referenced this issue Feb 14, 2017
…ry-pick-of-#16071-upstream-release-1.1

Auto commit by PR queue bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants