New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make heapster config creation dynamic #16185

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Projects
None yet
9 participants
@brendandburns
Contributor

brendandburns commented Oct 23, 2015

@googlebot googlebot added the cla: yes label Oct 23, 2015

@dchen1107 dchen1107 self-assigned this Oct 23, 2015

@dchen1107

This comment has been minimized.

Show comment
Hide comment
@dchen1107

dchen1107 Oct 23, 2015

Member

Could you please make sure this is cherry-pick for 1.1 release for book tracking?

LGTM

Member

dchen1107 commented Oct 23, 2015

Could you please make sure this is cherry-pick for 1.1 release for book tracking?

LGTM

@dchen1107 dchen1107 added the lgtm label Oct 23, 2015

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 23, 2015

Contributor

Labelling this PR as size/M

Contributor

k8s-merge-robot commented Oct 23, 2015

Labelling this PR as size/M

@k8s-teamcity-mesosphere

This comment has been minimized.

Show comment
Hide comment
@k8s-teamcity-mesosphere

k8s-teamcity-mesosphere Oct 23, 2015

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 2175 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 168 Build time: 00:04:15

k8s-teamcity-mesosphere commented on eee8755 Oct 23, 2015

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 2175 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 168 Build time: 00:04:15

@davidopp

This comment has been minimized.

Show comment
Hide comment
@davidopp

davidopp Oct 23, 2015

Member

Please update title to make it clear this is the cherrypick, not the original PR. Also please mention the original PR number (#16071) in the comment thread.

Member

davidopp commented Oct 23, 2015

Please update title to make it clear this is the cherrypick, not the original PR. Also please mention the original PR number (#16071) in the comment thread.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Oct 23, 2015

GCE e2e test build/test passed for commit eee8755.

k8s-bot commented Oct 23, 2015

GCE e2e test build/test passed for commit eee8755.

@vishh

This comment has been minimized.

Show comment
Hide comment
@vishh

vishh Oct 23, 2015

Member

LGTM

Member

vishh commented Oct 23, 2015

LGTM

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 26, 2015

Contributor

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Oct 26, 2015

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Oct 26, 2015

GCE e2e test build/test passed for commit eee8755.

k8s-bot commented Oct 26, 2015

GCE e2e test build/test passed for commit eee8755.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 26, 2015

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented Oct 26, 2015

Automatic merge from submit-queue

k8s-merge-robot added a commit that referenced this pull request Oct 26, 2015

@k8s-merge-robot k8s-merge-robot merged commit 5c1ce06 into kubernetes:release-1.1 Oct 26, 2015

4 checks passed

Jenkins GCE e2e 169 tests run, 76 skipped, 0 failed.
Details
Shippable Shippable builds completed. 4396/4414 tests passed.
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment