Skip to content

/kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make heapster config creation dynamic #16185

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
lgtm size/M
Projects
None yet
Milestone
No milestone
9 participants
@brendandburns @dchen1107 @k8s-github-robot @davidopp @k8s-bot @vishh @k8s-teamcity-mesosphere @googlebot @eparis
@brendandburns
Copy link
Contributor

commented Oct 23, 2015

@davidopp @dchen1107

Ref #15716

@googlebot googlebot added the cla: yes label Oct 23, 2015

@dchen1107 dchen1107 self-assigned this Oct 23, 2015

@dchen1107

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 23, 2015

Could you please make sure this is cherry-pick for 1.1 release for book tracking?

LGTM

@dchen1107 dchen1107 added the lgtm label Oct 23, 2015

@k8s-github-robot k8s-github-robot added the size/M label Oct 23, 2015

@k8s-github-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Oct 23, 2015

Labelling this PR as size/M
@k8s-teamcity-mesosphere

This comment has been minimized.

Sign in to view
Copy link

commented on eee8755 Oct 23, 2015

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 2175 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 168 Build time: 00:04:15
@davidopp

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 23, 2015

Please update title to make it clear this is the cherrypick, not the original PR. Also please mention the original PR number (#16071) in the comment thread.
@k8s-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 23, 2015

GCE e2e test build/test passed for commit eee8755.
@vishh

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 23, 2015

LGTM
@k8s-github-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Oct 26, 2015

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]
@k8s-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 26, 2015

GCE e2e test build/test passed for commit eee8755.
@k8s-github-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Oct 26, 2015

Automatic merge from submit-queue

k8s-github-robot added a commit that referenced this pull request Oct 26, 2015

@k8s-github-robot
Merge pull request #16185 from brendandburns/automated-cherry-pick-of… 
…-#16071-upstream-release-1.1

Auto commit by PR queue bot
Loading status checks…
5c1ce06

@k8s-github-robot k8s-github-robot merged commit 5c1ce06 into kubernetes:release-1.1 Oct 26, 2015
4 checks passed

4 checks passed

Jenkins GCE e2e 169 tests run, 76 skipped, 0 failed.
Details
Shippable Shippable builds completed. 4396/4414 tests passed.
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dchen1107 dchen1107 added the cherrypick-candidate label Oct 26, 2015

@dchen1107 dchen1107 referenced this pull request Oct 26, 2015

Closed

Profile Heapster on large clusters #15716

@eparis eparis removed the cherrypick-candidate label Mar 8, 2016

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

@k8s-github-robot
Merge pull request kubernetes#16185 from brendandburns/automated-cher… 
…ry-pick-of-#16071-upstream-release-1.1

Auto commit by PR queue bot
f1f5946

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017

@k8s-github-robot
Merge pull request kubernetes#16185 from brendandburns/automated-cher… 
…ry-pick-of-#16071-upstream-release-1.1

Auto commit by PR queue bot
116d46b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.