New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socat command to hyperkube image #17159

Merged
merged 1 commit into from Nov 13, 2015

Conversation

Projects
None yet
8 participants
@2opremio
Contributor

2opremio commented Nov 12, 2015

This is needed for port forwarding to work in kubelet.

Fixes #17157

Add socat command to hyperkube image
This is needed to for port forwarding to work in kubelet.
@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 12, 2015

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot commented Nov 12, 2015

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no label Nov 12, 2015

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Nov 12, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot commented Nov 12, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Nov 12, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot commented Nov 12, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Nov 12, 2015

Contributor

Labelling this PR as size/XS

Contributor

k8s-merge-robot commented Nov 12, 2015

Labelling this PR as size/XS

@2opremio

This comment has been minimized.

Show comment
Hide comment
@2opremio

2opremio Nov 12, 2015

Contributor

I signed it!

Contributor

2opremio commented Nov 12, 2015

I signed it!

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 12, 2015

CLAs look good, thanks!

googlebot commented Nov 12, 2015

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 12, 2015

@k8s-teamcity-mesosphere

This comment has been minimized.

Show comment
Hide comment
@k8s-teamcity-mesosphere

k8s-teamcity-mesosphere Nov 12, 2015

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 4708 outcome was FAILURE
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:18:00

Failed tests

null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 4708 outcome was FAILURE
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:18:00

Failed tests

null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

This comment has been minimized.

Show comment
Hide comment
@k8s-teamcity-mesosphere

k8s-teamcity-mesosphere Nov 12, 2015

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 4709 outcome was FAILURE
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:08

Failed tests

null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 4709 outcome was FAILURE
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:08

Failed tests

null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

@kelseyhightower

This comment has been minimized.

Show comment
Hide comment
@kelseyhightower

kelseyhightower Nov 12, 2015

Contributor

LGTM

Contributor

kelseyhightower commented Nov 12, 2015

LGTM

@brendandburns

This comment has been minimized.

Show comment
Hide comment
@brendandburns

brendandburns Nov 13, 2015

Contributor

@k8s-bot ok to unit test

Contributor

brendandburns commented Nov 13, 2015

@k8s-bot ok to unit test

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Nov 13, 2015

Contributor

@k8s-bot ok to test

pr builder appears to be missing, activating due to 'lgtm' label.
Contributor

k8s-merge-robot commented Nov 13, 2015

@k8s-bot ok to test

pr builder appears to be missing, activating due to 'lgtm' label.
@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Nov 13, 2015

Contributor

Continuous integration appears to have missed, closing and re-opening to trigger it

Contributor

k8s-merge-robot commented Nov 13, 2015

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Nov 13, 2015

Contributor

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

Contributor

k8s-merge-robot commented Nov 13, 2015

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Nov 13, 2015

GCE e2e test build/test passed for commit a9465e7.

k8s-bot commented Nov 13, 2015

GCE e2e test build/test passed for commit a9465e7.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Nov 13, 2015

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented Nov 13, 2015

Automatic merge from submit-queue

k8s-merge-robot added a commit that referenced this pull request Nov 13, 2015

@k8s-merge-robot k8s-merge-robot merged commit ec61441 into kubernetes:master Nov 13, 2015

4 checks passed

Jenkins GCE e2e 200 tests run, 89 skipped, 0 failed.
Details
Jenkins unit/integration 2382 tests run, 8 skipped, 0 failed.
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment