New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default value for DEBUG in cluster/saltbase/salt/generate-cer… #21357

Merged
merged 1 commit into from Feb 19, 2016

Conversation

Projects
None yet
8 participants
@WeixuZhuang
Contributor

WeixuZhuang commented Feb 17, 2016

…t/make-ca-cert.sh

In commit 07d7cfd, people add ${DEBUG} == "true" in file
cluster/saltbase/salt/generate-cert/make-ca-cert.sh
But the default value for DEBUG is not set. In that commit, it set the value
of DEBUG in cluster/ubuntu/util.sh where it call this script. When using this
script in saltstack to bring up cluster in other cloud platforms, it will fail
to generate the cert since we set set -o nounset in make-ca-cert.sh and var DEBUG
does not set. Set a default value for DEBUG here will fix this problem.

Set the default value for DEBUG in cluster/saltbase/salt/generate-cer…
…t/make-ca-cert.sh

In commit 07d7cfd, people add ${DEBUG} == "true" in file
cluster/saltbase/salt/generate-cert/make-ca-cert.sh
But the default value for DEBUG is not set. In that commit, it set the value
of DEBUG in cluster/ubuntu/util.sh where it call this script. When using this
script in saltstack to bring up cluster in other cloud platforms, it will fail
to generate the cert since we set set -o nounset in make-ca-cert.sh and var DEBUG
does not set. Set a default value for DEBUG here will fix this problem.

@googlebot googlebot added the cla: yes label Feb 17, 2016

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Feb 17, 2016

Contributor

Labelling this PR as size/XS

Contributor

k8s-merge-robot commented Feb 17, 2016

Labelling this PR as size/XS

@k8s-teamcity-mesosphere

This comment has been minimized.

Show comment
Hide comment
@k8s-teamcity-mesosphere

k8s-teamcity-mesosphere Feb 17, 2016

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 16059 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:51

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 16059 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:51

@luxas

This comment has been minimized.

Show comment
Hide comment
@luxas

luxas Feb 17, 2016

Member

Thanks for this one! Came across this problem yesterday

Member

luxas commented Feb 17, 2016

Thanks for this one! Came across this problem yesterday

@WeixuZhuang

This comment has been minimized.

Show comment
Hide comment
@WeixuZhuang

WeixuZhuang Feb 17, 2016

Contributor

But no one review my code...

Contributor

WeixuZhuang commented Feb 17, 2016

But no one review my code...

@luxas

This comment has been minimized.

Show comment
Hide comment
@luxas

luxas Feb 17, 2016

Member

You'll have to be patient (I'm not a maintainer)

Member

luxas commented Feb 17, 2016

You'll have to be patient (I'm not a maintainer)

@brendandburns brendandburns added the lgtm label Feb 17, 2016

@brendandburns

This comment has been minimized.

Show comment
Hide comment
@brendandburns

brendandburns Feb 17, 2016

Contributor

@k8s-bot ok to test

Contributor

brendandburns commented Feb 17, 2016

@k8s-bot ok to test

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Feb 17, 2016

GCE e2e test build/test passed for commit b3f3a80.

k8s-bot commented Feb 17, 2016

GCE e2e test build/test passed for commit b3f3a80.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Feb 17, 2016

Contributor

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

Contributor

k8s-merge-robot commented Feb 17, 2016

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@WeixuZhuang

This comment has been minimized.

Show comment
Hide comment
@WeixuZhuang

WeixuZhuang Feb 18, 2016

Contributor

@brendandburns , can my code get merged? could u tag an ok-to-merge tag.

Thanks

Contributor

WeixuZhuang commented Feb 18, 2016

@brendandburns , can my code get merged? could u tag an ok-to-merge tag.

Thanks

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Feb 19, 2016

Contributor

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Feb 19, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Feb 19, 2016

Contributor

@k8s-bot test this issue: #IGNORE

Tests have been pending for 24 hours

Contributor

k8s-merge-robot commented Feb 19, 2016

@k8s-bot test this issue: #IGNORE

Tests have been pending for 24 hours

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Feb 19, 2016

GCE e2e test build/test passed for commit b3f3a80.

k8s-bot commented Feb 19, 2016

GCE e2e test build/test passed for commit b3f3a80.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Feb 19, 2016

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented Feb 19, 2016

Automatic merge from submit-queue

k8s-merge-robot added a commit that referenced this pull request Feb 19, 2016

Merge pull request #21357 from WeixuZhuang/fix
Auto commit by PR queue bot

@k8s-merge-robot k8s-merge-robot merged commit 841d3f8 into kubernetes:master Feb 19, 2016

4 of 5 checks passed

Submit Queue Github CI tests are not green.
Details
Jenkins GCE e2e 235 tests run, 94 skipped, 0 failed.
Details
Jenkins unit/integration 2764 tests run, 9 skipped, 0 failed.
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Feb 19, 2016

GCE e2e build/test failed for commit b3f3a80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment