Skip to content

Disable seccomp policy by default on docker versions >= v1.10#21790

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
vishh:seccomp
Mar 1, 2016
Merged

Disable seccomp policy by default on docker versions >= v1.10#21790
k8s-github-robot merged 1 commit intokubernetes:masterfrom
vishh:seccomp

Conversation

@vishh
Copy link
Copy Markdown
Contributor

@vishh vishh commented Feb 23, 2016

For #20870

@dchen1107: This PR might have to be included in v1.2 if we want to be docker v1.10 compatible. Kindly add a tracking label if you agree.

@vishh vishh added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 23, 2016
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Feb 23, 2016

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2016
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Feb 23, 2016

GCE e2e test build/test passed for commit fc0c5c2bebf53674e84750df9e0fe9183efe3d42.

yujuhong
yujuhong reviewed Feb 23, 2016
View reviewed changes
Comment thread pkg/kubelet/dockertools/manager_test.go Outdated
Copy link
Copy Markdown
Contributor

@yujuhong yujuhong Feb 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/Unexpected/unexpected

Copy link
Copy Markdown
Contributor Author

@vishh vishh Feb 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing

Copy link
Copy Markdown
Contributor

@yujuhong yujuhong Feb 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not fixed...?

Copy link
Copy Markdown
Contributor Author

@vishh vishh Feb 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err. Sorry. Went ahead and fixed it all through the file.

@yujuhong
Copy link
Copy Markdown
Contributor

yujuhong commented Feb 23, 2016

Looks good overall with some nits

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Feb 24, 2016

@yujuhong: Addressed comments.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Feb 24, 2016

GCE e2e build/test failed for commit a938128d5ecc0e1f6364bbb16824e53db553fa5e.

@dchen1107
Copy link
Copy Markdown
Member

dchen1107 commented Feb 24, 2016

LGTM

@dchen1107 dchen1107 added this to the v1.2 milestone Feb 24, 2016
@dchen1107 dchen1107 added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 24, 2016
@yujuhong
Copy link
Copy Markdown
Contributor

yujuhong commented Feb 24, 2016

@k8s-bot test this: issue #21834

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Feb 24, 2016

GCE e2e test build/test passed for commit a938128d5ecc0e1f6364bbb16824e53db553fa5e.

@vishh
Disable seccomp policy by default on docker versions >= v1.10
5db37b0 
Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Feb 24, 2016

PTAL @yujuhong

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Feb 24, 2016

GCE e2e test build/test passed for commit 5db37b0.

@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2016
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Feb 25, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Feb 25, 2016

GCE e2e test build/test passed for commit 5db37b0.

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Feb 25, 2016

@k8s-bot test this github issue #21933

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Feb 25, 2016

GCE e2e build/test passed for commit 5db37b0.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Feb 25, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Feb 26, 2016

GCE e2e build/test passed for commit 5db37b0.

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Feb 29, 2016

@k8s-bot test this github issue #21933

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Feb 29, 2016

GCE e2e build/test failed for commit 5db37b0.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Mar 1, 2016

cc @kubernetes/rh-cluster-infra

@vishh
Copy link
Copy Markdown
Contributor Author

vishh commented Mar 1, 2016

@k8s-bot test this github issue #22199

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Mar 1, 2016

GCE e2e build/test passed for commit 5db37b0.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Mar 1, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Mar 1, 2016

GCE e2e build/test passed for commit 5db37b0.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Mar 1, 2016

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 1, 2016
Merge pull request #21790 from vishh/seccomp
6dee237 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 6dee237 into kubernetes:master Mar 1, 2016
@timstclair timstclair mentioned this pull request Jan 13, 2017
Closed
@thaJeztah thaJeztah mentioned this pull request Jan 3, 2018
Merged
@nikopen nikopen mentioned this pull request Nov 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yujuhong yujuhong

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.2

Development

Successfully merging this pull request may close these issues.

8 participants

@vishh @k8s-github-robot @k8s-bot @yujuhong @dchen1107 @liggitt @k8s-teamcity-mesosphere @googlebot