New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused import package from pkg/client/unversioned/daemon_sets_… #22321

Merged
merged 1 commit into from Mar 4, 2016

Conversation

Projects
None yet
9 participants
@WeixuZhuang
Contributor

WeixuZhuang commented Mar 2, 2016

…test.go

To make it pass the unit test, following is previous failing log for unit test

_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/unversioned/daemon_sets_test.go:20: imported and not used: "k8s.io/kubernetes/pkg/client/unversioned"
ok k8s.io/kubernetes/pkg/client/restclient 0.056s
ok k8s.io/kubernetes/pkg/client/transport 0.368s
ok k8s.io/kubernetes/pkg/client/typed/dynamic 0.039s
FAIL k8s.io/kubernetes/pkg/client/unversioned [build failed]

Remove unused import package from pkg/client/unversioned/daemon_sets_…
…test.go

To make it pass the unit test, following is previous failing log for unit test

_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/unversioned/daemon_sets_test.go:20: imported and not used: "k8s.io/kubernetes/pkg/client/unversioned"
ok  	k8s.io/kubernetes/pkg/client/restclient	0.056s
ok  	k8s.io/kubernetes/pkg/client/transport	0.368s
ok  	k8s.io/kubernetes/pkg/client/typed/dynamic	0.039s
FAIL	k8s.io/kubernetes/pkg/client/unversioned [build failed]

@googlebot googlebot added the cla: yes label Mar 2, 2016

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Mar 2, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot commented Mar 2, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Mar 2, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot commented Mar 2, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Mar 2, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot commented Mar 2, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Mar 2, 2016

Contributor

Labelling this PR as size/XS

Contributor

k8s-merge-robot commented Mar 2, 2016

Labelling this PR as size/XS

@k8s-teamcity-mesosphere

This comment has been minimized.

Show comment
Hide comment
@k8s-teamcity-mesosphere

k8s-teamcity-mesosphere Mar 2, 2016

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 17956 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 245 Build time: 00:03:56

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 17956 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 245 Build time: 00:03:56

@WeixuZhuang

This comment has been minimized.

Show comment
Hide comment
@WeixuZhuang

WeixuZhuang Mar 2, 2016

Contributor

Hi @bgrant0607 , can you do a review? Since I cannot pass unit test locally in my system and I get following error:
ok k8s.io/kubernetes/pkg/client/record 0.265s
k8s.io/kubernetes/pkg/client/unversioned_test
_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/unversioned/daemon_sets_test.go:20: imported and not used: "k8s.io/kubernetes/pkg/client/unversioned"
ok k8s.io/kubernetes/pkg/client/restclient 0.054s
ok k8s.io/kubernetes/pkg/client/transport 0.354s
ok k8s.io/kubernetes/pkg/client/typed/dynamic 0.060s
FAIL k8s.io/kubernetes/pkg/client/unversioned [build failed]

This fix will fix that. Thanks

Contributor

WeixuZhuang commented Mar 2, 2016

Hi @bgrant0607 , can you do a review? Since I cannot pass unit test locally in my system and I get following error:
ok k8s.io/kubernetes/pkg/client/record 0.265s
k8s.io/kubernetes/pkg/client/unversioned_test
_output/dockerized/go/src/k8s.io/kubernetes/pkg/client/unversioned/daemon_sets_test.go:20: imported and not used: "k8s.io/kubernetes/pkg/client/unversioned"
ok k8s.io/kubernetes/pkg/client/restclient 0.054s
ok k8s.io/kubernetes/pkg/client/transport 0.354s
ok k8s.io/kubernetes/pkg/client/typed/dynamic 0.060s
FAIL k8s.io/kubernetes/pkg/client/unversioned [build failed]

This fix will fix that. Thanks

@bgrant0607 bgrant0607 assigned krousey and unassigned bgrant0607 Mar 2, 2016

@krousey

This comment has been minimized.

Show comment
Hide comment
@krousey

krousey Mar 2, 2016

Member

This seems to only happen with go 1.4. This happily compiles under go 1.5 and go 1.6. I still think this should go in.

@kubernetes/sig-testing I see that the testing image was updated to use go 1.5 from go 1.4.3. Do you know if we still officially support go 1.4?

@k8s-bot ok to test

Member

krousey commented Mar 2, 2016

This seems to only happen with go 1.4. This happily compiles under go 1.5 and go 1.6. I still think this should go in.

@kubernetes/sig-testing I see that the testing image was updated to use go 1.5 from go 1.4.3. Do you know if we still officially support go 1.4?

@k8s-bot ok to test

@krousey krousey added the lgtm label Mar 2, 2016

@ixdy

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy Mar 2, 2016

Member

@krousey Kubernetes is stuck on go 1.4.2 until we resolve #20656.

Member

ixdy commented Mar 2, 2016

@krousey Kubernetes is stuck on go 1.4.2 until we resolve #20656.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 2, 2016

GCE e2e build/test passed for commit fb13a0d.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Mar 2, 2016

Contributor

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

Contributor

k8s-merge-robot commented Mar 2, 2016

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@WeixuZhuang

This comment has been minimized.

Show comment
Hide comment
@WeixuZhuang

WeixuZhuang Mar 3, 2016

Contributor

@krousey , could this code get merged ? Thanks

Contributor

WeixuZhuang commented Mar 3, 2016

@krousey , could this code get merged ? Thanks

@krousey krousey added this to the v1.2 milestone Mar 3, 2016

@krousey

This comment has been minimized.

Show comment
Hide comment
@krousey

krousey Mar 3, 2016

Member

It will be. You're in the merge queue. http://submit-queue.k8s.io/#/queue

Member

krousey commented Mar 3, 2016

It will be. You're in the merge queue. http://submit-queue.k8s.io/#/queue

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Mar 4, 2016

Contributor

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

Contributor

k8s-merge-robot commented Mar 4, 2016

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 4, 2016

GCE e2e build/test passed for commit fb13a0d.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Mar 4, 2016

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented Mar 4, 2016

Automatic merge from submit-queue

k8s-merge-robot added a commit that referenced this pull request Mar 4, 2016

Merge pull request #22321 from WeixuZhuang/unit
Auto commit by PR queue bot

@k8s-merge-robot k8s-merge-robot merged commit 0ff7186 into kubernetes:master Mar 4, 2016

5 checks passed

Jenkins GCE e2e 246 tests run, 101 skipped, 0 failed.
Details
Jenkins unit/integration 5748 tests run, 18 skipped, 0 failed.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment