Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upHeapster sizing adjustments #22940
Conversation
mwielgus
added
sig/autoscaling
do-not-merge
labels
Mar 14, 2016
mwielgus
assigned
piosz
Mar 14, 2016
mwielgus
added this to the v1.2 milestone
Mar 14, 2016
googlebot
added
the
cla: yes
label
Mar 14, 2016
k8s-merge-robot
added
the
size/M
label
Mar 14, 2016
This comment has been minimized.
This comment has been minimized.
Labelling this PR as size/M |
piosz
assigned
gmarek
and unassigned
piosz
Mar 14, 2016
This comment has been minimized.
This comment has been minimized.
k8s-bot
commented
Mar 14, 2016
GCE e2e build/test passed for commit 07d5e67. |
gmarek
reviewed
Mar 14, 2016
{% set num_nodes = pillar.get('num_nodes', -1) -%} | ||
{% if num_nodes >= 0 -%} | ||
{% set heapster_memory = (200 + num_nodes * 3)|string + "Mi" -%} | ||
{% set metrics_memory = (200 + num_nodes * 3)|string + "Mi" -%} | ||
{% set eventer_memory = (200000 + num_nodes * 200)|string + "Ki" -%} |
This comment has been minimized.
This comment has been minimized.
mwielgus
force-pushed the
mwielgus:heapster-adjustments
branch
from
07d5e67
to
798f0bd
Mar 14, 2016
This comment has been minimized.
This comment has been minimized.
k8s-bot
commented
Mar 14, 2016
GCE e2e build/test passed for commit 798f0bd. |
mwielgus
referenced this pull request
Mar 14, 2016
Closed
Eventer has the same memory requirements as Metrics Heapster #22937
This comment has been minimized.
This comment has been minimized.
please ping this thread when you think it is ready to merge |
vishh
reviewed
Mar 14, 2016
{% set num_nodes = pillar.get('num_nodes', -1) -%} | ||
{% if num_nodes >= 0 -%} | ||
{% set heapster_memory = (200 + num_nodes * 3)|string + "Mi" -%} | ||
{% set metrics_memory = (200 + num_nodes * 4)|string + "Mi" -%} |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mwielgus
Mar 14, 2016
Author
Contributor
Yes. Just in case.
For 1000 node cluster we are able to operate without any sink at 2-2.3gb (with 30k pause and 2k system pods). GKE http output creation consumes +400MB. That brings us to 2.75. If couple events occur at once: scraping, gke scraping and pod relist then the temporary memory consumption can be bigger. So to be on the VERY safe side I decided to go with 4 multpilier.
As we did a lot of noise (=events) during the tests it became apparent that Eventer should also have more memory. List that happens inside of watch consumes LOTS of memory (we will try to get rid of it just after 1.2).
mwielgus
force-pushed the
mwielgus:heapster-adjustments
branch
from
798f0bd
to
f5f6a80
Mar 14, 2016
mwielgus
removed
the
do-not-merge
label
Mar 14, 2016
This comment has been minimized.
This comment has been minimized.
Also bumping the image to beta2. |
mwielgus
force-pushed the
mwielgus:heapster-adjustments
branch
from
f5f6a80
to
6123df9
Mar 14, 2016
This comment has been minimized.
This comment has been minimized.
k8s-teamcity-mesosphere
commented on 6123df9
Mar 14, 2016
TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 19062 outcome was SUCCESS |
This comment has been minimized.
This comment has been minimized.
k8s-bot
commented
Mar 14, 2016
GCE e2e build/test passed for commit f5f6a80. |
This comment has been minimized.
This comment has been minimized.
k8s-bot
commented
Mar 14, 2016
GCE e2e build/test passed for commit 6123df9. |
davidopp
added
lgtm
priority/critical-urgent
cherrypick-candidate
labels
Mar 14, 2016
This comment has been minimized.
This comment has been minimized.
LGTM |
This comment has been minimized.
This comment has been minimized.
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
piosz
reviewed
Mar 14, 2016
{% set num_nodes = pillar.get('num_nodes', -1) -%} | ||
{% if num_nodes >= 0 -%} | ||
{% set heapster_memory = (200 + num_nodes * 3)|string + "Mi" -%} | ||
{% set metrics_memory = (200 + num_nodes * 4)|string + "Mi" -%} | ||
{% set eventer_memory = (200000 + num_nodes * 500)|string + "Ki" -%} |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
k8s-bot
commented
Mar 14, 2016
GCE e2e build/test passed for commit 6123df9. |
This comment has been minimized.
This comment has been minimized.
Automatic merge from submit-queue |
added a commit
that referenced
this pull request
Mar 14, 2016
k8s-merge-robot
merged commit f899a40
into
kubernetes:master
Mar 14, 2016
4 of 5 checks passed
This comment has been minimized.
This comment has been minimized.
PR description still says "do not merge yet". |
This comment has been minimized.
This comment has been minimized.
Not good for release-note generation |
bgrant0607
added
the
cherry-pick-approved
label
Mar 15, 2016
This comment has been minimized.
This comment has been minimized.
And please ensure all PRs have a description or at least a reference to an issue. |
andyzheng0831
referenced this pull request
Mar 15, 2016
Merged
Trusty: Fix heapster breakage caused by #22940 #23005
added a commit
to eparis/kubernetes
that referenced
this pull request
Mar 15, 2016
This comment has been minimized.
This comment has been minimized.
k8s-cherrypick-bot
commented
Mar 15, 2016
Commit be2ad9e found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this s an error find help to get your PR picked. |
k8s-cherrypick-bot
removed
the
cherrypick-candidate
label
Mar 15, 2016
This comment has been minimized.
This comment has been minimized.
@bgrant0607 Please merge it to 1.2. |
This comment has been minimized.
This comment has been minimized.
@mwielgus this is already merged to 1.2 branch. |
mwielgus commentedMar 14, 2016
Do not merge yet.