New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kubectl bash-completion namespace and resource alias aware #23262

Merged
merged 3 commits into from Apr 14, 2016

Conversation

Projects
None yet
6 participants
@sttts
Contributor

sttts commented Mar 20, 2016

kubectl-completion

  • filter resource listing by --namespace flag given before in the command line
$ kubectl get pod --namespace=kube-system <tab><tab>
kube-dns-v9-2wuzj   kube-dns-v9-llqxa
  • add completion of --namespace
$ kubectl get pod --namespace=<tab><tab>
[*]         default      ingress      kube-system
  • add support for plural nouns and aliases like rc
@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Mar 20, 2016

Contributor

Labelling this PR as size/L

Contributor

k8s-merge-robot commented Mar 20, 2016

Labelling this PR as size/L

Show outdated Hide outdated pkg/kubectl/cmd/cmd.go
@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 20, 2016

GCE e2e build/test passed for commit 98afa1f.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit 5737184.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit b1ea0e3.

@sttts sttts changed the title from WIP: Improve shell completion to Improve shell completion Mar 22, 2016

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit d065019.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Mar 22, 2016

GCE e2e build/test failed for commit 7272bfd.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot commented Mar 22, 2016

GCE e2e build/test failed for commit 7272bfd.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Mar 22, 2016

GCE e2e build/test failed for commit 3c19b65.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot commented Mar 22, 2016

GCE e2e build/test failed for commit 3c19b65.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit a43e584.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit fb3ca8d.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit c9a749c.

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Mar 22, 2016

Contributor

hack/update-godep-licenses.sh doesn't like me.

Contributor

sttts commented Mar 22, 2016

hack/update-godep-licenses.sh doesn't like me.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit 6c36665.

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Mar 22, 2016

Contributor

bash4'ism in that script.

Contributor

sttts commented Mar 22, 2016

bash4'ism in that script.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit 4ca3684.

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Mar 23, 2016

Contributor

ptal @eparis. Everything green.

Contributor

sttts commented Mar 23, 2016

ptal @eparis. Everything green.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 25, 2016

GCE e2e build/test passed for commit 7e8d88f.

@sttts sttts changed the title from Improve shell completion to WIP: Improve shell completion Mar 25, 2016

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Mar 25, 2016

Contributor
  • namespaced all zsh functions to avoid conflicts with git completion and others
  • updated godeps to spf13/cobra#257
  • added noun aliases
  • added proper compgen filtering for zsh
Contributor

sttts commented Mar 25, 2016

  • namespaced all zsh functions to avoid conflicts with git completion and others
  • updated godeps to spf13/cobra#257
  • added noun aliases
  • added proper compgen filtering for zsh
@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 26, 2016

GCE e2e build/test passed for commit 5dbfb5a.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 26, 2016

GCE e2e build/test passed for commit 8f27c06.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Mar 26, 2016

GCE e2e build/test passed for commit a059db6.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 1, 2016

Contributor

@sttts PR needs rebase

Contributor

k8s-merge-robot commented Apr 1, 2016

@sttts PR needs rebase

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Apr 1, 2016

Contributor

Rebased. But because it's based on unmerged spf13/cobra#257, it's still red due to invalid godeps.

Contributor

sttts commented Apr 1, 2016

Rebased. But because it's based on unmerged spf13/cobra#257, it's still red due to invalid godeps.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 1, 2016

GCE e2e build/test passed for commit 54de8c3.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 2, 2016

GCE e2e build/test passed for commit 481d78d.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 2, 2016

GCE e2e build/test passed for commit d93876b.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 3, 2016

GCE e2e build/test passed for commit 34ccd3c.

sttts added some commits Mar 20, 2016

Make kubectl bash completion namespace aware and add noun aliases
- add namespace filtering to bash completion
- add --namespace flag bash completion
- add bash completion noun aliases
- adapt to new cobra package structure

@sttts sttts changed the title from WIP: Improve shell completion to Make kubectl bash-completion namespace aware and add resource aliases Apr 3, 2016

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Apr 3, 2016

Contributor

Updated to latest cobra master with shellcheck fixes.

Contributor

sttts commented Apr 3, 2016

Updated to latest cobra master with shellcheck fixes.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 3, 2016

GCE e2e build/test passed for commit f832aaf.

@sttts sttts changed the title from Make kubectl bash-completion namespace aware and add resource aliases to Make kubectl bash-completion namespace and resource alias aware Apr 3, 2016

@k8s-teamcity-mesosphere

This comment has been minimized.

Show comment
Hide comment
@k8s-teamcity-mesosphere

k8s-teamcity-mesosphere Apr 3, 2016

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 20474 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 267 Build time: 00:11:34

k8s-teamcity-mesosphere commented on f832aaf Apr 3, 2016

TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests Build 20474 outcome was SUCCESS
Summary: Tests passed: 1, ignored: 267 Build time: 00:11:34

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 5, 2016

Contributor

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

Contributor

k8s-merge-robot commented Apr 5, 2016

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 5, 2016

GCE e2e build/test passed for commit f832aaf.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 5, 2016

Contributor

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Apr 5, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Apr 5, 2016

GCE e2e build/test failed for commit f832aaf.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot commented Apr 5, 2016

GCE e2e build/test failed for commit f832aaf.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Apr 12, 2016

Contributor

@k8s-bot test this please flake: #21367

Contributor

sttts commented Apr 12, 2016

@k8s-bot test this please flake: #21367

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 12, 2016

GCE e2e build/test passed for commit f832aaf.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 14, 2016

Contributor

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

Contributor

k8s-merge-robot commented Apr 14, 2016

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 14, 2016

GCE e2e build/test passed for commit f832aaf.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 14, 2016

Contributor

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented Apr 14, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented Apr 14, 2016

GCE e2e build/test passed for commit f832aaf.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 14, 2016

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented Apr 14, 2016

Automatic merge from submit-queue

@k8s-merge-robot k8s-merge-robot merged commit e121b56 into kubernetes:master Apr 14, 2016

5 of 6 checks passed

Submit Queue Github CI tests are not green.
Details
Jenkins GCE Node e2e Build finished.
Details
Jenkins GCE e2e 277 tests run, 112 skipped, 0 failed.
Details
Jenkins unit/integration 5888 tests run, 18 skipped, 0 failed.
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment