New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GarbageCollector] Add garbage collector into kube-controller-manager #26341

Merged
merged 1 commit into from May 29, 2016

Conversation

Projects
None yet
6 participants
@caesarxuchao
Member

caesarxuchao commented May 26, 2016

It's disabled by default.

Design doc is at https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/garbage-collection.md


This change is Reviewable

@caesarxuchao

This comment has been minimized.

Show comment
Hide comment
@caesarxuchao

caesarxuchao May 26, 2016

Member

I think we need this piece for 1.3. @lavalamp

Member

caesarxuchao commented May 26, 2016

I think we need this piece for 1.3. @lavalamp

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp May 26, 2016

Member

LGTM one nit.

Member

lavalamp commented May 26, 2016

LGTM one nit.

@caesarxuchao

This comment has been minimized.

Show comment
Hide comment
@caesarxuchao

caesarxuchao May 26, 2016

Member

Address the nit. Applying the lgtm per comment.

Member

caesarxuchao commented May 26, 2016

Address the nit. Applying the lgtm per comment.

@caesarxuchao caesarxuchao added lgtm and removed needs-rebase lgtm labels May 28, 2016

@caesarxuchao

This comment has been minimized.

Show comment
Hide comment
@caesarxuchao

caesarxuchao May 28, 2016

Member

Added back the lgtm after trivial rebase.

Member

caesarxuchao commented May 28, 2016

Added back the lgtm after trivial rebase.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot May 29, 2016

Contributor

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Contributor

k8s-merge-robot commented May 29, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot commented May 29, 2016

GCE e2e build/test passed for commit b3df629.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot May 29, 2016

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented May 29, 2016

Automatic merge from submit-queue

@k8s-merge-robot k8s-merge-robot merged commit 825cd92 into kubernetes:master May 29, 2016

4 of 5 checks passed

Submit Queue Github CI tests are not green.
Details
Jenkins GCE Node e2e Build finished.
Details
Jenkins GCE e2e 309 tests run, 126 skipped, 0 failed.
Details
Jenkins unit/integration 6468 tests run, 26 skipped, 0 failed.
Details
cla/google All necessary CLAs are signed

@caesarxuchao caesarxuchao changed the title from Add garbage collector into kube-controller-manager to [GarbageCollector] Add garbage collector into kube-controller-manager Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment