New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for DNS in local-up-cluster.sh #28458

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
7 participants
@rbtcollins
Contributor

rbtcollins commented Jul 4, 2016

Analytics

The default appears to be gce now, so this tries to spawn a service in
gce... not the desired outcome for a local test setup.

We also need to sync the kubectl config in the script with the instructions for users, since if people don't test with DNS enabled, it bitrots (which this aims to fix).

To test manually, run something like

sudo KUBE_ENABLE_CLUSTER_DNS=true API_HOST_IP=0.0.0.0 ./hack/local-up-cluster.sh

The API_HOST_IP=0.0.0.0 is required, otherwise the master is not contactable by kubedns, and the dns pod will fail readychecking on the healthz pod.


This change is Reviewable

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Jul 4, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no label Jul 4, 2016

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot commented Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot commented Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot commented Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot commented Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot commented Jul 4, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn Jul 11, 2016

Member

@k8s-bot ok to test

Member

zmerlynn commented Jul 11, 2016

@k8s-bot ok to test

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn Jul 11, 2016

Member

@rbtcollins: You're going to have to resolve the CLA issue before we can take this. Thanks!

Member

zmerlynn commented Jul 11, 2016

@rbtcollins: You're going to have to resolve the CLA issue before we can take this. Thanks!

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Jul 13, 2016

Contributor

CLA should be fixed now (delay was internal)

Contributor

rbtcollins commented Jul 13, 2016

CLA should be fixed now (delay was internal)

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Jul 13, 2016

Contributor

@zmerlynn CLA should be fixed now.

Contributor

rbtcollins commented Jul 13, 2016

@zmerlynn CLA should be fixed now.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn Aug 8, 2016

Member

@rbtcollins: Revisiting this, it looks like you're still having a CLA issue. I see you last attempted this in kubernetes/website#948 . It's a corporate CLA?

Member

zmerlynn commented Aug 8, 2016

@rbtcollins: Revisiting this, it looks like you're still having a CLA issue. I see you last attempted this in kubernetes/website#948 . It's a corporate CLA?

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Aug 8, 2016

Contributor

Yes indeed, a vmware corporate CLA.

Contributor

rbtcollins commented Aug 8, 2016

Yes indeed, a vmware corporate CLA.

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn Aug 9, 2016

Member

There's a way for @googlebot to recognize corporate CLAs as well, but I'm not sure how to set it up on your end (I believe it involves setting up a Google group that you join). Since this is would be your first contribution, can you email me from your VMware corporate account at the email in my profile? I'll look up the corporate CLA on our side while that happens.

Member

zmerlynn commented Aug 9, 2016

There's a way for @googlebot to recognize corporate CLAs as well, but I'm not sure how to set it up on your end (I believe it involves setting up a Google group that you join). Since this is would be your first contribution, can you email me from your VMware corporate account at the email in my profile? I'll look up the corporate CLA on our side while that happens.

@k8s-bot

This comment has been minimized.

Show comment
Hide comment
@k8s-bot

k8s-bot Aug 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

k8s-bot commented Aug 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Aug 25, 2016

Contributor

Done; sorry for the delay - was travelling and the email sat in the 'I'll get to that pile' until the bot reminded me.

Contributor

rbtcollins commented Aug 25, 2016

Done; sorry for the delay - was travelling and the email sat in the 'I'll get to that pile' until the bot reminded me.

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Sep 19, 2016

Contributor

ping @zmerlynn

Contributor

rbtcollins commented Sep 19, 2016

ping @zmerlynn

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn Sep 19, 2016

Member

CLA verified manually by email/corporate verification.

Member

zmerlynn commented Sep 19, 2016

CLA verified manually by email/corporate verification.

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Sep 20, 2016

Contributor

ping (anyone just needs the merge button clicked now, yes?)

Contributor

rbtcollins commented Sep 20, 2016

ping (anyone just needs the merge button clicked now, yes?)

@googlebot googlebot added the cla: no label Sep 20, 2016

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Sep 29, 2016

Contributor

@zmerlynn ping again.. is this able to be merged at this point ?

Contributor

rbtcollins commented Sep 29, 2016

@zmerlynn ping again.. is this able to be merged at this point ?

@zmerlynn zmerlynn added the lgtm label Oct 3, 2016

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 3, 2016

Collaborator

Jenkins GCE e2e failed for commit d5bde66. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Collaborator

k8s-ci-robot commented Oct 3, 2016

Jenkins GCE e2e failed for commit d5bde66. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 11, 2016

Collaborator

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Collaborator

k8s-merge-robot commented Oct 11, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 11, 2016

Collaborator

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Collaborator

k8s-merge-robot commented Oct 11, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 11, 2016

Collaborator

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Collaborator

k8s-merge-robot commented Oct 11, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 11, 2016

Collaborator

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Collaborator

k8s-merge-robot commented Oct 11, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 11, 2016

Collaborator

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Collaborator

k8s-merge-robot commented Oct 11, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 11, 2016

Collaborator

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Collaborator

k8s-merge-robot commented Oct 11, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 11, 2016

Collaborator

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Collaborator

k8s-merge-robot commented Oct 11, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Oct 11, 2016

Collaborator

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Collaborator

k8s-merge-robot commented Oct 11, 2016

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 3, 2016

CLAs look good, thanks!

CLAs look good, thanks!

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Nov 3, 2016

Collaborator

Jenkins verification failed for commit 74f9794. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Collaborator

k8s-ci-robot commented Nov 3, 2016

Jenkins verification failed for commit 74f9794. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 6, 2016

CLAs look good, thanks!

CLAs look good, thanks!

@rbtcollins rbtcollins changed the title from explicitly set KUBERNETES_PROVIDER in local-up-cluster. to Fix support for DNS in local-up-cluster.sh Nov 7, 2016

@k8s-merge-robot k8s-merge-robot added size/M and removed size/XS labels Nov 7, 2016

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Nov 7, 2016

Contributor

@zmerlynn sorry to ping you, but I think I got this all hammered out, if you could eyeball it again :) -thanks!

Contributor

rbtcollins commented Nov 7, 2016

@zmerlynn sorry to ping you, but I think I got this all hammered out, if you could eyeball it again :) -thanks!

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn Nov 21, 2016

Member

@rbtcollins: Sorry for the long delay. Can you squash commits before I LGTM?

Member

zmerlynn commented Nov 21, 2016

@rbtcollins: Sorry for the long delay. Can you squash commits before I LGTM?

Fix support for DNS in local-up-cluster.sh
- Fix unbound variables in hack/local-up-cluster.sh

- explicitly set KUBERNETES_PROVIDER in local-up-cluster.
  The default appears to be gce now, so this tries to spawn a service
  in gce... not the desired outcome for a local test setup.

- Remove stale creation of kube-system: the kube-system namespace is
  built in these days.

- Pickup third party etcd automatically.

- Retab hack/local-up-cluster.sh for consistency

- Update hack-local-up's internal credentials to match the user
  instructions we give (which work).

- Note the CA root requirement in local-up-cluster

- Fix a dangling comment in local-up-cluster

To test manually, run something like:
```sudo KUBE_ENABLE_CLUSTER_DNS+true API_HOST_IP=0.0.0.0
   ./hack/local-up-cluster.sh```
The API_HOST_IP=0.0.0.0 is required otherwise kubedns cannot contact
the master and the dns pod will fail readychecking on the healthz
container.
@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Nov 22, 2016

Contributor

@zmerlynn done!

Contributor

rbtcollins commented Nov 22, 2016

@zmerlynn done!

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Nov 30, 2016

Contributor

@zmerlynn this seems to be stuck - the queue is green AFAICT but the submit queue report says its not.

Contributor

rbtcollins commented Nov 30, 2016

@zmerlynn this seems to be stuck - the queue is green AFAICT but the submit queue report says its not.

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn Nov 30, 2016

Member

@k8s-bot test this
@rbtcollins It looks like this fell victim to one of a couple of instances where we just dropped a bunch of webhooks, not sure.

Member

zmerlynn commented Nov 30, 2016

@k8s-bot test this
@rbtcollins It looks like this fell victim to one of a couple of instances where we just dropped a bunch of webhooks, not sure.

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Dec 1, 2016

Contributor

@k8s-bot test this
(Can I trigger that? Looks like the GCE test failed all on its own)

Contributor

rbtcollins commented Dec 1, 2016

@k8s-bot test this
(Can I trigger that? Looks like the GCE test failed all on its own)

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Dec 1, 2016

Collaborator

@rbtcollins: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot test this
(Can I trigger that? Looks like the GCE test failed all on its own)

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

Collaborator

k8s-ci-robot commented Dec 1, 2016

@rbtcollins: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot test this
(Can I trigger that? Looks like the GCE test failed all on its own)

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Dec 1, 2016

Contributor

@zmerlynn sorry to bug you - more dropped webhooks I guess?

Contributor

rbtcollins commented Dec 1, 2016

@zmerlynn sorry to bug you - more dropped webhooks I guess?

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn Dec 1, 2016

Member

@k8s-bot cvm gce e2e test this

Member

zmerlynn commented Dec 1, 2016

@k8s-bot cvm gce e2e test this

@rmmh

This comment has been minimized.

Show comment
Hide comment
@rmmh

rmmh Dec 8, 2016

Contributor

@k8s-bot kubemark test this

Contributor

rmmh commented Dec 8, 2016

@k8s-bot kubemark test this

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Dec 8, 2016

Collaborator

Automatic merge from submit-queue (batch tested with PRs 38260, 32811, 28458, 33570, 37096)

Collaborator

k8s-merge-robot commented Dec 8, 2016

Automatic merge from submit-queue (batch tested with PRs 38260, 32811, 28458, 33570, 37096)

@k8s-merge-robot k8s-merge-robot merged commit 8cf079b into kubernetes:master Dec 8, 2016

13 checks passed

Jenkins CRI GCE Node e2e Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GCI GCE e2e Build succeeded.
Details
Jenkins GCI GKE smoke e2e Build succeeded.
Details
Jenkins GKE smoke e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins kops AWS e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation rbtcollins authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment