Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: types: document NodeSpec ID fields #32937

Merged
merged 1 commit into from Sep 19, 2016
Merged

api: types: document NodeSpec ID fields #32937

merged 1 commit into from Sep 19, 2016
+27 −15

Conversation

philips
Copy link
Contributor

@philips philips commented Sep 17, 2016 •
edited by k8s-oncall

Document MachineID as the preferred field from the discussion here:
https://groups.google.com/d/msg/kubernetes-sig-node/_3mXXB1ohZs/EuYtCzHvBgAJ

I couldn't get the generated things to update. I ran:

hack/update-generated-runtime.sh
hack/update-codegen.sh
hack/update-generated-swagger-docs.sh
hack/update-generated-protobuf.sh
hack/update-codecgen.sh

What did I miss?!

cc @dchen1107 @thockin

This change is Reviewable

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 17, 2016
@thockin
Copy link
Member

thockin commented Sep 17, 2016

ok to test

@thockin thockin added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Sep 17, 2016
@thockin
Copy link
Member

thockin commented Sep 17, 2016

You need to edit ...v1/types.go, too, and then run update-all.sh

@philips
Copy link
Contributor Author

philips commented Sep 17, 2016

@thockin thanks for the pointer. Pushed new commit.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2016
@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 19, 2016

GCE e2e build/test passed for commit 080b3d0.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 892a6d7 into kubernetes:master Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erictune erictune

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@philips @thockin @k8s-github-robot @k8s-bot @googlebot @erictune