Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #36611: validate volume spec before returning azure mounter #37018

Merged
merged 1 commit into from Dec 1, 2016
Merged

fix #36611: validate volume spec before returning azure mounter #37018

merged 1 commit into from Dec 1, 2016

Conversation

rootfs
Copy link
Contributor

@rootfs rootfs commented Nov 17, 2016 •
edited by jessfraz

cherrypick of #36611

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #36611

Special notes for your reviewer:
@colemickens
Release note:

Validate volume spec before returning azure mounter

Signed-off-by: Huamin Chen hchen@redhat.com

This change is Reviewable

@rootfs
fix kubernetes#36611: validate volume spec before returning azure mou…
ed7d7ac 
…nter

Signed-off-by: Huamin Chen <hchen@redhat.com>
@rootfs rootfs mentioned this pull request Nov 17, 2016
Closed
@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit ed7d7ac. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Nov 17, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit ed7d7ac. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit ed7d7ac. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jessfraz jessfraz added this to the v1.4 milestone Nov 19, 2016
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Nov 19, 2016
@phagunbaya
Copy link

Any ETA ?

@phagunbaya
Copy link

What's the plan to merge this one ?

@jessfraz
Copy link
Contributor

jessfraz commented Dec 1, 2016

@k8s-bot verify test this

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit ed7d7ac. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jessfraz
Copy link
Contributor

jessfraz commented Dec 1, 2016

@k8s-bot verify test this

@jessfraz
Copy link
Contributor

jessfraz commented Dec 1, 2016

manually merging since all green

@jessfraz jessfraz merged commit 6939d40 into kubernetes:release-1.4 Dec 1, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@rootfs rootfs deleted the azure-mounter-fix branch December 1, 2016 23:34
@rootfs
Copy link
Contributor Author

rootfs commented Dec 1, 2016

thank you @jessfraz

@phagunbaya
Copy link

@rootfs @jessfraz Will this be available in v1.4.7 ?

@jessfraz
Copy link
Contributor

jessfraz commented Dec 2, 2016

yes

@josibake
Copy link

Just double checking before I deploy v1.4.7 .. this is currently fixed in v1.4.7 @rootfs @jessfraz ?

@rootfs
Copy link
Contributor Author

rootfs commented Dec 13, 2016

@josibake yes it is there
ed7d7ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rootfs @k8s-ci-robot @phagunbaya @jessfraz @k8s-cherrypick-bot @josibake @googlebot @saad-ali @k8s-github-robot