Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm UX improvements for the v1.5 stable release #37568
This PR targets the next stable kubeadm release.
It's work in progress, but please comment on it and review, since there are many changes.
I tried to group the commits logically, so you can review them separately.
Q: Why this large PR? Why not many small?
Edit: This work was splitted up in three PRs in total
@pires I'm not frustrated at all.
This was a decision, but I definitely don't think this is too overwhelming to review, we reviewed ~5000 LOC in the initial, and now I've grouped the changes in some commits.
And in comparision: #36263 is twice the size of this one.
Also, this code is battle-tested e2e-wise (manually), I've used it for spinning up a lot of DigitalOcean clusters last week.
I will continue to work on it and rebase upon all changes I'm merging this week, and then get this up for final review and merge. But please choose a commit and start looking at it.
I won't measure PR complexity with LOC. The PR you linked is purely unit-testing, this is not. It touches a lot of the different pieces of code and so, to me, it's complicated to review properly.
Anyway, this is just my two cents. If you guys decided to do it, by all means!
This was referenced
Nov 29, 2016
I don't think this PR is reviewable in its current form. Even if it were acceptable to lump everything together - and I don't think it is - it is essential to ensure that the message associated with each commit clearly documents the intent of the code changes. Without that coherency, a reviewer will have a difficult time providing useful feedback for commits like 'wip' and 'a lot of changes'.
This was referenced
Dec 1, 2016
And similar improvements to
As said earlier, the three last commits are the real ones. Please only look at them.