Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Deprecate the bash deployment #38772

Merged
merged 1 commit into from Jan 31, 2017

Conversation

@zmerlynn
Copy link
Member

commented Dec 14, 2016

What this PR does / why we need it: Add a strong deprecation warning to the kube-up.sh AWS deployment.

Release note:

The bash AWS deployment via kube-up.sh has been deprecated. See http://kubernetes.io/docs/getting-started-guides/aws/ for alternatives.
@k8s-reviewable

This comment has been minimized.

Copy link

commented Dec 14, 2016

This change is Reviewable

@kris-nova

This comment has been minimized.

Copy link
Member

commented Dec 16, 2016

This LGTM - especially if we are torching deprecated code!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2016

@kris-nova: you can't LGTM a PR unless you are assigned as a reviewer.

In response to this comment:

/lgtm

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@chrislovecnm
Copy link
Member

left a comment

Makes me happy

@chrislovecnm

This comment has been minimized.

Copy link
Member

commented Dec 19, 2016

LGTM

@zmerlynn zmerlynn added the lgtm label Dec 19, 2016

@zmerlynn

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2016

Self-applying after two LGTM comments.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2016

Jenkins GKE smoke e2e failed for commit 783045c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@zmerlynn

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2016

@k8s-bot cvm gke e2e test this

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2016

Jenkins GCI GKE smoke e2e failed for commit 783045c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@zmerlynn

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2016

@k8s-bot gci gke e2e test this

@chrislovecnm

This comment has been minimized.

Copy link
Member

commented Dec 19, 2016

@zmerlynn to @justinsb's point we probably need to bring this up on our sig and sig-cluster-lifecycle. I really want this merged, but I also don't want to shoot ourselves in the foot either.

@chrislovecnm
Copy link
Member

left a comment

We need to do a bit more due diligence on this. It is deprecated, but not scheduled for removal. I really want to do it, but I want to do it with a little more information.

@zmerlynn zmerlynn added do-not-merge and removed lgtm labels Dec 19, 2016

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2017

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @jbeda
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@zmerlynn

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2017

@chrislovecnm @justinsb: Ping. I'd like to get this warning in, at least. We can gut it in a separate PR.

@justinsb

This comment has been minimized.

Copy link
Member

commented Jan 31, 2017

I actually think we should still try to remove it in 1.6, but this LGTM.

@justinsb
Copy link
Member

left a comment

LGTM

@roberthbailey

This comment has been minimized.

Copy link
Member

commented Jan 31, 2017

/lgtm /approve

@chrislovecnm

This comment has been minimized.

Copy link
Member

commented Jan 31, 2017

This makes me happy.

@zmerlynn zmerlynn added the lgtm label Jan 31, 2017

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2017

Automatic merge from submit-queue (batch tested with PRs 38772, 38797, 40732, 40740)

@k8s-github-robot k8s-github-robot merged commit 60c66dd into kubernetes:master Jan 31, 2017

14 checks passed

Jenkins Bazel Build Build succeeded.
Details
Jenkins CRI GCE Node e2e Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GCI GCE e2e Build succeeded.
Details
Jenkins GCI GKE smoke e2e Build succeeded.
Details
Jenkins GKE smoke e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins kops AWS e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation zmerlynn authorized
Details

zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request Feb 27, 2017

AWS: Kill bash deployment
c.f. kubernetes#38772, kubernetes#42194 and https://k8s-testgrid.appspot.com/google-aws#aws

cluster/kube-up.sh with KUBERNETES_PROVIDER=aws has been broken on 1.6
for a couple of months now. No one is supporting it. Nuke.

@zmerlynn zmerlynn modified the milestones: v1.5, v1.6 Feb 27, 2017

@zmerlynn

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2017

c.f. #42196 and #42194 - after a brief discussion, we're nuking the bash deployment completely. No one has stepped up to fix master, and I'm not sure any of us have time right now.

cc @mwielgus for v1.5 approval.

@zmerlynn zmerlynn deleted the zmerlynn:kube-up-aws-dead branch Feb 27, 2017

k8s-github-robot pushed a commit that referenced this pull request Feb 28, 2017

Kubernetes Submit Queue
Merge pull request #42196 from zmerlynn/nuke-kube-up-aws
Automatic merge from submit-queue

AWS: Kill bash deployment

c.f. #38772, #42194 and https://k8s-testgrid.appspot.com/google-aws#aws

cluster/kube-up.sh with KUBERNETES_PROVIDER=aws has been broken on 1.6
for a couple of months now. No one is supporting it. Nuke.

```release-note
Deployment of AWS Kubernetes clusters using the in-tree bash deployment (i.e. cluster/kube-up.sh or get-kube.sh) is obsolete. v1.5.x will be the last release to support cluster/kube-up.sh with AWS. For a list of viable alternatives, see: http://kubernetes.io/docs/getting-started-guides/aws/ 
```

k8s-github-robot pushed a commit that referenced this pull request Jul 5, 2017

Kubernetes Submit Queue
Merge pull request #42194 from zmerlynn/automated-cherry-pick-of-#387…
…72-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #38772

Cherry pick of #38772 on release-1.5, changing deprecation to 1.6.

#38772: AWS: Add a strong deprecation message
@k8s-cherrypick-bot

This comment has been minimized.

Copy link

commented Jul 5, 2017

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.