Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated for 2017 #39342

Merged
merged 2 commits into from Jan 2, 2017

Conversation

Projects
None yet
10 participants
@ixdy
Copy link
Member

ixdy commented Jan 1, 2017

What this PR does / why we need it: repeat of #19222 for 2017. Some year we'll properly fix this.

Which issue this PR fixes: fixes ci-kubernetes-verify-master build

Release note:

NONE
@k8s-reviewable

This comment has been minimized.

Copy link

k8s-reviewable commented Jan 1, 2017

This change is Reviewable

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 1, 2017

Jenkins verification failed for commit 38c924d. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Jan 1, 2017

All of the generated code needs to be recreated.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 2, 2017

Jenkins GCE e2e failed for commit 38c924d. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Jan 2, 2017

This is really dumb. Generated code should not have the copyright changed. I'll file a gengo bug. Not sure how to fix it.

@ixdy ixdy force-pushed the ixdy:happy-new-year branch from 38c924d to fae627d Jan 2, 2017

@wojtek-t wojtek-t self-assigned this Jan 2, 2017

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Jan 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 2, 2017

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Jan 2, 2017

Will merge on green (as submit queue is blocked)

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Jan 2, 2017

Merging to fix the build.

@wojtek-t wojtek-t merged commit 5e9f39b into kubernetes:master Jan 2, 2017

13 checks passed

Jenkins Bazel Build Build succeeded.
Details
Jenkins CRI GCE Node e2e Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GCI GCE e2e Build succeeded.
Details
Jenkins GCI GKE smoke e2e Build succeeded.
Details
Jenkins GKE smoke e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation ixdy authorized
Details
@ixdy

This comment has been minimized.

Copy link
Member Author

ixdy commented Jan 2, 2017

@wojtek-t thanks!
@smarterclayton I ran hack/update-all.sh -v -a but apparently it missed a file.
@thockin I agree that this is bad. I'm hoping that maybe the generated code situation will be a in a better place by 2018...

Frustratingly, the verify-boilerplate script has been copied into a number of other repos (at least contrib and test-infra, and maybe others), so we'll probably need to fix it in all of those, too.

@spxtr

This comment has been minimized.

Copy link
Member

spxtr commented Jan 2, 2017

Frustratingly, the verify-boilerplate script has been copied into a number of other repos (at least contrib and test-infra, and maybe others), so we'll probably need to fix it in all of those, too.

I think that's the goal of kubernetes/repo-infra.

@krzyzacy

This comment has been minimized.

Copy link
Member

krzyzacy commented Jan 3, 2017

Really?! I thought we support ( or we currently have ) multiple years in the boilerplate ( at least in test-infra ).

@spxtr

This comment has been minimized.

Copy link
Member

spxtr commented Jan 3, 2017

Really?! I thought we support ( or we currently have ) multiple years in the boilerplate ( at least in test-infra ).

We do, the problem is that we verify that generated code that we check in matches what you would get if you generate it from scratch, but the checked in code had 2016 in the boilerplate.

k8s-github-robot pushed a commit that referenced this pull request Jan 4, 2017

Kubernetes Submit Queue
Merge pull request #39392 from saad-ali/fixVerifyGeneratedFilesFor2017
Automatic merge from submit-queue

Update generated files for 2017 to fix broken `ci-kubernetes-verify-release-1.5`

Fixes [broken](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-verify-release-1.5/1848/) `ci-kubernetes-verify-release-1.5`

Similar to #39342 except for 1.5 branch.

@jessfraz jessfraz referenced this pull request Jan 4, 2017

Merged

fix years #39437

fabioy added a commit that referenced this pull request Jan 12, 2017

@ixdy ixdy deleted the ixdy:happy-new-year branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.