PodFitsPorts has been replaced by PodFitsHostPorts #39715

Merged
merged 1 commit into from Jan 16, 2017

Projects

None yet

7 participants

@tanshanshan
Contributor

What this PR does / why we need it:

in defaults.go

PodFitsPorts has been replaced by PodFitsHostPorts for better user understanding.
For backwards compatibility with 1.0, PodFitsPorts is registered as well.

So , I replaced PodFitsPorts with PodFitsHostPorts in scheduler examples

Special notes for your reviewer:

Release note:

@k8s-ci-robot
Collaborator

Hi @tanshanshan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-reviewable

This change is Reviewable

@tanshanshan tanshanshan PodFitsPorts has been replaced by PodFitsHostPorts
a61b5f2
@resouer
Member
resouer commented Jan 11, 2017

@k8s-bot ok to test

@@ -2,7 +2,7 @@
"kind" : "Policy",
"apiVersion" : "v1",
"predicates" : [
- {"name" : "PodFitsPorts"},
+ {"name" : "PodFitsHostPorts"},
@resouer
resouer Jan 11, 2017 edited Member

Note: PodFitsPorts is also registered for backward compatibility. But I think I am ok to replace it to PodFitsHostPorts in example here.

@thockin thockin assigned davidopp and unassigned thockin Jan 12, 2017
@thockin
Member
thockin commented Jan 12, 2017
@davidopp
Member

LGTM

@k8s-merge-robot
Collaborator

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Collaborator

Jenkins GCI GKE smoke e2e failed for commit a61b5f2. Full PR test history. cc @tanshanshan

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-merge-robot
Collaborator

Automatic merge from submit-queue

@k8s-merge-robot k8s-merge-robot merged commit 32e163c into kubernetes:master Jan 16, 2017

11 of 14 checks passed

Jenkins GCI GKE smoke e2e Build failed.
Details
Jenkins GCI GCE e2e Build started.
Details
Submit Queue Required Github CI test is not green: Jenkins GCE e2e
Details
Jenkins Bazel Build Build succeeded.
Details
Jenkins CRI GCE Node e2e Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GKE smoke e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins kops AWS e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
cla/linuxfoundation tanshanshan authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment