fix variables in openstack.go to keep camel casing and remove unused var #39735

wants to merge 1 commit into


None yet

6 participants


No description provided.

@NickrenREN NickrenREN fix variables in openstack.go to keep camel casing and remove unused var

Hi @NickrenREN. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


This change is Reviewable

@@ -46,7 +46,6 @@ const ProviderName = "openstack"
var ErrNotFound = errors.New("Failed to find object")
var ErrMultipleResults = errors.New("Multiple results where only one expected")
var ErrNoAddressFound = errors.New("No address found for host")
-var ErrAttrNotFound = errors.New("Expected attribute not found")
zhouhaibing089 Jan 11, 2017 Contributor

well, why remove this?

NickrenREN Jan 11, 2017 edited Contributor

Thanks for your review @zhouhaibing089 I can not find where it is used

NickrenREN commented Jan 12, 2017 edited

/cc @anguslees @jsafrane Sorry to bother you. Could one of you help ask k8s-bot to test and review ? Thanks


[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @anguslees
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment