Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kube-dns:1.11.0 #39925

Merged
merged 1 commit into from Jan 17, 2017
Merged

Use kube-dns:1.11.0 #39925

merged 1 commit into from Jan 17, 2017

Conversation

@sadlil
Copy link
Contributor

@sadlil sadlil commented Jan 15, 2017

Use kube-dns:1.11.0

With: kubernetes/dns#25
Fixes #26752
Fixes #33470

@bowei @thockin

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jan 15, 2017

Hi @sadlil. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-reviewable
Copy link

@k8s-reviewable k8s-reviewable commented Jan 15, 2017

This change is Reviewable

@GheRivero
Copy link
Contributor

@GheRivero GheRivero commented Jan 15, 2017

looks good to me

@bowei
Copy link
Member

@bowei bowei commented Jan 15, 2017

can you fix all of the references? git grep 'kube-dns:1.' should show

@sadlil
Copy link
Contributor Author

@sadlil sadlil commented Jan 16, 2017

@bowei updated all references.

pires
pires approved these changes Jan 17, 2017
Copy link
Member

@pires pires left a comment

lgtm

@pires
Copy link
Member

@pires pires commented Jan 17, 2017

@sadlil sorry for breaking your PR. @luxas PTAL this is a trivial change.

@tamalsaha
Copy link
Member

@tamalsaha tamalsaha commented Jan 17, 2017

@sadlil @bowei I have rebased the pr.

@kargakis
Copy link
Member

@kargakis kargakis commented Jan 17, 2017

Can you guys squash the commits into one? Then I will tag it for merging.

@tamalsaha
Copy link
Member

@tamalsaha tamalsaha commented Jan 17, 2017

@kargakis , if you can squash and merge, please go ahead and do that. It is hard to keep up with various changes affecting a PR. If you can't do that. please let me know. We can do that.

Also, fyi @thockin asked for a release note, kubernetes/dns#25 (comment)

@kargakis
Copy link
Member

@kargakis kargakis commented Jan 17, 2017

@kargakis kargakis added this to the v1.6 milestone Jan 17, 2017
@tamalsaha
Copy link
Member

@tamalsaha tamalsaha commented Jan 17, 2017

@kargakis , squashed.

@k8s-github-robot
Copy link
Contributor

@k8s-github-robot k8s-github-robot commented Jan 17, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 16f45ae into kubernetes:master Jan 17, 2017
14 checks passed
@tamalsaha tamalsaha deleted the kube-dns-1.11.0 branch Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants