Add mulitpath support to iscsi plugin

[humblec]

#issue #39345
Signed-off-by: Humble Chirammal hchiramm@redhat.com

[k8s-ci-robot]

Hi @humblec. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-reviewable]

This change is 

[humblec]

@rootfs PTAL. I havent updated the references ( update-all.sh) in apis. Once this looks good, I will add it as a seperate commit.

[rootfs]

@k8s-bot ok to test

[rootfs]

W0116 21:02:34.943] errors in package "k8s.io/kubernetes/pkg/generated/openapi":
W0116 21:02:34.944] output for "openapi/zz_generated.openapi.go" differs; first existing/expected diff: 
W0116 21:02:34.944]   "iqn\": {\n\t\t\t\t\t\tSchemaProps: spec.SchemaProps{\n\t\t\t\t\t\t\tDescription: \"Target iSCSI Qualified Name.\",\n\t\t\t"
W0116 21:02:34.944]   "backupPortal\": {\n\t\t\t\t\t\tSchemaProps: spec.SchemaProps{\n\t\t\t\t\t\t\tDescription: \"iSCSI target portal List."
W0116 21:02:34.944] 
W0116 21:02:34.975] make[1]: *** [verify_gen_openapi] Error 1
W0116 21:02:34.976] make: *** [verify_generated_files] Error 2
I0116 21:02:35.076] Makefile.generated_files:502: recipe for target 'verify_gen_openapi' failed

[rootfs]

this needs release note update too,

[rootfs]

have you run hack/verify-openapi-spec.sh

[tobad357]

Looking at the logic the iscsi implementation will always try the BackupPortal event if the primary Portal succeeds. This is something which I think is the best option, however if it always uses BackupPortal then it isn't really a Backup.

Wouldn't it be better to have a list for configurations which would be called Portals
If the user configures both Portal and Portals then just append Portal to Portals
Validation should be that either Portal or Portals has been configured

[humblec]

@tobad357 Thanks for the comment. The implementation has been done by considering the suggestions made in issue # #21306 . If everyone think for a different name than backupportal, I can definitely change it.

[tobad357]

@humblec When I wrote that issue my thinking was more in line with try the first portal and if it fails then try the backup. As it now is a list of portals and all will be used I vote to call the list "portals" and keep "portal" for backwards compatibility and ease of use

[humblec]

@rootfs hack/verify-openapi-spec.sh gives error. Looking into it.

[rootfs]

@k8s-bot verify test this

[humblec]

now, codecgen is going wrong, checking

[humblec]

@k8s-bot gci gce e2e test this

[humblec]

@rootfs can u restore LGTM and also do the needful for getting this merged ?

[rootfs]

@humblec please rebase and i'll lgtm

[humblec]

@rootfs rebased and tests are green. Can you please restore LGTM and provide approved flag ?

[rootfs]

/lgtm

[humblec]

@rootfs thanks! @childsb can you please put approved flag on this PR ?

[k8s-github-robot]

Automatic merge from submit-queue