Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Juju kubernetes-master: Fix UpdateAddonsTactic to use local repo #41251
What this PR does / why we need it:
This PR does 2 things:
We need this to guarantee that, when we are developing and building charms against a stable release, we can pull in addon versions that work with it.
Which issue this PR fixes (optional, in
Special notes for your reviewer:
Hi @Cynerva. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Fantastic, this successfully closed 213 during my testing. I'm +1
The magic incantation to run this in our CI system that builds with the appropriate templates is to have to KUBE_VERSION environment variable set, otherwise it defaults to tree, which is often some forked tip of MASTER.
@marcoceppi: you can't LGTM a PR unless you are an assignee.
[APPROVALNOTIFIER] This PR is APPROVED
The following people have approved this PR: Cynerva, chuckbutler, marcoceppi
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing