Lint fixes for the master and worker Python code. #41256

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
9 participants
@mbruzek
Member

mbruzek commented Feb 10, 2017

What this PR does / why we need it: lint fixes for the python code.

Which issue this PR fixes none

Special notes for your reviewer: This is lint fixes for the Juju python code.

Release note:

NONE

Please consider these changes so we can pass flake8 lint tests in our build process.

@k8s-reviewable

This comment has been minimized.

Show comment
Hide comment
@k8s-reviewable

k8s-reviewable Feb 10, 2017

This change is Reviewable

This change is Reviewable

@chuckbutler

This comment has been minimized.

Show comment
Hide comment
@chuckbutler

chuckbutler Feb 10, 2017

Member

+1 LGTM

/approve

Member

chuckbutler commented Feb 10, 2017

+1 LGTM

/approve

@chuckbutler

This comment has been minimized.

Show comment
Hide comment
@chuckbutler

chuckbutler Feb 10, 2017

Member

Ah, looks like it flagged a variable in our python as a bunk flag

I0210 10:40:49.434] Found illegal 'flag' usage. If these are false negatives you should run `hack/verify-flags-underscore.py -e > hack/verify-flags/exceptions.txt` to update the list.
I0210 10:40:49.435] cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py:        msg = "Cannot change {0} to {1}".format(service_cidr,
I0210 10:40:49.440] FAILED   hack/make-rules/../../hack/verify-flags-underscore.py	51s
I0210 10:40:49.440] Makefile:119: recipe for target 'verify' failed
W0210 10:40:49.541] make: *** [verify] Error 1

@mbruzek I'm still +1 to this if you can run the hack target to fix that flag validation fail. the other failures in that job run look unrelated to these changes.

Member

chuckbutler commented Feb 10, 2017

Ah, looks like it flagged a variable in our python as a bunk flag

I0210 10:40:49.434] Found illegal 'flag' usage. If these are false negatives you should run `hack/verify-flags-underscore.py -e > hack/verify-flags/exceptions.txt` to update the list.
I0210 10:40:49.435] cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py:        msg = "Cannot change {0} to {1}".format(service_cidr,
I0210 10:40:49.440] FAILED   hack/make-rules/../../hack/verify-flags-underscore.py	51s
I0210 10:40:49.440] Makefile:119: recipe for target 'verify' failed
W0210 10:40:49.541] make: *** [verify] Error 1

@mbruzek I'm still +1 to this if you can run the hack target to fix that flag validation fail. the other failures in that job run look unrelated to these changes.

@chuckbutler

This comment has been minimized.

Show comment
Hide comment
@chuckbutler

chuckbutler Feb 10, 2017

Member

/approve cancel

Member

chuckbutler commented Feb 10, 2017

/approve cancel

@mbruzek

This comment has been minimized.

Show comment
Hide comment
@mbruzek

mbruzek Feb 16, 2017

Member

I resolved the verification errors and rebased. Please review this change.

@k8s-bot verify test this
@k8s-bot gce etcd3 e2e test this

Member

mbruzek commented Feb 16, 2017

I resolved the verification errors and rebased. Please review this change.

@k8s-bot verify test this
@k8s-bot gce etcd3 e2e test this

@chuckbutler

This comment has been minimized.

Show comment
Hide comment
@chuckbutler

chuckbutler Feb 16, 2017

Member

Looks like the Jenkins-GCI-GKE-Smoke test failed due to a missing api version? thats new to me

relevant log here:

W0216 12:22:25.616] Creating cluster e2e-gke-agent-pr-50-0...
W0216 12:22:45.933] ....................done.
W0216 12:22:45.934] ERROR: (gcloud.container.clusters.create) Operation [<Operation
W0216 12:22:45.934]  name: u'operation-1487276545593-3dc39628'
W0216 12:22:45.935]  operationType: OperationTypeValueValuesEnum(CREATE_CLUSTER, 1)
W0216 12:22:45.935]  selfLink: u'https://test-container.sandbox.googleapis.com/v1/projects/943316867058/zones/us-central1-f/operations/operation-1487276545593-3dc39628'
W0216 12:22:45.935]  status: StatusValueValuesEnum(DONE, 3)
W0216 12:22:45.935]  statusMessage: u'cluster_api_version not found.'
W0216 12:22:45.935]  targetLink: u'https://test-container.sandbox.googleapis.com/v1/projects/943316867058/zones/us-central1-f/clusters/e2e-gke-agent-pr-50-0'
W0216 12:22:45.935]  zone: u'us-central1-f'>] finished with error: cluster_api_version not found.

However we didn't touch anything in GCI/GKE. This looks like a flakey test at the moment.

Member

chuckbutler commented Feb 16, 2017

Looks like the Jenkins-GCI-GKE-Smoke test failed due to a missing api version? thats new to me

relevant log here:

W0216 12:22:25.616] Creating cluster e2e-gke-agent-pr-50-0...
W0216 12:22:45.933] ....................done.
W0216 12:22:45.934] ERROR: (gcloud.container.clusters.create) Operation [<Operation
W0216 12:22:45.934]  name: u'operation-1487276545593-3dc39628'
W0216 12:22:45.935]  operationType: OperationTypeValueValuesEnum(CREATE_CLUSTER, 1)
W0216 12:22:45.935]  selfLink: u'https://test-container.sandbox.googleapis.com/v1/projects/943316867058/zones/us-central1-f/operations/operation-1487276545593-3dc39628'
W0216 12:22:45.935]  status: StatusValueValuesEnum(DONE, 3)
W0216 12:22:45.935]  statusMessage: u'cluster_api_version not found.'
W0216 12:22:45.935]  targetLink: u'https://test-container.sandbox.googleapis.com/v1/projects/943316867058/zones/us-central1-f/clusters/e2e-gke-agent-pr-50-0'
W0216 12:22:45.935]  zone: u'us-central1-f'>] finished with error: cluster_api_version not found.

However we didn't touch anything in GCI/GKE. This looks like a flakey test at the moment.

@chuckbutler

This comment has been minimized.

Show comment
Hide comment
@chuckbutler

chuckbutler Feb 16, 2017

Member

This looks fine to me based on the interactions with the hack script for validation of flag underscores (man that legacy thing kinda irks me). Thanks for fixing this up @mbruzek

/approve

Member

chuckbutler commented Feb 16, 2017

This looks fine to me based on the interactions with the hack script for validation of flag underscores (man that legacy thing kinda irks me). Thanks for fixing this up @mbruzek

/approve

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi

marcoceppi Feb 16, 2017

Member

/approve

Member

marcoceppi commented Feb 16, 2017

/approve

@mbruzek

This comment has been minimized.

Show comment
Hide comment
@mbruzek

mbruzek Feb 17, 2017

Member

I don't know how or why this change could fail the etcd3 tests.

@k8s-bot gce etcd3 e2e test this

Member

mbruzek commented Feb 17, 2017

I don't know how or why this change could fail the etcd3 tests.

@k8s-bot gce etcd3 e2e test this

@mbruzek

This comment has been minimized.

Show comment
Hide comment
@mbruzek

mbruzek Feb 17, 2017

Member

@nikhiljindal Is it possible to take a look at this small PR before the code freeze?

Member

mbruzek commented Feb 17, 2017

@nikhiljindal Is it possible to take a look at this small PR before the code freeze?

@soltysh soltysh self-assigned this Feb 17, 2017

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Feb 17, 2017

Contributor

@k8s-bot gci gke e2e test this

Contributor

soltysh commented Feb 17, 2017

@k8s-bot gci gke e2e test this

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Feb 17, 2017

Contributor

@k8s-bot gce etcd3 e2e test this

Contributor

soltysh commented Feb 17, 2017

@k8s-bot gce etcd3 e2e test this

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Feb 17, 2017

Contributor

Generally this is ok.

/lgtm

Contributor

soltysh commented Feb 17, 2017

Generally this is ok.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 17, 2017

@deads2k

This comment has been minimized.

Show comment
Hide comment
@deads2k

deads2k Feb 20, 2017

Contributor

/approve

Contributor

deads2k commented Feb 20, 2017

/approve

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Feb 20, 2017

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: chuckbutler, deads2k, marcoceppi, mbruzek

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Collaborator

k8s-merge-robot commented Feb 20, 2017

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: chuckbutler, deads2k, marcoceppi, mbruzek

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mbruzek

This comment has been minimized.

Show comment
Hide comment
@mbruzek

mbruzek Feb 21, 2017

Member

@k8s-bot unit test this

Member

mbruzek commented Feb 21, 2017

@k8s-bot unit test this

@chuckbutler

This comment has been minimized.

Show comment
Hide comment
@chuckbutler

chuckbutler Feb 22, 2017

Member

Is this on its way to the submit queue? or are we still blocked? The test overview looks fine to me. all 16 checks have passed but it's at risk of going over the X hour check where it will expire and need re-testing.

Member

chuckbutler commented Feb 22, 2017

Is this on its way to the submit queue? or are we still blocked? The test overview looks fine to me. all 16 checks have passed but it's at risk of going over the X hour check where it will expire and need re-testing.

@chuckbutler chuckbutler referenced this pull request Feb 22, 2017

Merged

Multi master patch #41351

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Feb 22, 2017

Collaborator

Automatic merge from submit-queue (batch tested with PRs 41349, 41532, 41256, 41587, 41657)

Collaborator

k8s-merge-robot commented Feb 22, 2017

Automatic merge from submit-queue (batch tested with PRs 41349, 41532, 41256, 41587, 41657)

@k8s-merge-robot k8s-merge-robot merged commit b29bdee into kubernetes:master Feb 22, 2017

16 checks passed

Jenkins Bazel Build Build succeeded.
Details
Jenkins CRI GCE Node e2e Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GCI GCE e2e Build succeeded.
Details
Jenkins GCI GKE smoke e2e Build succeeded.
Details
Jenkins GKE smoke e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins kops AWS e2e Build succeeded.
Details
Jenkins non-CRI GCE Node e2e Build succeeded.
Details
Jenkins non-CRI GCE e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation mbruzek authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment