Join GitHub today
Lint fixes for the master and worker Python code. #41256
What this PR does / why we need it: lint fixes for the python code.
Which issue this PR fixes none
Special notes for your reviewer: This is lint fixes for the Juju python code.
Please consider these changes so we can pass flake8 lint tests in our build process.
Ah, looks like it flagged a variable in our python as a bunk flag
@mbruzek I'm still +1 to this if you can run the hack target to fix that flag validation fail. the other failures in that job run look unrelated to these changes.
Looks like the Jenkins-GCI-GKE-Smoke test failed due to a missing api version? thats new to me
relevant log here:
However we didn't touch anything in GCI/GKE. This looks like a flakey test at the moment.
[APPROVALNOTIFIER] This PR is APPROVED
The following people have approved this PR: chuckbutler, deads2k, marcoceppi, mbruzek
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing