New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable DefaultTolerationSeconds admission controller by default #41815

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Projects
None yet
8 participants
@kevin-wangzefeng
Copy link
Member

kevin-wangzefeng commented Feb 21, 2017

What this PR does / why we need it:
Continuation of PR #41414, enable DefaultTolerationSeconds admission controller by default.

Which issue this PR fixes:
fixes: #41860
related Issue: #1574, #25320
related PRs: #34825, #41133, #41414

Special notes for your reviewer:

Release note:

enable DefaultTolerationSeconds admission controller by default
@k8s-reviewable

This comment has been minimized.

Copy link

k8s-reviewable commented Feb 21, 2017

This change is Reviewable

@kevin-wangzefeng kevin-wangzefeng assigned davidopp and unassigned eparis Feb 21, 2017

@kevin-wangzefeng kevin-wangzefeng added this to the v1.6 milestone Feb 21, 2017

@kevin-wangzefeng

This comment has been minimized.

Copy link
Member

kevin-wangzefeng commented Feb 21, 2017

@davidopp PTAL.

@eparis

This comment has been minimized.

Copy link
Member

eparis commented Feb 21, 2017

/approve

@kevin-wangzefeng kevin-wangzefeng force-pushed the kevin-wangzefeng:enable-defaulttolerationseconds-admission-controller branch from 4c44e64 to cd427fa Feb 21, 2017

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Feb 21, 2017

@derekwaynecarr @kubernetes/rh-cluster-infra

@aveshagarwal

This comment has been minimized.

Copy link
Member

aveshagarwal commented Feb 21, 2017

@kevin-wangzefeng though changes look good, but in the original description, the issue it points to is your previous PR not an actual issue?

@kevin-wangzefeng

This comment has been minimized.

Copy link
Member

kevin-wangzefeng commented Feb 22, 2017

@aveshagarwal, do you mean the issue description? I refreshed a little bit, and added a link to the original feature discussion issue.

@davidopp

This comment has been minimized.

Copy link
Member

davidopp commented Feb 22, 2017

Could someone from @kubernetes/sig-cluster-lifecycle-misc verify that this PR is the correct way to enable the DefaultTolerationSeconds admission controller across all environments?

And for good measure, cc/ @lavalamp @mikedanese

@aveshagarwal

This comment has been minimized.

Copy link
Member

aveshagarwal commented Feb 22, 2017

@kevin-wangzefeng sgtm. thanks.

@davidopp

This comment has been minimized.

Copy link
Member

davidopp commented Feb 22, 2017

LGTM

Thanks!

I'm going to wait to approve until we merge #38957, just so people who run the code from HEAD don't end up with a bunch of annotations.

@davidopp

This comment has been minimized.

Copy link
Member

davidopp commented Feb 23, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 23, 2017

@davidopp davidopp added the approved label Feb 23, 2017

@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Feb 23, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: davidopp, eparis, kevin-wangzefeng

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @mml @derekwaynecarr @jbeda
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Feb 26, 2017

Automatic merge from submit-queue (batch tested with PRs 40932, 41896, 41815, 41309, 41628)

@k8s-merge-robot k8s-merge-robot merged commit 77ba346 into kubernetes:master Feb 26, 2017

16 checks passed

Jenkins Bazel Build Build succeeded.
Details
Jenkins Cross Build Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GCI GCE e2e Build succeeded.
Details
Jenkins GCI GKE smoke e2e Build succeeded.
Details
Jenkins GKE smoke e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins kops AWS e2e Build succeeded.
Details
Jenkins non-CRI GCE Node e2e Build succeeded.
Details
Jenkins non-CRI GCE e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation kevin-wangzefeng authorized
Details

@xilabao xilabao referenced this pull request Feb 28, 2017

Closed

kubeadm failed to start #42228

@davidopp davidopp referenced this pull request Feb 28, 2017

Open

Taint Based Eviction #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment