Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
fix staging godeps #41910
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
label
Feb 22, 2017
k8s-reviewable
commented
Feb 22, 2017
k8s-merge-robot
assigned
spxtr
Feb 22, 2017
k8s-merge-robot
added
size/L
release-note-label-needed
labels
Feb 22, 2017
|
@deads2k -- this looks like your area? |
|
I just saw this too. I'm trying to figure out how something merged without being verified. |
|
/lgtm |
|
@deads2k: you can't LGTM a PR unless you are an assignee. In response to this comment:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@deads2k: you can only set release notes if you are the author or an assignee. In response to this comment:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
deads2k
self-assigned this
Feb 22, 2017
|
/lgtm |
k8s-ci-robot
added
release-note-none
lgtm
and removed
release-note-label-needed
labels
Feb 22, 2017
|
[APPROVALNOTIFIER] This PR is NOT APPROVED The following people have approved this PR: deads2k, sjenning Needs approval from an approver in each of these OWNERS Files:
We suggest the following people: |
deads2k
added
the
approved
label
Feb 22, 2017
|
#41650 merged via the queue. I don't understand how we got dirty unless the bot did some crazy stuff. |
|
@eparis once verification passes, this deserves a manual merge. |
deads2k
added
priority/P0
queue/critical-fix
labels
Feb 22, 2017
spxtr
assigned
eparis
and unassigned
spxtr
Feb 22, 2017
|
merging by hand. All test passed. Will unblock queue. |
sjenning commentedFeb 22, 2017
•
Edited 1 time
-
sjenning
Feb 22, 2017
Fixes #41909
Just ran
hack/update-staging-godeps.shon master