fix staging godeps #41910

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
8 participants
Contributor

sjenning commented Feb 22, 2017

Fixes #41909

Just ran hack/update-staging-godeps.sh on master

This change is Reviewable

Owner

derekwaynecarr commented Feb 22, 2017

@deads2k -- this looks like your area?

Contributor

deads2k commented Feb 22, 2017

I just saw this too. I'm trying to figure out how something merged without being verified.

Contributor

deads2k commented Feb 22, 2017

/lgtm
/approve
/release-note-none

Collaborator

k8s-ci-robot commented Feb 22, 2017

@deads2k: you can't LGTM a PR unless you are an assignee.

In response to this comment:

/lgtm
/approve
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Collaborator

k8s-ci-robot commented Feb 22, 2017

@deads2k: you can only set release notes if you are the author or an assignee.

In response to this comment:

/lgtm
/approve
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k self-assigned this Feb 22, 2017

Contributor

deads2k commented Feb 22, 2017

/lgtm
/approve
/release-note-none

Collaborator

k8s-merge-robot commented Feb 22, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: deads2k, sjenning

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @lavalamp
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k deads2k added the approved label Feb 22, 2017

Contributor

deads2k commented Feb 22, 2017

#41650 merged via the queue. I don't understand how we got dirty unless the bot did some crazy stuff.

Contributor

deads2k commented Feb 22, 2017

@eparis once verification passes, this deserves a manual merge.

@spxtr spxtr assigned eparis and unassigned spxtr Feb 22, 2017

Owner

eparis commented Feb 22, 2017

merging by hand. All test passed. Will unblock queue.

@eparis eparis merged commit 2e12711 into kubernetes:master Feb 22, 2017

13 of 15 checks passed

Jenkins GCI GCE e2e Build started.
Details
Jenkins non-CRI GCE e2e Build started.
Details
Jenkins Bazel Build Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GCI GKE smoke e2e Build succeeded.
Details
Jenkins GKE smoke e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins kops AWS e2e Build succeeded.
Details
Jenkins non-CRI GCE Node e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation sjenning authorized
Details

@sjenning sjenning deleted the sjenning:fix-staging-godeps branch Aug 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment