Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Make DaemonSet respect critical pods annotation when scheduling #42028
What this PR does / why we need it: #41612
Which issue this PR fixes (optional, in
Special notes for your reviewer:
Sigh; this PR shows why the critical pods thing is such an awful hack. I'm looking forward to getting rid of it ASAP.
BTW in the future please try to get an approve from me or @timothysc for changes to the scheduler. We would have approved this change anyway, but it's easy to miss @ mentions so that's unfortunately the only way to ensure that between him and me we know what's going on.
[APPROVALNOTIFIER] This PR is NOT APPROVED
The following people have approved this PR: janetkuo, k8s-merge-robot, vishh
Needs approval from an approver in each of these OWNERS Files: