New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juju: Fix shebangs in charm actions to use python3 #42058

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
7 participants
@Cynerva
Copy link
Contributor

Cynerva commented Feb 24, 2017

What this PR does / why we need it:

This fixes the microbot and create-rbd-pv actions by reverting them back to python3. We accidentally switched them to python2 to match the boilerplate checker's expectations for python files.

It looks like hack/verify-boilerplate.sh does not check these since they don't have the .py extension, so we should be good with no changes there.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

juju-solutions/bundle-canonical-kubernetes#212

Special notes for your reviewer:

Release note:

Juju: Fix shebangs in charm actions to use python3
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 24, 2017

Hi @Cynerva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-reviewable

This comment has been minimized.

Copy link

k8s-reviewable commented Feb 24, 2017

This change is Reviewable

@lazypower

This comment has been minimized.

Copy link
Member

lazypower commented Feb 24, 2017

@k8s-bot ok to test

/approve

@mbruzek

This comment has been minimized.

Copy link
Member

mbruzek commented Feb 24, 2017

We need these fixes! Thanks @Cynerva

/approve

@Cynerva

This comment has been minimized.

Copy link
Contributor

Cynerva commented Feb 24, 2017

@k8s-bot kubemark e2e test this
@k8s-bot kops aws e2e test this

@krousey

This comment has been minimized.

Copy link
Member

krousey commented Feb 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 24, 2017

@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Feb 24, 2017

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: Cynerva, chuckbutler, krousey, mbruzek

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Feb 27, 2017

Automatic merge from submit-queue (batch tested with PRs 42058, 41160, 42065, 42076, 39338)

@k8s-merge-robot k8s-merge-robot merged commit 4f277b4 into kubernetes:master Feb 27, 2017

15 checks passed

Jenkins Bazel Build Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GCI GCE e2e Build succeeded.
Details
Jenkins GCI GKE smoke e2e Build succeeded.
Details
Jenkins GKE smoke e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins kops AWS e2e Build succeeded.
Details
Jenkins non-CRI GCE Node e2e Build succeeded.
Details
Jenkins non-CRI GCE e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation Cynerva authorized
Details
@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Feb 27, 2017

Automatic merge from submit-queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment