move category expansion out of restmapper #43622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/L
|
This change is |
deads2k
force-pushed
the
cli-10-category
branch
from
7aecee9
to
cfa1478
Compare
k8s-github-robot
added
size/XL
|
@k8s-bot verify test this |
deads2k
force-pushed
the
cli-10-category
branch
from
cfa1478
to
8895f31
Compare
|
@fabianofranz I suspect you're pretty close to this at the moment given the discovery changes. I think I fixed the go vet problem. |
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k, fabianofranz
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
do-not-merge
fabianofranz
added
release-note-none
I don't think the overriding of "all" ever worked on our CLI since |
deads2k
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 42087, 43383, 43622) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESTMapping isn't related to CategoryExpansion (the bit that expands "all" into items to be RESTMapped). This provides that separation and simplifies the RESTMapper interface.
@kubernetes/sig-cli-pr-reviews