Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] [POC] containerd kubernetes integration. #43655

Conversation

Projects
None yet
8 participants
@Random-Liu
Copy link
Member

commented Mar 25, 2017

This is a Proof-of-Concept for containerd Kubernetes integration. Sent it here just for feedback, PLEASE DO NOT MERGE THIS.

Try it out

  • Pull this PR down;
  • Build and install containerd (version: docker/containerd@5f6edd0)
  • Build and install runc (version: opencontainers/runc@4449acd)
  • Make sure containerd, containerd-shim, dist, runc are in $PATH.
  • Start containerd.
  • Start a local cluster with hack/local-cluster-up.sh
  • Create/delete the pod:
apiVersion: v1
kind: Pod
metadata:
  name: redis
spec:
  restartPolicy: Never
  containers:
  - name: redis
    image: docker.io/library/redis:latest
    command: ["redis-server", "--bind", "0.0.0.0"]

Current status of the POC

  • Pod lifecycle and image lifecycle are supported (including pod creation/deletion/list/inspect, image pull/list).
    • Pod lifecycle management is using containerd grpc api;
    • Image management is mainly using containerd cli dist just for convenience. Only docker.io/library/xxx image is supported now.
  • Streaming and container logs are not supported yet.
  • Detailed pod/container configuration are not supported yet, e.g. DNSOptions, Env etc.
  • Required metadata is stored in memory instead of checkpoint.

Dependencies versions

Please feel free to comment if you have any suggestion/question/idea.

@mikebrow Thanks for your help with the POC!
@yujuhong @dchen1107 @thockin @crosbymichael @stevvooe @feiskyer @resouer /cc @kubernetes/sig-node-feature-requests

Random-Liu added some commits Mar 24, 2017

@k8s-reviewable

This comment has been minimized.

Copy link

commented Mar 25, 2017

This change is Reviewable

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Random-Liu
We suggest the following additional approver: @thockin

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mikebrow

This comment has been minimized.

Copy link
Member

commented Mar 25, 2017

Note: To bring up a cluster locally as root and direct kubelet to use containerd:

sudo PATH=$PATH KUBERNETES_PROVIDER=local EXPERIMENTAL_CRI=true CONTAINER_RUNTIME=containerd hack/local-up-cluster.sh
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2017

@Random-Liu: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins Bazel Build 6c86069 link @k8s-bot bazel test this
pull-kubernetes-cross 6c86069 link @k8s-bot pull-kubernetes-cross test this
Jenkins unit/integration 6c86069 link @k8s-bot unit test this
Jenkins verification 6c86069 link @k8s-bot verify test this
Jenkins Kubemark GCE e2e 6c86069 link @k8s-bot kubemark e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thockin

This comment has been minimized.

Copy link
Member

commented Mar 27, 2017

Kick ass!

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2017

@Random-Liu PR needs rebase

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 17, 2017

The new cri-containerd repository has been created. Time to close this PR? @Random-Liu

@Random-Liu

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2017

@yujuhong Sure.

Close this one. The real CRI containerd integration work will happen in https://github.com/kubernetes-incubator/cri-containerd.

@Random-Liu Random-Liu closed this Apr 17, 2017

@Random-Liu Random-Liu deleted the Random-Liu:poc-containerd-kubernetes-integration branch Apr 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.