New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gen_api_ref_docs to use same diff method as verify #44109

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
5 participants
@cblecker
Member

cblecker commented Apr 5, 2017

What this PR does / why we need it:
Fixes an issue where there is a discrepancy between the update and verify diff methods for the api-reference-docs. This can create a situation where verify will see changes, but update won't fix them.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #31129

Special notes for your reviewer:

Release note:

NONE
@k8s-reviewable

This comment has been minimized.

Show comment
Hide comment
@k8s-reviewable

k8s-reviewable Apr 5, 2017

This change is Reviewable

k8s-reviewable commented Apr 5, 2017

This change is Reviewable

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Apr 5, 2017

Member

@k8s-bot non-cri e2e test this

Member

cblecker commented Apr 5, 2017

@k8s-bot non-cri e2e test this

@fejta

This comment has been minimized.

Show comment
Hide comment
@fejta

fejta Apr 5, 2017

Contributor

/lgtm

Contributor

fejta commented Apr 5, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 5, 2017

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 5, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

k8s-merge-robot commented Apr 5, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 6, 2017

Contributor

Automatic merge from submit-queue (batch tested with PRs 44104, 43903, 44109)

Contributor

k8s-merge-robot commented Apr 6, 2017

Automatic merge from submit-queue (batch tested with PRs 44104, 43903, 44109)

@k8s-merge-robot k8s-merge-robot merged commit b983cc7 into kubernetes:master Apr 6, 2017

14 checks passed

Jenkins Bazel Build Build succeeded.
Details
Jenkins GCE Node e2e Build succeeded.
Details
Jenkins GCE e2e Build succeeded.
Details
Jenkins GCE etcd3 e2e Build succeeded.
Details
Jenkins GCI GCE e2e Build succeeded.
Details
Jenkins Kubemark GCE e2e Build succeeded.
Details
Jenkins kops AWS e2e Build succeeded.
Details
Jenkins non-CRI GCE Node e2e Build succeeded.
Details
Jenkins non-CRI GCE e2e Build succeeded.
Details
Jenkins unit/integration Build succeeded.
Details
Jenkins verification Build succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-cross Build succeeded.
Details

@cblecker cblecker deleted the cblecker:swagger-hack-fix branch Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment