New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce replication_controller log spam #44391

Merged
merged 1 commit into from Apr 13, 2017

Conversation

Projects
None yet
8 participants
@ncdc
Member

ncdc commented Apr 12, 2017

Decrease verbosity and reword 'Observed updated replication controller
...' now that the issue it was added for has been fixed.

This was originally added to debug #31981, and it was fixed back in September 2016.

cc @gmarek @wojtek-t @kargakis @eparis @smarterclayton

@ncdc

This comment has been minimized.

Show comment
Hide comment
@ncdc

ncdc Apr 12, 2017

Member

@sttts assuming this gets approved, let's pick it

Member

ncdc commented Apr 12, 2017

@sttts assuming this gets approved, let's pick it

@k8s-reviewable

This comment has been minimized.

Show comment
Hide comment
@k8s-reviewable

k8s-reviewable Apr 12, 2017

This change is Reviewable

k8s-reviewable commented Apr 12, 2017

This change is Reviewable

@eparis

This comment has been minimized.

Show comment
Hide comment
@eparis

eparis Apr 12, 2017

Member

Should it also be gated on: oldRC.Spec.Replicas != curRC.Spec.Replicas ? Once its at V(4) I'm not likely to ever see it, but I think its still spam a lot of the time. No?

Member

eparis commented Apr 12, 2017

Should it also be gated on: oldRC.Spec.Replicas != curRC.Spec.Replicas ? Once its at V(4) I'm not likely to ever see it, but I think its still spam a lot of the time. No?

@wojtek-t wojtek-t self-assigned this Apr 12, 2017

@wojtek-t

This comment has been minimized.

Show comment
Hide comment
@wojtek-t

wojtek-t Apr 12, 2017

Member

/lgtm
/approve

Thanks!

Member

wojtek-t commented Apr 12, 2017

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 12, 2017

@sttts sttts added the approved label Apr 12, 2017

@sttts

This comment has been minimized.

Show comment
Hide comment
@sttts

sttts Apr 12, 2017

Contributor

@ncdc picked.

Contributor

sttts commented Apr 12, 2017

@ncdc picked.

@kargakis kargakis removed the lgtm label Apr 12, 2017

Reduce replication_controller log spam
Decrease verbosity and reword 'Observed updated replication controller
...' now that the issue it was added for has been fixed.
@ncdc

This comment has been minimized.

Show comment
Hide comment
@ncdc

ncdc Apr 12, 2017

Member

@eparis @kargakis @wojtek-t updated based on comments

Member

ncdc commented Apr 12, 2017

@eparis @kargakis @wojtek-t updated based on comments

@kargakis

This comment has been minimized.

Show comment
Hide comment
@kargakis

kargakis Apr 12, 2017

Member

/lgtm

Member

kargakis commented Apr 12, 2017

/lgtm

@wojtek-t

This comment has been minimized.

Show comment
Hide comment
@wojtek-t

wojtek-t Apr 12, 2017

Member

lgtm

Member

wojtek-t commented Apr 12, 2017

lgtm

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 12, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kargakis, ncdc, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

k8s-merge-robot commented Apr 12, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kargakis, ncdc, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ncdc

This comment has been minimized.

Show comment
Hide comment
@ncdc

ncdc Apr 12, 2017

Member

@k8s-bot cvm gce e2e test this

Member

ncdc commented Apr 12, 2017

@k8s-bot cvm gce e2e test this

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 13, 2017

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented Apr 13, 2017

Automatic merge from submit-queue

@k8s-merge-robot k8s-merge-robot merged commit e4752d6 into kubernetes:master Apr 13, 2017

11 of 13 checks passed

Jenkins GCI GCE e2e Jenkins job triggered.
Details
Submit Queue Required Github CI test is not green: Jenkins GCE etcd3 e2e
Details
Jenkins Bazel Build Job succeeded.
Details
Jenkins GCE Node e2e Jenkins job succeeded.
Details
Jenkins GCE e2e Jenkins job succeeded.
Details
Jenkins GCE etcd3 e2e Jenkins job succeeded.
Details
Jenkins Kubemark GCE e2e Jenkins job succeeded.
Details
Jenkins kops AWS e2e Jenkins job succeeded.
Details
Jenkins non-CRI GCE Node e2e Jenkins job succeeded.
Details
Jenkins non-CRI GCE e2e Jenkins job succeeded.
Details
Jenkins unit/integration Jenkins job succeeded.
Details
Jenkins verification Jenkins job succeeded.
Details
cla/linuxfoundation ncdc authorized
Details

@ncdc ncdc deleted the ncdc:reduce-rc-logging branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment