Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
prevent installation of docker from upstream #44681
What this PR does / why we need it: Disallows installation of upstream docker from PPA in the Juju kubernetes-worker charm.
Which issue this PR fixes (optional, in
Special notes for your reviewer:
Hi @wwwtyro. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
This PR only handles half of the situation. It does remove the config flag for fresh deployments, but we also need to consider the upgrading users scenario where if they have enabled this, we're heading them down a sad path.
I feel like this shoudl also include some removal code to revert the daemon installation to archive at this juncture so we dont have users upgrading into a broken state.
[APPROVALNOTIFIER] This PR is APPROVED
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing