New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname patch for vsphere provider limitations with juju #44780

Merged
merged 1 commit into from Apr 22, 2017

Conversation

Projects
None yet
7 participants
@lazypower
Member

lazypower commented Apr 21, 2017

What this PR does / why we need it:
The Juju VSphere provider doesn't set a unique hostname which causes issues when scaling worker-pools and they all have the hostname ubuntuguest. Instead we assign the JUJU_UNIT_NAME to that hostname to prevent the collision which allows the master to sort out that there are multiple units and not one attempting re-registration.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes juju-solutions/bundle-canonical-kubernetes#237

Special notes for your reviewer:
The charm-pre-exec runs before it installs the charm software so the validation can happen quickly. Check hostname output, as well as kubectl get no post deployment.

Resolves juju vsphere hostname bug showing only a single node in a scaled node-pool.
@k8s-reviewable

This comment has been minimized.

Show comment
Hide comment
@k8s-reviewable

k8s-reviewable Apr 21, 2017

This change is Reviewable

k8s-reviewable commented Apr 21, 2017

This change is Reviewable

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi

marcoceppi Apr 21, 2017

Member

I think this is a good place to resolve this, in exec.d, just a few places to simplify logic

Member

marcoceppi commented Apr 21, 2017

I think this is a good place to resolve this, in exec.d, just a few places to simplify logic

Hostname patch for vsphere provider limitations with juju
This patch sets the hostname to a unique identifier (the juju unit name)
during pre-deployment of the charm. This may not be a FQDN resolveable
hostname but will prevent hostname collision.
@lazypower

This comment has been minimized.

Show comment
Hide comment
@lazypower

lazypower Apr 21, 2017

Member

@marcoceppi i took your suggestions wholesale and verified they work as intended. Ready for another pass on this one.

Member

lazypower commented Apr 21, 2017

@marcoceppi i took your suggestions wholesale and verified they work as intended. Ready for another pass on this one.

@lazypower

This comment has been minimized.

Show comment
Hide comment
@lazypower

lazypower Apr 21, 2017

Member

@k8s-bot gce etcd3 e2e test this

Member

lazypower commented Apr 21, 2017

@k8s-bot gce etcd3 e2e test this

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi
Member

marcoceppi commented Apr 21, 2017

/assign @marcoceppi

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi

marcoceppi Apr 21, 2017

Member

/lgtm

Member

marcoceppi commented Apr 21, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 21, 2017

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 21, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckbutler, marcoceppi

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

k8s-merge-robot commented Apr 21, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckbutler, marcoceppi

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 22, 2017

Contributor

Automatic merge from submit-queue (batch tested with PRs 42486, 44780)

Contributor

k8s-merge-robot commented Apr 22, 2017

Automatic merge from submit-queue (batch tested with PRs 42486, 44780)

@k8s-merge-robot k8s-merge-robot merged commit 12adc0e into kubernetes:master Apr 22, 2017

5 of 13 checks passed

Jenkins GCE e2e Jenkins job triggered.
Details
Jenkins GCE etcd3 e2e Jenkins job triggered.
Details
Jenkins GCI GCE e2e Jenkins job triggered.
Details
Jenkins kops AWS e2e Jenkins job triggered.
Details
Jenkins non-CRI GCE e2e Jenkins job triggered.
Details
Jenkins unit/integration Jenkins job triggered.
Details
Jenkins verification Jenkins job triggered.
Details
Submit Queue Required Github CI test is not green: Jenkins GCE e2e
Details
Jenkins Bazel Build Job succeeded.
Details
Jenkins GCE Node e2e Jenkins job succeeded.
Details
Jenkins Kubemark GCE e2e Jenkins job succeeded.
Details
Jenkins non-CRI GCE Node e2e Jenkins job succeeded.
Details
cla/linuxfoundation chuckbutler authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment