New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct option name in the kubernetes-worker layer registry action #44921

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
8 participants
@jacekn
Contributor

jacekn commented Apr 25, 2017

What this PR does / why we need it: It fixes #44920

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #44920

Special notes for your reviewer:

Release note:

Ensure kubernetes-worker juju layer registry action uses correct ingress controller option name
@k8s-reviewable

This comment has been minimized.

Show comment
Hide comment
@k8s-reviewable

k8s-reviewable Apr 25, 2017

This change is Reviewable

k8s-reviewable commented Apr 25, 2017

This change is Reviewable

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Apr 25, 2017

Contributor

Hi @jacekn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Apr 25, 2017

Hi @jacekn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Apr 25, 2017

Member

@k8s-bot ok to test

Member

cblecker commented Apr 25, 2017

@k8s-bot ok to test

@mikedanese mikedanese removed their assignment Apr 27, 2017

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi
Member

marcoceppi commented Apr 28, 2017

/assign @marcoceppi

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi

marcoceppi Apr 28, 2017

Member

/lgtm

Member

marcoceppi commented Apr 28, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 28, 2017

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 28, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacekn, marcoceppi

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

k8s-merge-robot commented Apr 28, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacekn, marcoceppi

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi

marcoceppi Apr 28, 2017

Member

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Member

marcoceppi commented Apr 28, 2017

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 28, 2017

Contributor

Automatic merge from submit-queue (batch tested with PRs 42432, 44628, 45101, 44921)

Contributor

k8s-merge-robot commented Apr 28, 2017

Automatic merge from submit-queue (batch tested with PRs 42432, 44628, 45101, 44921)

@k8s-merge-robot k8s-merge-robot merged commit bec2c60 into kubernetes:master Apr 28, 2017

10 checks passed

Jenkins Bazel Build Job succeeded.
Details
Jenkins GCE Node e2e Jenkins job succeeded.
Details
Jenkins GCE etcd3 e2e Jenkins job succeeded.
Details
Jenkins Kubemark GCE e2e Jenkins job succeeded.
Details
Jenkins kops AWS e2e Jenkins job succeeded.
Details
Jenkins unit/integration Jenkins job succeeded.
Details
Jenkins verification Jenkins job succeeded.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation jacekn authorized
Details
code-review/reviewable 1 file reviewed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment