New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump runc to d223e2a #44940

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
8 participants
@sjenning
Copy link
Contributor

sjenning commented Apr 26, 2017

Fixes #43856

@derekwaynecarr

@k8s-reviewable

This comment has been minimized.

Copy link

k8s-reviewable commented Apr 26, 2017

This change is Reviewable

@k8s-cherrypick-bot

This comment has been minimized.

Copy link

k8s-cherrypick-bot commented Apr 26, 2017

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-cherrypick-bot

This comment has been minimized.

Copy link

k8s-cherrypick-bot commented Apr 26, 2017

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Apr 26, 2017

@sjenning -- is it worth evaluating taking an older level of runc closer to level that merged opencontainers/runc#1124 ? Do you know if the code at that time had the awkward -1 convention?

@sjenning

This comment has been minimized.

Copy link
Contributor

sjenning commented Apr 26, 2017

@derekwaynecarr what is the minimal version that contains your fix?

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Apr 26, 2017

we would need to take the git commit d223e2adae83f62d58448a799a5da05730228089

@sjenning

This comment has been minimized.

Copy link
Contributor

sjenning commented Apr 26, 2017

yeah, the first tagged release in which that commit is included is v1.0.0-rc3. i.e. v1.0.0-rc2 would have it. unless we want to go off the reservation and do a untagged dep by commit rather than version.

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Apr 26, 2017

didn't we have an untagged commit previously?

@sjenning sjenning force-pushed the sjenning:bump-runc branch from f9e6479 to fda2c9f Apr 26, 2017

@sjenning sjenning changed the title Bump runc to v1.0.0-rc3 Bump runc to d223e2a Apr 26, 2017

@k8s-merge-robot k8s-merge-robot added size/L and removed size/XXL labels Apr 26, 2017

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Apr 26, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 26, 2017

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Apr 26, 2017

@dchen1107 @smarterclayton -- can either of you approve this? its the smallest bump we can make. the changes in runc are localized to selinux updates that appear reasonable, a bunch of comment changes, and the fix for systemd cgroup apply semantics to ignore already exists errors.

@k8s-cherrypick-bot

This comment has been minimized.

Copy link

k8s-cherrypick-bot commented Apr 26, 2017

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Apr 27, 2017

/approve

@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Apr 27, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Apr 27, 2017

Automatic merge from submit-queue

@k8s-merge-robot k8s-merge-robot merged commit a92007b into kubernetes:master Apr 27, 2017

9 of 10 checks passed

Submit Queue Required Github CI test is not green: Jenkins verification
Details
Jenkins Bazel Build Job succeeded.
Details
Jenkins GCE Node e2e Jenkins job succeeded.
Details
Jenkins GCE etcd3 e2e Jenkins job succeeded.
Details
Jenkins Kubemark GCE e2e Jenkins job succeeded.
Details
Jenkins kops AWS e2e Jenkins job succeeded.
Details
Jenkins unit/integration Jenkins job succeeded.
Details
Jenkins verification Jenkins job succeeded.
Details
cla/linuxfoundation sjenning authorized
Details
pull-kubernetes-cross Jenkins job succeeded.
Details

@sjenning sjenning referenced this pull request Jun 27, 2017

Merged

bump runc to d223e2a #48117

k8s-merge-robot added a commit that referenced this pull request Jun 27, 2017

Merge pull request #48117 from sjenning/bump-runc-1.6
Automatic merge from submit-queue

bump runc to d223e2a

cherry-pick #44940

by user request #43856 (comment)

@derekwaynecarr @djsly @vishh 

```release-note
Bump runc to v1.0.0-rc2-49-gd223e2a - fixes `failed to initialise top level QOS containers` kubelet error.
```

@sjenning sjenning deleted the sjenning:bump-runc branch Aug 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment