New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump runc to d223e2a #44940
Bump runc to d223e2a #44940
Conversation
Removing label |
Removing label |
@sjenning -- is it worth evaluating taking an older level of runc closer to level that merged opencontainers/runc#1124 ? Do you know if the code at that time had the awkward -1 convention? |
@derekwaynecarr what is the minimal version that contains your fix? |
we would need to take the git commit d223e2adae83f62d58448a799a5da05730228089 |
yeah, the first tagged release in which that commit is included is v1.0.0-rc3. i.e. v1.0.0-rc2 would have it. unless we want to go off the reservation and do a untagged dep by commit rather than version. |
didn't we have an untagged commit previously? |
/lgtm |
@dchen1107 @smarterclayton -- can either of you approve this? its the smallest bump we can make. the changes in runc are localized to selinux updates that appear reasonable, a bunch of comment changes, and the fix for systemd cgroup apply semantics to ignore already exists errors. |
Removing label |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, sjenning, smarterclayton
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
Automatic merge from submit-queue bump runc to d223e2a cherry-pick #44940 by user request #43856 (comment) @derekwaynecarr @djsly @vishh ```release-note Bump runc to v1.0.0-rc2-49-gd223e2a - fixes `failed to initialise top level QOS containers` kubelet error. ```
Fixes #43856
@derekwaynecarr