New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send dns details only after cdk-addons are configured #44945

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Projects
None yet
8 participants
@ktsakalozos
Collaborator

ktsakalozos commented Apr 26, 2017

What this PR does / why we need it: This is a bugfix on the deployment of Kubernetes via Juju. See issue below.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #40386 and
juju-solutions/bundle-canonical-kubernetes#262

Special notes for your reviewer:

Release note:

Fix KubeDNS issue in Juju deployments. 
@k8s-reviewable

This comment has been minimized.

Show comment
Hide comment
@k8s-reviewable

k8s-reviewable Apr 26, 2017

This change is Reviewable

k8s-reviewable commented Apr 26, 2017

This change is Reviewable

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Apr 26, 2017

Contributor

Hi @ktsakalozos. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Apr 26, 2017

Hi @ktsakalozos. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi

marcoceppi Apr 26, 2017

Member

@k8s-bot ok to test

Member

marcoceppi commented Apr 26, 2017

@k8s-bot ok to test

@marcoceppi

This comment has been minimized.

Show comment
Hide comment
@marcoceppi

marcoceppi Apr 26, 2017

Member

/approve

Member

marcoceppi commented Apr 26, 2017

/approve

@@ -297,6 +297,7 @@ def start_master(etcd):
@when('kube-control.connected')
@when('cdk-addons.configured')

This comment has been minimized.

@Cynerva

Cynerva Apr 26, 2017

Contributor

If I understand right, this will prevent kubernetes-worker from deploying ingress and default-http-backend prematurely. I'm +1 to this 👍

@Cynerva

Cynerva Apr 26, 2017

Contributor

If I understand right, this will prevent kubernetes-worker from deploying ingress and default-http-backend prematurely. I'm +1 to this 👍

@lazypower

This comment has been minimized.

Show comment
Hide comment
@lazypower

lazypower Apr 26, 2017

Member

/assign @chuckbutler

always an owner, never a reviewer :(

Member

lazypower commented Apr 26, 2017

/assign @chuckbutler

always an owner, never a reviewer :(

@lazypower

This comment has been minimized.

Show comment
Hide comment
@lazypower

lazypower Apr 26, 2017

Member

/lgtm

Member

lazypower commented Apr 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 26, 2017

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 26, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckbutler, ktsakalozos, marcoceppi

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

k8s-merge-robot commented Apr 26, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckbutler, ktsakalozos, marcoceppi

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 26, 2017

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented Apr 26, 2017

Automatic merge from submit-queue

@k8s-merge-robot k8s-merge-robot merged commit b5caa6b into kubernetes:master Apr 26, 2017

8 of 9 checks passed

Submit Queue Required Github CI test is not green: Jenkins GCE etcd3 e2e
Details
Jenkins Bazel Build Job succeeded.
Details
Jenkins GCE Node e2e Jenkins job succeeded.
Details
Jenkins GCE etcd3 e2e Jenkins job succeeded.
Details
Jenkins Kubemark GCE e2e Jenkins job succeeded.
Details
Jenkins kops AWS e2e Jenkins job succeeded.
Details
Jenkins unit/integration Jenkins job succeeded.
Details
Jenkins verification Jenkins job succeeded.
Details
cla/linuxfoundation ktsakalozos authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment