Join GitHub today
Adding option to set the federation api server port if nodeport is set #46283
What this PR does / why we need it: Kubefed will deploy the respected services and then it will do a health check. Prior to this patch if the user selects the nodeport a random port is opened. In environments where firewalls are in place this random port selection will cause the health check to fail. With this patch we enable users to designate a specific port, after for example opening it on their firewall.
Which issue this PR fixes (optional, in
Special notes for your reviewer:
Hi @ktsakalozos. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
[APPROVALNOTIFIER] This PR is APPROVED
Associated issue: 46021
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing