New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fluentd-elasticsearch addon to Elasticsearch/Kibana 5.5 #48722

Merged
merged 1 commit into from Aug 3, 2017

Conversation

@aknuds1
Contributor

aknuds1 commented Jul 10, 2017

This is a patch to upgrade the fluentd-elasticsearch addon to Elasticsearch/Kibana 5.5. Please provide feedback!

* Upgrade Elasticsearch/Kibana to 5.5.1 in fluentd-elasticsearch addon
* Switch to basing our image of Elasticsearch in fluentd-elasticsearch addon off the official one
* Switch to the official image of Kibana in fluentd-elasticsearch addon
* Use StatefulSet for Elasticsearch instead of ReplicationController, with persistent volume claims
* Require authenticating towards Elasticsearch, as Elasticsearch 5.5 by default requires basic authentication
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Jul 10, 2017

Contributor

Hi @aknuds1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Jul 10, 2017

Hi @aknuds1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@coffeepac

This comment has been minimized.

Show comment
Hide comment
@coffeepac

coffeepac Jul 11, 2017

Member

@Aknuds thanks for the PR! Do you want any feedback on this now? There are a few things that will prevent me from kicking off tests.

Member

coffeepac commented Jul 11, 2017

@Aknuds thanks for the PR! Do you want any feedback on this now? There are a few things that will prevent me from kicking off tests.

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Jul 11, 2017

Contributor

@coffeepac I would love any feedback at this point! I'm really especially interested in hearing about my approach when it comes to the Elasticsearch Dockerfile. I've justed based it off the original one, instead of writing it from scratch, as was done in the original.

I'm also interested in hearing about how installation of Elasticsearch plugins should be made configurable, instead of hardwiring repository-s3 like I've done.

Note also please that I include a binary of elasticsearch_logging_discovery instead of the corresponding source code, as I could not successfully build this neither on OS X nor Linux.

Contributor

aknuds1 commented Jul 11, 2017

@coffeepac I would love any feedback at this point! I'm really especially interested in hearing about my approach when it comes to the Elasticsearch Dockerfile. I've justed based it off the original one, instead of writing it from scratch, as was done in the original.

I'm also interested in hearing about how installation of Elasticsearch plugins should be made configurable, instead of hardwiring repository-s3 like I've done.

Note also please that I include a binary of elasticsearch_logging_discovery instead of the corresponding source code, as I could not successfully build this neither on OS X nor Linux.

@crassirostris crassirostris removed their assignment Jul 11, 2017

@coffeepac

This comment has been minimized.

Show comment
Hide comment
@coffeepac

coffeepac Jul 13, 2017

Member

I don't have any ideas for how to provide a list of plugins to be installed at install time. @crassirostris do you have any thoughts on that? its something I've been considering but I don't know if this is something that there is already a pattern for elsewhere in kubernetes.

Member

coffeepac commented Jul 13, 2017

I don't have any ideas for how to provide a list of plugins to be installed at install time. @crassirostris do you have any thoughts on that? its something I've been considering but I don't know if this is something that there is already a pattern for elsewhere in kubernetes.

@coffeepac

This comment has been minimized.

Show comment
Hide comment
@coffeepac

coffeepac Jul 13, 2017

Member

/ok-to-test

Member

coffeepac commented Jul 13, 2017

/ok-to-test

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Jul 14, 2017

Contributor

@coffeepac I will give the PR another look today, I have some things in mind that I could do in order to solve the remaining problems.

Contributor

aknuds1 commented Jul 14, 2017

@coffeepac I will give the PR another look today, I have some things in mind that I could do in order to solve the remaining problems.

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Jul 14, 2017

Contributor

I tested the PR now and I'm encountering a bug on the startup of the pod. Really not sure what's causing this as I've not encountered it in prior testing :( Gonna have to try some more tomorrow.

[2017-07-14T21:11:06,097][INFO ][o.e.n.Node               ] [elasticsearch-logging-v1-0] initializing ...
[2017-07-14T21:11:06,174][WARN ][o.e.b.ElasticsearchUncaughtExceptionHandler] [elasticsearch-logging-v1-0] uncaught exception in thread [main]
org.elasticsearch.bootstrap.StartupException: java.lang.IllegalStateException: Failed to create node environment
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:127) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:114) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:67) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:122) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.cli.Command.main(Command.java:88) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:91) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:84) ~[elasticsearch-5.5.0.jar:5.5.0]
Caused by: java.lang.IllegalStateException: Failed to create node environment
	at org.elasticsearch.node.Node.<init>(Node.java:267) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.node.Node.<init>(Node.java:244) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:232) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:232) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:351) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:123) ~[elasticsearch-5.5.0.jar:5.5.0]
	... 6 more
Caused by: java.nio.file.AccessDeniedException: /data/nodes
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:84) ~[?:?]
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) ~[?:?]
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) ~[?:?]
	at sun.nio.fs.UnixFileSystemProvider.createDirectory(UnixFileSystemProvider.java:384) ~[?:?]
	at java.nio.file.Files.createDirectory(Files.java:674) ~[?:1.8.0_131]
	at java.nio.file.Files.createAndCheckIsDirectory(Files.java:781) ~[?:1.8.0_131]
	at java.nio.file.Files.createDirectories(Files.java:767) ~[?:1.8.0_131]
	at org.elasticsearch.env.NodeEnvironment.<init>(NodeEnvironment.java:221) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.node.Node.<init>(Node.java:264) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.node.Node.<init>(Node.java:244) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:232) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:232) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:351) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:123) ~[elasticsearch-5.5.0.jar:5.5.0]
	... 6 more
Contributor

aknuds1 commented Jul 14, 2017

I tested the PR now and I'm encountering a bug on the startup of the pod. Really not sure what's causing this as I've not encountered it in prior testing :( Gonna have to try some more tomorrow.

[2017-07-14T21:11:06,097][INFO ][o.e.n.Node               ] [elasticsearch-logging-v1-0] initializing ...
[2017-07-14T21:11:06,174][WARN ][o.e.b.ElasticsearchUncaughtExceptionHandler] [elasticsearch-logging-v1-0] uncaught exception in thread [main]
org.elasticsearch.bootstrap.StartupException: java.lang.IllegalStateException: Failed to create node environment
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:127) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:114) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:67) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:122) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.cli.Command.main(Command.java:88) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:91) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:84) ~[elasticsearch-5.5.0.jar:5.5.0]
Caused by: java.lang.IllegalStateException: Failed to create node environment
	at org.elasticsearch.node.Node.<init>(Node.java:267) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.node.Node.<init>(Node.java:244) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:232) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:232) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:351) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:123) ~[elasticsearch-5.5.0.jar:5.5.0]
	... 6 more
Caused by: java.nio.file.AccessDeniedException: /data/nodes
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:84) ~[?:?]
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) ~[?:?]
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) ~[?:?]
	at sun.nio.fs.UnixFileSystemProvider.createDirectory(UnixFileSystemProvider.java:384) ~[?:?]
	at java.nio.file.Files.createDirectory(Files.java:674) ~[?:1.8.0_131]
	at java.nio.file.Files.createAndCheckIsDirectory(Files.java:781) ~[?:1.8.0_131]
	at java.nio.file.Files.createDirectories(Files.java:767) ~[?:1.8.0_131]
	at org.elasticsearch.env.NodeEnvironment.<init>(NodeEnvironment.java:221) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.node.Node.<init>(Node.java:264) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.node.Node.<init>(Node.java:244) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:232) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:232) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:351) ~[elasticsearch-5.5.0.jar:5.5.0]
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:123) ~[elasticsearch-5.5.0.jar:5.5.0]
	... 6 more
@coffeepac

This comment has been minimized.

Show comment
Hide comment
@coffeepac

coffeepac Jul 14, 2017

Member

@aknuds1 looks like the /data mount point is being created with permissions that the elasticsearch user can't use. maybe try removing the GOSU pieces for now and let ES run as root.

Member

coffeepac commented Jul 14, 2017

@aknuds1 looks like the /data mount point is being created with permissions that the elasticsearch user can't use. maybe try removing the GOSU pieces for now and let ES run as root.

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Jul 15, 2017

Contributor

@coffeepac I made a mistake when I tested last night, it actually works :)

I've tested the whole stack now - I can see log messages in Kibana, so I think we can work towards merging it now! :)

Contributor

aknuds1 commented Jul 15, 2017

@coffeepac I made a mistake when I tested last night, it actually works :)

I've tested the whole stack now - I can see log messages in Kibana, so I think we can work towards merging it now! :)

@aknuds1 aknuds1 changed the title from [WIP]Upgrade fluentd-elasticsearch addon to Elasticearch 5.5 to Upgrade fluentd-elasticsearch addon to Elasticearch 5.5 Jul 15, 2017

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Jul 16, 2017

Contributor

@coffeepac Do you know how to fix whatever's causing the tests to break?

Contributor

aknuds1 commented Jul 16, 2017

@coffeepac Do you know how to fix whatever's causing the tests to break?

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Jul 16, 2017

Member

@aknuds1 You somehow broke the licence boilerplate in cluster/addons/fluentd-elasticsearch/es-image/run.sh and cluster/addons/fluentd-elasticsearch/es-image/Dockerfile. Run hack/verify-boilerplate.sh from the K8s root directory to get that error. I guess there should be a newline between licence and the content.

Member

crassirostris commented Jul 16, 2017

@aknuds1 You somehow broke the licence boilerplate in cluster/addons/fluentd-elasticsearch/es-image/run.sh and cluster/addons/fluentd-elasticsearch/es-image/Dockerfile. Run hack/verify-boilerplate.sh from the K8s root directory to get that error. I guess there should be a newline between licence and the content.

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Jul 16, 2017

Member

@aknuds1 I have several comments:

  • You don't need -1 in the end of the image tag in the Makefile, it was added to have two images with the same version of ES and different base images (for fixing CVEs)
  • Don't run it as root in the end
  • Do you really need to install gosu from Github? Maybe you can roll without it somehow?
  • You removed the Kibana image and KIBANA_BASE_URL parameter. Have you verified that Kibana works through proxy?
Member

crassirostris commented Jul 16, 2017

@aknuds1 I have several comments:

  • You don't need -1 in the end of the image tag in the Makefile, it was added to have two images with the same version of ES and different base images (for fixing CVEs)
  • Don't run it as root in the end
  • Do you really need to install gosu from Github? Maybe you can roll without it somehow?
  • You removed the Kibana image and KIBANA_BASE_URL parameter. Have you verified that Kibana works through proxy?
@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Jul 16, 2017

Contributor

@crassirostris Thanks for the comments!

  • I removed the -1 part
  • I removed the need for gosu by running as elasticsearch in the end
  • I removed the Kibana image as from what I can tell we can use the official one. I haven't yet tested with proxy
Contributor

aknuds1 commented Jul 16, 2017

@crassirostris Thanks for the comments!

  • I removed the -1 part
  • I removed the need for gosu by running as elasticsearch in the end
  • I removed the Kibana image as from what I can tell we can use the official one. I haven't yet tested with proxy
@@ -16,7 +16,7 @@
# The current value of the tag to be used for building and
# pushing an image to gcr.io
TAG = v5.4.0-1
TAG = v5.5.1

This comment has been minimized.

@fhemberger

fhemberger Aug 2, 2017

@aknuds1 How about using the PREFIX, NAME, TAG notation as in cluster/addons/fluentd-elasticsearch/kibana-image/Makefile for consistency?

@fhemberger

fhemberger Aug 2, 2017

@aknuds1 How about using the PREFIX, NAME, TAG notation as in cluster/addons/fluentd-elasticsearch/kibana-image/Makefile for consistency?

This comment has been minimized.

@crassirostris

crassirostris Aug 2, 2017

Member

I suggest merging this PR as it is right now, because it blocks some e2e tests and making a refactoring in a separate PR

@crassirostris

crassirostris Aug 2, 2017

Member

I suggest merging this PR as it is right now, because it blocks some e2e tests and making a refactoring in a separate PR

This comment has been minimized.

@fhemberger

fhemberger Aug 2, 2017

Fine for me, just discovered it as I'm eagerly waiting for this to land and I started looking into the Makefile. 😁

@fhemberger

fhemberger Aug 2, 2017

Fine for me, just discovered it as I'm eagerly waiting for this to land and I started looking into the Makefile. 😁

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Aug 2, 2017

Contributor

@crassirostris Both nits handled. Please review my release notes as I added a couple.

Contributor

aknuds1 commented Aug 2, 2017

@crassirostris Both nits handled. Please review my release notes as I added a couple.

@aknuds1 aknuds1 changed the title from Upgrade fluentd-elasticsearch addon to Elasticearch 5.5 to Upgrade fluentd-elasticsearch addon to Elasticsearch/Kibana 5.5 Aug 2, 2017

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Aug 2, 2017

Member

/lgtm

Thanks a lot for doing the work! One nit towards the release notes:

Require authenticating towards Elasticsearch, as is the default

I don't understand what it means :) Last part at least, "as is the default". Could you please rephrase it?

Member

crassirostris commented Aug 2, 2017

/lgtm

Thanks a lot for doing the work! One nit towards the release notes:

Require authenticating towards Elasticsearch, as is the default

I don't understand what it means :) Last part at least, "as is the default". Could you please rephrase it?

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Aug 2, 2017

Member

/approve no-issue

Member

crassirostris commented Aug 2, 2017

/approve no-issue

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 2, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aknuds1, crassirostris

Associated issue requirement bypassed by: crassirostris

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

k8s-merge-robot commented Aug 2, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aknuds1, crassirostris

Associated issue requirement bypassed by: crassirostris

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Aug 2, 2017

Contributor

@crassirostris I revised my release notes, trying to make it more clear what I mean about requiring Elasticsearch authentication.

Contributor

aknuds1 commented Aug 2, 2017

@crassirostris I revised my release notes, trying to make it more clear what I mean about requiring Elasticsearch authentication.

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Aug 2, 2017

Member

@aknuds1 SGTM, thanks again! Sorry in advance for those test flakes =__=

Member

crassirostris commented Aug 2, 2017

@aknuds1 SGTM, thanks again! Sorry in advance for those test flakes =__=

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Aug 2, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

fejta-bot commented Aug 2, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Aug 3, 2017

Contributor

Automatic merge from submit-queue (batch tested with PRs 48365, 49902, 49808, 48722, 47045)

Contributor

k8s-merge-robot commented Aug 3, 2017

Automatic merge from submit-queue (batch tested with PRs 48365, 49902, 49808, 48722, 47045)

@k8s-merge-robot k8s-merge-robot merged commit ae0ca36 into kubernetes:master Aug 3, 2017

11 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation aknuds1 authorized
Details
pull-kubernetes-bazel Job succeeded.
Details
pull-kubernetes-cross Jenkins job succeeded.
Details
pull-kubernetes-e2e-gce-etcd3 Jenkins job succeeded.
Details
pull-kubernetes-e2e-kops-aws Jenkins job succeeded.
Details
pull-kubernetes-federation-e2e-gce Jenkins job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Jenkins job succeeded.
Details
pull-kubernetes-node-e2e Jenkins job succeeded.
Details
pull-kubernetes-unit Jenkins job succeeded.
Details
pull-kubernetes-verify Jenkins job succeeded.
Details
@sebglon

This comment has been minimized.

Show comment
Hide comment
@sebglon

sebglon Aug 3, 2017

Image are not pushed on not granted for public?
Failed to pull image "gcr.io/google_containers/fluentd-elasticsearch:1.24": rpc error: code = 2 desc = Error: Status 405 trying to pull repository google_containers/fluentd-elasticsearch: "v1 Registry API is disabled. If you are not explicitly using the v1 Registry API, it is possible your v2 image could not be found. Verify that your image is available, or retry withdockerd --disable-legacy-registry. See https://cloud.google.com/container-registry/docs/support/deprecation-notices"

sebglon commented Aug 3, 2017

Image are not pushed on not granted for public?
Failed to pull image "gcr.io/google_containers/fluentd-elasticsearch:1.24": rpc error: code = 2 desc = Error: Status 405 trying to pull repository google_containers/fluentd-elasticsearch: "v1 Registry API is disabled. If you are not explicitly using the v1 Registry API, it is possible your v2 image could not be found. Verify that your image is available, or retry withdockerd --disable-legacy-registry. See https://cloud.google.com/container-registry/docs/support/deprecation-notices"

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Aug 3, 2017

Member

@sebglon Was not pushed, sorry, Just fixed it

Member

crassirostris commented Aug 3, 2017

@sebglon Was not pushed, sorry, Just fixed it

@aknuds1 aknuds1 deleted the aknuds1:upgrade-fluentd-elasticsearch branch Aug 3, 2017

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Aug 3, 2017

Contributor

Thanks very much @crassirostris @coffeepac for helping out and getting this merged!

Contributor

aknuds1 commented Aug 3, 2017

Thanks very much @crassirostris @coffeepac for helping out and getting this merged!

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Aug 3, 2017

Member

I'm rolling back the PD, because it's leaking resources in the e2e tests

Member

crassirostris commented Aug 3, 2017

I'm rolling back the PD, because it's leaking resources in the e2e tests

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Aug 3, 2017

Contributor

@crassirostris What do you mean by PD? Is there any particular issue causing resource leaks?

Contributor

aknuds1 commented Aug 3, 2017

@crassirostris What do you mean by PD? Is there any particular issue causing resource leaks?

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Aug 3, 2017

Member

@aknuds1 "Persistent disk", sorry, GCP terminology :) I mean PVC in the elasticsearch-logging

Member

crassirostris commented Aug 3, 2017

@aknuds1 "Persistent disk", sorry, GCP terminology :) I mean PVC in the elasticsearch-logging

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Aug 3, 2017

Contributor

@crassirostris What's the solution then? Not having persistentVolumeClaimTemplate in the Elasticsearch StatefulSet (because of test issues)?

Contributor

aknuds1 commented Aug 3, 2017

@crassirostris What's the solution then? Not having persistentVolumeClaimTemplate in the Elasticsearch StatefulSet (because of test issues)?

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Aug 3, 2017

Member

@aknuds1 Yup, and document it better. Ideally, I'm thinking about splitting fluentd to a separate repo and having test yamls in this repo and an example with PVC in another

Member

crassirostris commented Aug 3, 2017

@aknuds1 Yup, and document it better. Ideally, I'm thinking about splitting fluentd to a separate repo and having test yamls in this repo and an example with PVC in another

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Aug 3, 2017

Contributor

@crassirostris So the idea is to let the user define persistentVolumeClaimTemplate instead? You know best in any case.

Contributor

aknuds1 commented Aug 3, 2017

@crassirostris So the idea is to let the user define persistentVolumeClaimTemplate instead? You know best in any case.

@crassirostris

This comment has been minimized.

Show comment
Hide comment
@crassirostris

crassirostris Aug 3, 2017

Member

@aknuds1 The idea is to replace persistentVolumeClaimTemplate with emptyDir volume in this repo and add a note to the readme, stating that when adapting this example for your own need, you have to replace it with a PVC. Sounds good?

Member

crassirostris commented Aug 3, 2017

@aknuds1 The idea is to replace persistentVolumeClaimTemplate with emptyDir volume in this repo and add a note to the readme, stating that when adapting this example for your own need, you have to replace it with a PVC. Sounds good?

@aknuds1

This comment has been minimized.

Show comment
Hide comment
@aknuds1

aknuds1 Aug 3, 2017

Contributor

@crassirostris That's what I thought you would do. Sounds like the best solution everything taken into consideration!

Contributor

aknuds1 commented Aug 3, 2017

@crassirostris That's what I thought you would do. Sounds like the best solution everything taken into consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment