Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kernel config locations for fedora and atomic #49410

Merged
merged 1 commit into from Jun 26, 2018

Conversation

@jasonbrooks
Copy link
Contributor

commented Jul 21, 2017

What this PR does / why we need it:

  • Fedora stores its kernel configs in /usr/lib/modules/$(uname -r)/config
  • Fedora/CentOS/RHEL atomic hosts use /usr/lib/ostree-boot/$(uname -r), though this location is deprecated
  • The lack of these locations in the validator is causing kubeadm to hang on "failed to parse kernel config" in its preflight checking on fedora and atomic host

Special notes for your reviewer:

Release note:

add kernel config locations for fedora and atomic
* Fedora stores its kernel configs in /usr/lib/modules/$(uname -r)
* Fedora/CentOS/RHEL atomic hosts use /usr/lib/ostree-boot, though this location is deprecated
* The lack of these locations in the validator is causing kubeadm to hang on "failed to parse kernel config" in its preflight checking on fedora and atomic host
@xiangpengzhao

This comment has been minimized.

Copy link
Member

commented Aug 17, 2017

/release-note-none
/ok-to-test

@luxas

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

cc @kubernetes/sig-node-pr-reviews PTAL
Sorry @jasonbrooks noticed this one first now.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2017

This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review.

cc @dchen1107 @jasonbrooks @vishh

You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days

@sjenning

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2018

/reopen
/assign
/assign @ConnorDoyle
/ok-to-test

Connor could I get approval on this one? kubeadm uses this function (yes, imported from the e2e tests :-/) and it doesn't account for the config location on Fedora and Atomic.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2018

@sjenning: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

/reopen
/assign
/assign @ConnorDoyle
/ok-to-test

Connor could I get approval on this one? kubeadm uses this function (yes, imported from the e2e tests :-/) and it doesn't account for the config location on Fedora and Atomic.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2018

Ordering operations for the bot...
/reopen

@k8s-ci-robot k8s-ci-robot reopened this Feb 15, 2018

@kubernetes kubernetes deleted a comment from k8s-github-robot Feb 15, 2018

@dustymabe

This comment has been minimized.

Copy link

commented Apr 13, 2018

is this still needed?

@jasonbrooks

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2018

For Fedora Atomic, it is.

[ERROR SystemVerification]: failed to parse kernel config: unable to load kernel module "configs": output - "modprobe: FATAL: Module configs not found in directory /lib/modules/4.16.0-0.rc4.git0.1.fc28.x86_64\n", err - exit status 1
@sjenning

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2018

/assign @derekwaynecarr

@derekwaynecarr

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

/approve

@dustymabe

This comment has been minimized.

Copy link

commented Apr 24, 2018

is this still needed?

@dims

This comment has been minimized.

Copy link
Member

commented May 4, 2018

/test all

@ConnorDoyle

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

/test all

@sjenning

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

@jasonbrooks is this still needed. It has approval and just need lgtm, which I can give if we still need this.

@jasonbrooks

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2018

@sjenning Yes, please.

@sjenning

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 26, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, jasonbrooks, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@calebamiles

This comment has been minimized.

Copy link
Member

commented Jun 26, 2018

@derekwaynecarr, @ConnorDoyle, @sjenning, @jasonbrooks is this something that you plan on cherry picking into the 1.11.x tree? (said in the voice of a silverblue user)

cc: @jberkus

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

Automatic merge from submit-queue (batch tested with PRs 65449, 65373, 49410). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 76b4699 into kubernetes:master Jun 26, 2018

22 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation jasonbrooks authorized
Details
pull-kubernetes-bazel Job succeeded.
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-etcd3 Jenkins job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-federation-e2e-gce Jenkins job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-unit Context retired. Status moved to "pull-kubernetes-integration".
pull-kubernetes-verify Job succeeded.
Details
@sjenning

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

@calebamiles this only pertains to getting the e2e-node test suite to pass. It is fixing a test, not kube.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.