New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the typo of wtih #50286

Merged
merged 1 commit into from Jan 15, 2018

Conversation

Projects
None yet
8 participants
@Pingan2017
Contributor

Pingan2017 commented Aug 8, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Aug 8, 2017

Hi @Pingan2017. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims

This comment has been minimized.

Member

dims commented Aug 9, 2017

/ok-to-test

@Pingan2017

This comment has been minimized.

Contributor

Pingan2017 commented Sep 19, 2017

@deads2k

This comment has been minimized.

Contributor

deads2k commented Sep 19, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 19, 2017

@Pingan2017

This comment has been minimized.

Contributor

Pingan2017 commented Sep 20, 2017

cc @vishh for approval,Thank you

@vishh

This comment has been minimized.

Member

vishh commented Nov 9, 2017

/approve
/lgtm

@Pingan2017

This comment has been minimized.

Contributor

Pingan2017 commented Nov 10, 2017

/approve no-issue
@vishh

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Dec 10, 2017

This PR hasn't been active in 30 days. It will be closed in 59 days (Feb 8, 2018).

cc @Pingan2017 @deads2k @vishh

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Pingan2017, vishh

Associated issue requirement bypassed by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Member

cblecker commented Jan 15, 2018

/test pull-kubernetes-bazel-build
/test pull-kubernetes-bazel-test
/test pull-kubernetes-cross
/test pull-kubernetes-e2e-gce

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 15, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 7e743a1 into kubernetes:master Jan 15, 2018

14 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation Pingan2017 authorized
Details
pull-kubernetes-bazel Job succeeded.
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-etcd3 Jenkins job succeeded.
Details
pull-kubernetes-e2e-kops-aws Jenkins job succeeded.
Details
pull-kubernetes-federation-e2e-gce Jenkins job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Jenkins job succeeded.
Details
pull-kubernetes-node-e2e Jenkins job succeeded.
Details
pull-kubernetes-unit Jenkins job succeeded.
Details
pull-kubernetes-verify Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment