New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor mount utility code out gce_pd volume plugin #5036
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
@@ -47,7 +47,8 @@ var _ = Describe("PD", func() { | |||
|
|||
nodes, err := c.Nodes().List() | |||
expectNoError(err, "Failed to list nodes for e2e cluster.") | |||
Expect(len(nodes.Items) >= 2) | |||
fmt.Printf("Nodes: %v", len(nodes.Items)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug statement?
@thockin I'm ready for review on this once you have some bandwidth. |
@@ -49,3 +49,30 @@ type MountPoint struct { | |||
Freq int | |||
Pass int | |||
} | |||
|
|||
// Examines /proc/mounts to find all other references to the device referenced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just create a mount_util.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rootfs things are in the files they are to ensure that the build flags for
each function / type didn't change across this commit.
On Wed, Mar 4, 2015 at 7:58 PM Huamin Chen notifications@github.com wrote:
In pkg/util/mount/mount.go
#5036 (comment)
:@@ -49,3 +49,30 @@ type MountPoint struct {
Freq int
Pass int
}
+
+// Examines /proc/mounts to find all other references to the device referencedwhy not just create a mount_util.go?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/5036/files#r25830927
.
One comment, otherwise LGTM |
@smarterclayton nit fixed, I had missed that when I copied the header in. |
Factor mount utility code out gce_pd volume plugin
|
||
// FakeMounter implements mount.Interface. | ||
type FakeMounter struct { | ||
mountPoints []MountPoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is one supposed to set the fake mount points if it is a private field?
just a couple nits - sorry for late review, send me a followup PR and I'll fast-track it. |
Currently the gce_pd volume plugin contains a significant amount of utility code that should be consolidated under
pkg/util/mount
.@thockin @markturansky