Refactor node taint conditions #51266

resouer · 2017-08-24T12:02:47Z

What this PR does / why we need it:
We should use not-ready etc as node condition taint key.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
fixes #51246

Special notes for your reviewer:

Release note:

Use `not-ready` to replace `notReady` in node condition taint keys.

resouer · 2017-08-24T12:04:19Z

I would prefer @k82cn to review this.

resouer · 2017-08-24T12:15:22Z

/assign @lavalamp

k82cn · 2017-08-24T13:00:51Z

/lgtm

I think we need to update doc accordingly, both design doc and guidance.

resouer · 2017-08-24T13:02:56Z

Right, I will try a global search and fix across the org.

luxas · 2017-08-24T13:56:55Z

Thanks @resouer for this PR!
cc @thockin ^

resouer · 2017-08-24T14:16:39Z

@luxas One concern is how we can avoid affecting existing user labels?

xiangpengzhao · 2017-08-25T01:52:40Z

I think we should consider backward compatibility. This change might break some user applications (or PaaS project based on Kubernetes).

resouer · 2017-08-25T02:27:21Z

The affected users in my mind:

Admins tainted their node with these keys manually. notReady taint may be the most common case here.
Systems read these taints to learn about the node information, this may happen to users who build there own system based on k8s, which are tend to be hard coded.

Some ideas in my mind:

We need to announce this change in kubernetes-users & kubernetes-dev mailing list at least.
Need a release note
Any other ideas?

cc @davidopp

k82cn · 2017-08-25T09:43:28Z

@resouer , I think we need to send an announcement to dev@ and user@ list. If the new name is right, it's a good time to correct it in alpha :).

lavalamp · 2017-08-31T04:17:54Z

Are these currently in use? This seems very unlikely to be backwards compatible.

resouer · 2017-08-31T05:48:17Z

@lavalamp In most cases they are internal used, but I think there can be some external use cases (though not best practice), see: #51266 (comment)

The most common case will be not-ready, but it is in alpha stage, that's why we agree it's a good time to fix it. Make sense?

resouer · 2017-09-05T07:22:17Z

kindly ping @lavalamp back to this thread 💯

k82cn · 2017-09-07T03:34:49Z

ping for approve :).

jaypipes

Looks like a well-tested, backwards-compatible change to me.

resouer · 2017-09-29T00:52:14Z

Thanks @jaypipes

@liggitt Feel free to do a new round of review whenever you have time.

luxas · 2017-09-29T22:05:42Z

Yay, let's get this into v1.9 ASAP

gmarek · 2017-10-03T09:45:50Z

pkg/controller/node/node_controller.go

@@ -404,6 +404,17 @@ func NewNodeController(
 		})
 	}

+	// NOTE(resouer): nodeInformer to substitute deprecated taint key (notReady -> not-ready).


s/NOTE/TODO/

gmarek · 2017-10-03T09:50:43Z

LGTM. Ping @liggitt for final lgtm.

liggitt · 2017-10-03T16:37:59Z

/lgtm

needs release-note-action-required with a description of the full non-alpha taint name so people can update their tolerations prior to upgrade to avoid disruption

gmarek · 2017-10-04T11:34:25Z

/approve

k8s-github-robot · 2017-10-04T11:35:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, k82cn, liggitt, resouer

Associated issue: 51246

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-10-04T13:00:09Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-10-04T13:56:43Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Automatic merge from submit-queue. Use new taint key in design doc Part of: kubernetes/kubernetes#51246 ~~**DO NOT MERGE** until kubernetes/kubernetes#51266 is in!~~

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2017

k8s-github-robot assigned janetkuo and lavalamp Aug 24, 2017

k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 24, 2017

resouer requested a review from k82cn August 24, 2017 12:03

resouer assigned k82cn and unassigned lavalamp and janetkuo Aug 24, 2017

k8s-ci-robot assigned lavalamp Aug 24, 2017

k82cn mentioned this pull request Aug 24, 2017

Task 1: Tainted node by condition. #49257

Merged

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2017

tengqm mentioned this pull request Aug 24, 2017

Use right taint key in doc kubernetes/website#5188

Merged

resouer mentioned this pull request Aug 24, 2017

Use new taint key in design doc kubernetes/community#985

Merged

thockin assigned davidopp Aug 24, 2017

k82cn approved these changes Sep 7, 2017

View reviewed changes

resouer mentioned this pull request Sep 10, 2017

"notReady" toleration should be "not-ready" #51246

Closed

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2017

Use NC to fix deprecated taint key name

2afab02

resouer force-pushed the not-ready branch from 97395d7 to 2afab02 Compare September 15, 2017 15:54

resouer removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Sep 16, 2017

jaypipes approved these changes Sep 28, 2017

View reviewed changes

resouer mentioned this pull request Sep 29, 2017

Tracking work to deprecate alpha taint key and camelCase taint key #53236

Closed

12 tasks

gmarek reviewed Oct 3, 2017

View reviewed changes

k8s-ci-robot assigned liggitt Oct 3, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2017

k8s-github-robot merged commit 731f421 into kubernetes:master Oct 4, 2017

resouer deleted the not-ready branch October 4, 2017 14:04

resouer mentioned this pull request Oct 24, 2017

Move of unreachable taint key out of alpha #54208

Merged

shivnagarajan mentioned this pull request May 24, 2018

remove alpha toleration forgiveness support for not-ready/unreachable #64260

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor node taint conditions #51266

Refactor node taint conditions #51266

resouer commented Aug 24, 2017 •

edited

resouer commented Aug 24, 2017 •

edited

resouer commented Aug 24, 2017

k82cn commented Aug 24, 2017

resouer commented Aug 24, 2017

luxas commented Aug 24, 2017

resouer commented Aug 24, 2017 •

edited

xiangpengzhao commented Aug 25, 2017

resouer commented Aug 25, 2017 •

edited

k82cn commented Aug 25, 2017

lavalamp commented Aug 31, 2017

resouer commented Aug 31, 2017 •

edited

resouer commented Sep 5, 2017

k82cn commented Sep 7, 2017

jaypipes left a comment

resouer commented Sep 29, 2017 •

edited

luxas commented Sep 29, 2017

gmarek Oct 3, 2017

gmarek commented Oct 3, 2017

liggitt commented Oct 3, 2017 •

edited

gmarek commented Oct 4, 2017

k8s-github-robot commented Oct 4, 2017

k8s-github-robot commented Oct 4, 2017

k8s-github-robot commented Oct 4, 2017

Refactor node taint conditions #51266

Refactor node taint conditions #51266

Conversation

resouer commented Aug 24, 2017 • edited

resouer commented Aug 24, 2017 • edited

resouer commented Aug 24, 2017

k82cn commented Aug 24, 2017

resouer commented Aug 24, 2017

luxas commented Aug 24, 2017

resouer commented Aug 24, 2017 • edited

xiangpengzhao commented Aug 25, 2017

resouer commented Aug 25, 2017 • edited

k82cn commented Aug 25, 2017

lavalamp commented Aug 31, 2017

resouer commented Aug 31, 2017 • edited

resouer commented Sep 5, 2017

k82cn commented Sep 7, 2017

jaypipes left a comment

Choose a reason for hiding this comment

resouer commented Sep 29, 2017 • edited

luxas commented Sep 29, 2017

gmarek Oct 3, 2017

Choose a reason for hiding this comment

gmarek commented Oct 3, 2017

liggitt commented Oct 3, 2017 • edited

gmarek commented Oct 4, 2017

k8s-github-robot commented Oct 4, 2017

k8s-github-robot commented Oct 4, 2017

k8s-github-robot commented Oct 4, 2017

resouer commented Aug 24, 2017 •

edited

resouer commented Aug 24, 2017 •

edited

resouer commented Aug 24, 2017 •

edited

resouer commented Aug 25, 2017 •

edited

resouer commented Aug 31, 2017 •

edited

resouer commented Sep 29, 2017 •

edited

liggitt commented Oct 3, 2017 •

edited