Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
API Changes for RunAsGroup #52077
Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
cmluciano left a comment •
Can you please separate this into controller changes, api changes, generated code? I'm having a hard time finding all the parts that changed while reviewing.
The test failures that you noted are due to the roundtrip fuzzer receiving a nil value when it injects something in.
This can happen for a number of reasons:
This was referenced
Sep 23, 2017
fyi, I pushed an update to the branch restoring the
$ git diff krmayankk/runas --numstat 5982 0 hack/gen-swagger-doc/example-output/definitions.html $ git push --force-with-lease krmayankk HEAD:runas To github.com:krmayankk/kubernetes.git + 1d5c33287c...7e31ffa0c9 HEAD -> runas (forced update)
API and test changes LGTM
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing