Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed kubelet typo #5302

Closed
wants to merge 1 commit into from
Closed

Conversation

cnaize
Copy link

@cnaize cnaize commented Mar 11, 2015

Where is a typo in contrib/init/systemd/environ/kubelet

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@eparis
Copy link
Member

eparis commented Mar 11, 2015

I know the help says (ip:port) but i'm pretty sure

Works:
--api_servers=127.0.0.1:8080
--api_servers=http://127.0.0.1:8080
--api_servers=http://localhost:8080

But does not work:
--api_servers=localhost:8080

(and there is another open issue for that)

So maybe we should default to http://127.0.0.1:8080 so if people make changes they won't fall into that trap? and maybe fix the help text?

@cnaize
Copy link
Author

cnaize commented Mar 11, 2015

I changed my git email, how to continue?

@cnaize
Copy link
Author

cnaize commented Mar 11, 2015

No, the problem is
--api_servers instead of --api_server

@eparis
Copy link
Member

eparis commented Mar 11, 2015

@cnaize I'm well aware of that problem, I'm trying to get you to fix a second 'problem' at the same time.

See issue #2967

@vmarmol
Copy link
Contributor

vmarmol commented Mar 11, 2015

@cnaize I don't see your e-mail or github ID in the CLA database. Can you check:

https://cla.developers.google.com/clas

@eparis
Copy link
Member

eparis commented Mar 11, 2015

fixed in #5307

@eparis eparis closed this Mar 11, 2015
@vmarmol
Copy link
Contributor

vmarmol commented Mar 11, 2015

Actually, that PR was closed without merging. Re-opening

@vmarmol vmarmol reopened this Mar 11, 2015
@eparis
Copy link
Member

eparis commented Mar 11, 2015

well, crap, now this is going to need a rebase, and the cla to be solved.....

@vmarmol
Copy link
Contributor

vmarmol commented Mar 11, 2015

@cnaize we made an alternate #5318 with the change. Sorry for the back and forth, we wanted to wait, but a few people were blocked on the change and we wanted them to continue. Thank you for the PR and I hope to see more soon :) we're always happy to see new contributors!

@vmarmol vmarmol closed this Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants