Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate object name for admission attributes when CREATE #53185

Merged

Conversation

@dixudx
Copy link
Member

commented Sep 28, 2017

What this PR does / why we need it:
The admission attributes given to admission plugins do not populate object name on create.

Since the object is available, the name in the admission attributes should be populated if available.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #46107

Special notes for your reviewer:

Release note:

populate object name for admission attributes when CREATE
@tallclair

This comment has been minimized.

Copy link
Member

commented Oct 2, 2017

/ok-to-test

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2017

/retest

@tallclair

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

Looks reasonable to me.

EDIT: didn't mean to close.

@tallclair tallclair closed this Oct 17, 2017

@tallclair tallclair reopened this Oct 17, 2017

@dixudx dixudx force-pushed the dixudx:fix_admission_attributes_populate_name branch 2 times, most recently from 52e5c1d to f2e6f91 Oct 18, 2017

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Oct 18, 2017

@liggitt @tallclair Updated. PTAL. Thanks.

@deads2k

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2017

@deads2k I know you had thoughts about ordering of admission relative to generated name, which this does not address

Yeah, I think we want to generate names ahead of admission.

@dixudx dixudx force-pushed the dixudx:fix_admission_attributes_populate_name branch from f2e6f91 to aae09ee Oct 19, 2017

@dixudx dixudx force-pushed the dixudx:fix_admission_attributes_populate_name branch from aae09ee to 4bb65c3 Oct 19, 2017

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2017

@liggitt @tallclair Updated. PTAL. Thanks.

@dixudx dixudx force-pushed the dixudx:fix_admission_attributes_populate_name branch from 4bb65c3 to 56ec515 Oct 21, 2017

@dixudx dixudx force-pushed the dixudx:fix_admission_attributes_populate_name branch from d4615db to b9fa3eb Aug 13, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@dixudx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws a13ce8b link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dixudx dixudx force-pushed the dixudx:fix_admission_attributes_populate_name branch from b9fa3eb to 10e6a91 Aug 14, 2019

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2019

@liggitt Please take a review. Thanks.

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 21, 2019

@liggitt liggitt moved this from Not required for GA to Required for GA, in progress in Admission Webhooks Aug 21, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

/priority important-soon
/kind feature

needs rebase

@dixudx dixudx force-pushed the dixudx:fix_admission_attributes_populate_name branch from 10e6a91 to 2771503 Aug 22, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 22, 2019

@dixudx

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

@liggitt Rebased. PTAL. Thanks.

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 22, 2019

@k8s-ci-robot k8s-ci-robot merged commit 315dcca into kubernetes:master Aug 22, 2019

23 checks passed

cla/linuxfoundation dixudx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt moved this from Required for GA, in progress to Complete in Admission Webhooks Aug 22, 2019

@dixudx dixudx deleted the dixudx:fix_admission_attributes_populate_name branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.