New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate kubeletconfig API group to beta #53833

Merged
merged 1 commit into from Feb 15, 2018

Conversation

@mtaufen
Contributor

mtaufen commented Oct 12, 2017

Regarding kubernetes/enhancements#281, this PR moves the kubeletconfig API group to beta.

After #53088, the KubeletConfiguration type should not contain any deprecated or experimental fields, and we should not have to remove any more fields from the type before graduating it to beta.

We need the community to double check for two things, however:

  1. Are there any fields currently in the KubeletConfiguration type that you were going to mark deprecated this quarter, but haven't yet?
  2. Are there any fields currently in the KubeletConfiguration type that are experimental or alpha, but were not explicitly denoted as such?

Please comment on this PR if you can answer "yes" to either of those two questions. Please cc anyone with a stake in the kubeletconfig API, so we get as much coverage as possible.

/cc @thockin @dchen1107 @Random-Liu @yujuhong @dashpole @tallclair @vishh @abw @freehan @dnardo @bowei @MrHohn @luxas @liggitt @ncdc @derekwaynecarr @mikedanese

@kubernetes/sig-network-pr-reviews, @kubernetes/sig-node-pr-reviews

action required: The `kubeletconfig` API group has graduated from alpha to beta, and the name has changed to `kubelet.config.k8s.io`. Please use `kubelet.config.k8s.io/v1beta1`, as `kubeletconfig/v1alpha1` is no longer available. 

TODO:

  • Move experimental/non-gated-alpha/soon-to-be-deprecated fields to KubeletFlags
  • Lift embedded structure out of strings
  • Resolve relative paths against the location config files are loaded from
  • Rename to kubelet.config.k8s.io
  • Comments
    • Make sure existing comments at least read sensibly.
    • Note default values in comments on the versioned struct.
    • Remove any reference to default values in comments on the internal struct.
  • Most fields should be +optional and omitempty. Add where necessary. Where omitted, explicitly comment. Edit: We should not distinguish between nil and empty, see below items.
  • Ensure defaults are specified via pkg/kubelet/apis/kubelet.config.k8s.io/v1beta1/defaults.go, not cmd/kubelet/app/options/options.go.
  • Ensure kubeadm does not persist v1alpha1 KubeletConfiguration objects (or feature-gates this functionality)
  • Don't make a distinction between empty and nil, because of #43203.
  • Take the opportunity to fix insecure Kubelet defaults @tallclair
  • Remove CAdvisorPort from KubeletConfiguration wrt #56523.
  • Hide ConfigTrialDuration until we're more sure what to do with it.
  • Fix // default: x comments after rebasing on recent changes.
@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Feb 15, 2018

/retest

1 similar comment
@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Feb 15, 2018

/retest

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 15, 2018

@dchen1107

This comment has been minimized.

Member

dchen1107 commented Feb 15, 2018

/lgtm

Very exciting, and huge thanks to @liggitt and @mtaufen!

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, liggitt, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 15, 2018

Automatic merge from submit-queue (batch tested with PRs 59353, 59905, 53833). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit c03edcc into kubernetes:master Feb 15, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation mtaufen authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@Random-Liu

This comment has been minimized.

Member

Random-Liu commented Feb 16, 2018

mtaufen added a commit to mtaufen/kubernetes that referenced this pull request Feb 21, 2018

Deprecate KubeletConfiguration flags
This is a follow-up to kubernetes#53833 to deprecate the old flags in favor of the
config file.

k8s-merge-robot added a commit that referenced this pull request Feb 22, 2018

Merge pull request #60148 from mtaufen/deprecate-kubeletconfig-flags
Automatic merge from submit-queue (batch tested with PRs 60148, 60022, 59125, 60068, 60154). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Deprecate KubeletConfiguration flags

This is a follow-up to #53833 to deprecate the old flags in favor of the
config file.

```release-note
Flags that can be set via the Kubelet's --config file are now deprecated in favor of the file.
```

dmlambea added a commit to dmlambea/kubernetes that referenced this pull request Feb 22, 2018

Deprecate KubeletConfiguration flags
This is a follow-up to kubernetes#53833 to deprecate the old flags in favor of the
config file.

jingxu97 added a commit to jingxu97/kubernetes that referenced this pull request Mar 13, 2018

Ignore 0% and 100% eviction thresholds
Primarily, this gives a way to explicitly disable eviction, which is
necessary to use omitempty on EvictionHard.
See: kubernetes#53833 (comment)

As justification for this approach, neither 0% nor 100% make sense as
eviction thresholds; in the "less-than" case, you can't have less than
0% of a resource and 100% perpetually evicts; in the
"greater-than" case (assuming we ever add a resource with this
semantic), the reasoning is the reverse (not more than 100%, 0%
perpetually evicts).

jingxu97 added a commit to jingxu97/kubernetes that referenced this pull request Mar 13, 2018

Secure Kubelet's componentconfig defaults while maintaining CLI compa…
…tibility

This updates the Kubelet's componentconfig defaults, while applying the
legacy defaults to values from options.NewKubeletConfiguration().
This keeps defaults the same for the command line and improves the
security of defaults when you load config from a file.

See: kubernetes#53618
See: kubernetes#53833 (comment)

jingxu97 added a commit to jingxu97/kubernetes that referenced this pull request Mar 13, 2018

Deprecate KubeletConfiguration flags
This is a follow-up to kubernetes#53833 to deprecate the old flags in favor of the
config file.

gregory-m added a commit to gregory-m/kubernetes that referenced this pull request May 22, 2018

Kubelet: Relative paths in local config file
Resolve relative paths against the config file's location.
Add a test to help keep the list of filepath fields up to date.

Issue: kubernetes#55644
Related comment:
kubernetes#53833 (comment)

Will add the same behavior for dynamic Kubelet config in a future PR,
see issue kubernetes#55645.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment