New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug of unit test in printers #53858
Conversation
Hi @lichuqiang. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test |
/approve no-issue |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: derekwaynecarr, lichuqiang Assign the PR to them by writing No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
/assign @pwittrock |
/retest |
/test all Tests are more than 96 hours old. Re-running tests. |
@lichuqiang: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Closing the PR since the code has been out of date |
What this PR does / why we need it:
Test case TestPrintHumanReadableWithNamespace of printers meant to test the rejection of nonnamespacesd resources from printer with param WithNamespace, i.e logic as below:
but due to a lack of statement
AddHandlers(printer)
in test case, it would always succeed, even though corresponding logic has been removedBesides, as the rejection logic no longer exists, the test case should be changed to test the relationship between param WithNamespace in printers and output format
Special notes for your reviewer:
/cc @zjj2wry
Release note: