Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started guide for Mesos on Google Cloud Platform #5442

Merged

Conversation

@ConnorDoyle
Copy link
Member

@ConnorDoyle ConnorDoyle commented Mar 13, 2015

Adds instructions for building and running Kubernetes on a Mesos cluster via the Kubernetes-Mesos integration project.

@googlebot
Copy link

@googlebot googlebot commented Mar 13, 2015

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@ConnorDoyle
Copy link
Member Author

@ConnorDoyle ConnorDoyle commented Mar 13, 2015

I'm covered by the corporate CLA signed by Mesosphere.

@ConnorDoyle
Copy link
Member Author

@ConnorDoyle ConnorDoyle commented Mar 13, 2015

Over the coming weeks we'd like to move some of the components of Kubernetes-Mesos upstream, simplifying this guide as that work progresses.

@jdef
Copy link
Contributor

@jdef jdef commented Mar 13, 2015

@erictune
Copy link
Member

@erictune erictune commented Mar 13, 2015

Does upstream mean mesos repo or kubernetes repo, or some bits to each?

@ConnorDoyle
Copy link
Member Author

@ConnorDoyle ConnorDoyle commented Mar 13, 2015

@erictune I meant to the Kubernetes repo. @jdef and @vladimirvivien have done a bunch of work recently to migrate from depending on a shared library via cgo to a pure Go Mesos interface, which should make the pieces much more amenable to inclusion here.

@timothysc
Copy link
Member

@timothysc timothysc commented Mar 13, 2015

@ConnorDoyle huge +1

@rrati - inbound.

@ConnorDoyle
Copy link
Member Author

@ConnorDoyle ConnorDoyle commented Mar 13, 2015

Just got news we have to re-sign the CLA. Will report back when it's fixed.

@satnam6502
Copy link
Contributor

@satnam6502 satnam6502 commented Mar 13, 2015

Who would be a good reviewer for this?

@erictune
Copy link
Member

@erictune erictune commented Mar 13, 2015

I'll take it.

@erictune erictune self-assigned this Mar 13, 2015
@jdef
Copy link
Contributor

@jdef jdef commented Mar 14, 2015

@yllierop
Copy link
Contributor

@yllierop yllierop commented Mar 15, 2015

This is good news. I'd like to review it as well.


This tutorial will walk you through setting up Kubernetes on a Mesos cluster on [Google Cloud Plaform][4].
It provides a step by step walk through of adding Kubernetes to a Mesos cluster and running the classic GuestBook demo application.

Copy link
Member

@erictune erictune Mar 16, 2015

Can you call out in the text what version of Kubernetes is being installed.

Copy link
Contributor

@jdef jdef Mar 18, 2015

Will do

On Mon, Mar 16, 2015 at 3:39 PM, Eric Tune notifications@github.com wrote:

In docs/getting-started-guides/mesos.md
#5442 (comment)
:

@@ -0,0 +1,287 @@
+## Getting started with Kubernetes on Mesos
+
+
+
+Mesos allows dynamic sharing of cluster resources between Kubernetes and other first-class Mesos frameworks such as [Hadoop][1], [Spark][2], and [Chronos][3].
+Mesos ensures applications running on your cluster are isolated and that resources are allocated fairly.
+
+Running Kubernetes on Mesos allows you to easily move Kubernetes workloads from one cloud provider to another to your own physical datacenter.
+
+This tutorial will walk you through setting up Kubernetes on a Mesos cluster on [Google Cloud Plaform][4].
+It provides a step by step walk through of adding Kubernetes to a Mesos cluster and running the classic GuestBook demo application.
+

Can you call out in the text what version of Kubernetes is being installed.


Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/5442/files#r26519939
.

James DeFelice
585.241.9488 (voice)
650.649.6071 (fax)

Copy link
Member

@erictune erictune Mar 19, 2015

Thanks. This is the only issue blocking merge, I think.

@erictune
Copy link
Member

@erictune erictune commented Mar 19, 2015

Oh, and could you squash.

@timothysc
Copy link
Member

@timothysc timothysc commented Mar 19, 2015

@erictune, @jdef - Could we get a new label for mesos framework integration?

@googlebot
Copy link

@googlebot googlebot commented Mar 25, 2015

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@ConnorDoyle ConnorDoyle force-pushed the getting-started-guide-mesos branch from 4d8f1b0 to 00b34af Mar 25, 2015
@googlebot
Copy link

@googlebot googlebot commented Mar 25, 2015

CLAs look good, thanks!

@ConnorDoyle
Copy link
Member Author

@ConnorDoyle ConnorDoyle commented Mar 25, 2015

@erictune: squashed.

@ConnorDoyle ConnorDoyle force-pushed the getting-started-guide-mesos branch from 00b34af to a62c4e6 Mar 26, 2015
```
It's also a good idea to ensure your etcd instance is reachable by testing it
```bash
curl -L http://$(hostname -i):4001/v2/keys/
Copy link
Contributor

@jdef jdef Mar 26, 2015

any reason why $(hostname -i) is used here instead of $servicehost? I think it should be consistent.

Copy link
Member Author

@ConnorDoyle ConnorDoyle Mar 26, 2015

Fixed.

@ConnorDoyle ConnorDoyle force-pushed the getting-started-guide-mesos branch 2 times, most recently from 4036c91 to d916c9f Mar 26, 2015
@erictune
Copy link
Member

@erictune erictune commented Mar 26, 2015

I haven't forgotten this. Just a little backed up with other work. Will try to loop back tomorrow.

-A KUBE-PORTALS-HOST -d 10.10.10.149/32 -p tcp -m comment --comment frontend -m tcp --dport 9998 -j DNAT --to-destination 10.22.183.23:36336
-A KUBE-PORTALS-HOST -d 10.22.183.23/32 -p tcp -m comment --comment frontend -m tcp --dport 9998 -j DNAT --to-destination 10.22.183.23:36336
$ # open up access to the internal port for the frontend service portal
Copy link
Member

@davidopp davidopp Mar 29, 2015

extraneous $

@googlebot
Copy link

@googlebot googlebot commented Apr 1, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 1, 2015
@guenter
Copy link
Contributor

@guenter guenter commented Apr 1, 2015

@erictune @davidopp thanks for the review, addressed all comments.

<!-- TODO: Update, clean up. -->

Mesos allows dynamic sharing of cluster resources between Kubernetes and other first-class Mesos frameworks such as [Hadoop][1], [Spark][2], and [Chronos][3].
Mesos ensures applications running on your cluster are isolated and that resources are allocated fairly.
Copy link
Member

@davidopp davidopp Apr 1, 2015

Maybe clarify to "Mesos ensures applications from different frameworks running on your cluster..."
I think it's fine to leave as-is, but since Kubernetes also provides isolation and resource allocation, it might be good to clarify what kind of isolation/resource allocation you're talking about.

@davidopp
Copy link
Member

@davidopp davidopp commented Apr 1, 2015

I made some minor comments. I don't think any of them are super-critical, so if you'd like us to just merge what you already have, let us know.

@guenter guenter force-pushed the getting-started-guide-mesos branch from 521f977 to 38b0fe9 Apr 1, 2015
@guenter
Copy link
Contributor

@guenter guenter commented Apr 1, 2015

Made the changes. This is ready to be merged now. Thanks!

@guenter guenter force-pushed the getting-started-guide-mesos branch from 38b0fe9 to 6872a73 Apr 1, 2015
@googlebot
Copy link

@googlebot googlebot commented Apr 1, 2015

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 1, 2015
@davidopp
Copy link
Member

@davidopp davidopp commented Apr 1, 2015

Sorry to nitpick, but I think it's still not clear how to get to the Mesos web UI (you mention it twice; see my earlier line comments). I think the instructions you want are something like "point your web browser to the value that is in ${mesos_master}" perhaps mentioning also that this only works if you set up the VPN properly.

If you actually do explain how to get to the Mesos web UI and I missed it, please let me know (and my apologies).

@googlebot
Copy link

@googlebot googlebot commented Apr 2, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 2, 2015
@guenter
Copy link
Contributor

@guenter guenter commented Apr 2, 2015

No worries, appreciate the attention to detail. I added an explanation for how to get to the GUI.

@davidopp
Copy link
Member

@davidopp davidopp commented Apr 3, 2015

LGTM

Thanks!

davidopp added a commit that referenced this issue Apr 3, 2015
Getting started guide for Mesos on Google Cloud Platform
@davidopp davidopp merged commit eb11e02 into kubernetes:master Apr 3, 2015
1 of 3 checks passed
@ConnorDoyle ConnorDoyle deleted the getting-started-guide-mesos branch Apr 3, 2015
@ConnorDoyle
Copy link
Member Author

@ConnorDoyle ConnorDoyle commented Apr 3, 2015

Thanks!

On Apr 2, 2015, at 17:32, David Oppenheimer notifications@github.com wrote:

Merged #5442.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants