Block volumes Support: iSCSI plugin update #54752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-github-robot
added
the
kind/api-change
|
/retest |
2 similar comments
|
/retest |
|
/retest |
mtanino
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-github-robot
added
the
needs-rebase
This was referenced Nov 5, 2017
mtanino
force-pushed
the
pr/BlockVolumesSupport-iscsi
branch
from
b7f419f
to
5dd3639
Compare
k8s-github-robot
removed
the
needs-rebase
|
/retest |
2 similar comments
|
/retest |
|
/retest |
k8s-github-robot
added
the
needs-rebase
mtanino
force-pushed
the
pr/BlockVolumesSupport-iscsi
branch
from
0787946
to
3676f66
Compare
k8s-github-robot
added
needs-rebase
|
@mtanino is it ready for review? |
|
@rootfs yes, ready to review. thanks. |
rootfs
reviewed
Nov 14, 2017
pkg/volume/iscsi/attacher.go
Outdated
| func (detacher *iscsiDetacher) volumeSpecToUnmounter(mounter mount.Interface) *iscsiDiskUnmounter { | ||
| exec := detacher.host.GetExec(iscsiPluginName) | ||
| func VolumeSpecToUnmounter(mounter mount.Interface, host volume.VolumeHost) *iscsiDiskUnmounter { | ||
| exec := host.GetExec(iscsiPluginName) |
mtanino
force-pushed
the
pr/BlockVolumesSupport-iscsi
branch
from
76ba461
to
d715960
Compare
|
@rootfs @jsafrane This PR adds
|
mtanino
force-pushed
the
pr/BlockVolumesSupport-iscsi
branch
2 times, most recently
from
d997124
to
35baf9c
Compare
|
/retest |
|
@mtanino: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
k8s-github-robot
added
the
needs-rebase
mtanino
force-pushed
the
pr/BlockVolumesSupport-iscsi
branch
from
35baf9c
to
86d27cd
Compare
k8s-github-robot
removed
the
needs-rebase
rootfs
reviewed
Jan 9, 2018
pkg/volume/iscsi/iscsi.go
Outdated
| iface, initiatorNamePtr, err := getISCSIInitiatorInfo(spec) | ||
| if err != nil { | ||
| return nil, err | ||
| func (plugin *iscsiPlugin) NewBlockVolumeMapper(spec *volume.Spec, pod *v1.Pod, _ volume.VolumeOptions) (volume.BlockVolumeMapper, error) { |
rootfs
reviewed
Jan 9, 2018
pkg/volume/iscsi/iscsi.go
Outdated
| @@ -212,25 +176,87 @@ func (plugin *iscsiPlugin) newUnmounterInternal(volName string, podUID types.UID | |||
| }, nil | |||
| } | |||
|
|
|||
| func (plugin *iscsiPlugin) NewBlockVolumeUnmapper(volName string, podUID types.UID) (volume.BlockVolumeUnmapper, error) { | |||
mtanino
force-pushed
the
pr/BlockVolumesSupport-iscsi
branch
from
86d27cd
to
3e066d6
Compare
|
/approve |
k8s-ci-robot
added
the
approved
added 2 commits
January 10, 2018 11:38
This patch adds block volume support to iSCSI volume plugin.
mtanino
force-pushed
the
pr/BlockVolumesSupport-iscsi
branch
from
3e066d6
to
96509d4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtanino, rootfs Associated issue: #805 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 54230, 58100, 57861, 54752). If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
Add interface changes to iSCSI volume plugin to enable block volumes support feature.
Which issue this PR fixes:
Based on this proposal (kubernetes/community#805 & kubernetes/community#1265) and this feature issue: kubernetes/enhancements#351
Special notes for your reviewer:
This PR temporarily includes following changes except iSCSI plugin change for reviewing purpose.
These changes will be removed from the PR once they are merged.
There are another PRs related to this functionality.
(#50457) API Change
(#53385) VolumeMode PV-PVC Binding change
(#51494) Container runtime interface change, volumemanager changes, operationexecutor changes
(#55112) Block volume: Command line printer update
Plugins
(#51493) Block volumes Support: FC plugin update
(#54752) Block volumes Support: iSCSI plugin update
Release note: