Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add vSphere Cloud Provider simulator based tests #55918
What this PR does / why we need it:
Initial set of vSphere Cloud Provider functional tests against the vCenter simulator, provides test coverage without having to run against a real vCenter instance.
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
The vsphere simulator recently moved from vmware/vic to govmomi, I had discussed the idea of introducing it for testing with vSphere Cloud Provider maintainers. These tests provide 90%+ coverage for vclib/datacenter.go, but we can expand further of course.
referenced this pull request
Jan 9, 2018
[APPROVALNOTIFIER] This PR is APPROVED
Associated issue requirement bypassed by: thockin
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing