Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Support for mounting nvme volumes #56607

Merged
merged 1 commit into from Dec 1, 2017

Conversation

@justinsb
Copy link
Member

justinsb commented Nov 30, 2017

Supports mounting nvme volumes

Fixes #56155

AWS: Detect EBS volumes mounted via NVME and mount them
@justinsb

This comment has been minimized.

Copy link
Member Author

justinsb commented Nov 30, 2017

Based on @gnufied 's approach - resolving the symlink

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Nov 30, 2017

/assign @gnufied
/unassign

@k8s-ci-robot k8s-ci-robot assigned gnufied and unassigned jsafrane Nov 30, 2017

if err != nil {
glog.Warningf("error mapping volume %q to AWS volume: %v", volumeID, err)
} else {
nvmeName := "nvme-Amazon_Elastic_Block_Store_" + strings.Replace(string(awsVolumeID), "-", "", -1)

This comment has been minimized.

@gtaylor

gtaylor Nov 30, 2017

Contributor

Could be worth sticking a comment in here to explain what's going on. It can eventually be inferred by reading on to findNvmeVolume's body, but we could make this more immediately evident.

@justinsb justinsb force-pushed the justinsb:aws_nvme_2 branch from 34ca845 to 8bfb676 Nov 30, 2017

@justinsb

This comment has been minimized.

Copy link
Member Author

justinsb commented Nov 30, 2017

Good call @gtaylor - added comments

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented Nov 30, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 30, 2017

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Nov 30, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, justinsb

Associated issue: 56155

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Dec 1, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Dec 1, 2017

[MILESTONENOTIFIER] Milestone Pull Request Needs Attention

@gnufied @jingxu97 @justinsb @kubernetes/sig-aws-misc

Action required: During code freeze, pull requests in the milestone should be in progress.
If this pull request is not being actively worked on, please remove it from the milestone.
If it is being worked on, please add the status/in-progress label so it can be tracked with other in-flight pull requests.

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/aws: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Dec 1, 2017

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c933067 into kubernetes:master Dec 1, 2017

12 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-verify
Details
cla/linuxfoundation justinsb authorized
Details
pull-kubernetes-bazel-build Skipped
pull-kubernetes-bazel-test Skipped
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Jenkins job succeeded.
Details
pull-kubernetes-node-e2e Skipped
pull-kubernetes-unit Jenkins job succeeded.
Details
pull-kubernetes-verify Jenkins job succeeded.
Details

justinsb added a commit to justinsb/test-infra that referenced this pull request Dec 2, 2017

Add a test for m5 instances on AWS
M5 intances have nvme and also need the ENA driver.

NVME support: kubernetes/kubernetes#56607

justinsb added a commit to justinsb/test-infra that referenced this pull request Dec 2, 2017

Add a test for m5 instances on AWS
M5 intances have nvme and also need the ENA driver.

NVME support: kubernetes/kubernetes#56607

fturib added a commit to fturib/test-infra that referenced this pull request Dec 3, 2017

Add a test for m5 instances on AWS
M5 intances have nvme and also need the ENA driver.

NVME support: kubernetes/kubernetes#56607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.