New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package deviceplugin => devicemanager. #56870

Merged
merged 1 commit into from Jan 25, 2018

Conversation

@ConnorDoyle
Member

ConnorDoyle commented Dec 5, 2017

What this PR does / why we need it:

Fixes #58795
/kind cleanup

Rename package deviceplugin to devicemanager for consistency.

We already have components named Container manager and CPU manager. The device plugin package similarly contains an interface called Manager. The fact that the manager has plugins is somewhat incidental to the purpose of the package itself.

Note that this rename only affects internal API. The external gRPC interface still exports a package called deviceplugin.

Release note:

NONE
@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

/test pull-kubernetes-unit

@ConnorDoyle ConnorDoyle reopened this Dec 12, 2017

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

/test pull-kubernetes-unit

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

/test pull-kubernetes-e2e-gce

@dims

This comment has been minimized.

Member

dims commented Dec 12, 2017

/approve no-issue

/assign @dchen1107

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

/sig node

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

/unassign @mtaufen
/assign @vish @derekwaynecarr

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 12, 2017

@ConnorDoyle: GitHub didn't allow me to assign the following users: vish.

Note that only kubernetes members can be assigned.

In response to this:

/unassign @mtaufen
/assign @vish @derekwaynecarr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

/test pull-kubernetes-e2e-gce

@tengqm

This comment has been minimized.

Contributor

tengqm commented Dec 12, 2017

@ConnorDoyle Can we hold this a little bit? There are some non-trivial PRs under review (e.g. #52616, #56398). This rename is gonna make the rebase pretty difficult a job.

@RenaudWasTaken

Remove the kubelet checkpoint file :)

LGTM though I'd like us to focus on getting the 5 other pending refactor PRs in.

@@ -0,0 +1 @@
{"PodDeviceEntries":[{"PodUID":"e0a6c528-decc-11e7-9e96-c85b76944bc7","ContainerName":"e0a6c5c4-decc-11e7-9e96-c85b76944bc7","ResourceName":"domain2.com/resource2","DeviceIDs":["dev3"],"AllocResp":"CgwKBGtleTISBHZhbDI="},{"PodUID":"e0a6c528-decc-11e7-9e96-c85b76944bc7","ContainerName":"e0a6c5c4-decc-11e7-9e96-c85b76944bc7","ResourceName":"domain1.com/resource1","DeviceIDs":["dev1","dev2"],"AllocResp":"CgwKBGtleTESBHZhbDESKgoVL2NvbnRhaW5lcl9kaXIxL2ZpbGUxEg9ob3N0X2RpcjEvZmlsZTEYARIqChUvY29udGFpbmVyX2RpcjEvZmlsZTISD2hvc3RfZGlyMS9maWxlMhgBGhkKCC9kZXYvYWFhEggvZGV2L2FhYRoDbXJ3GhkKCC9kZXYvYmJiEggvZGV2L2JiYhoDbXJ3GhkKCC9kZXYvY2NjEggvZGV2L2NjYxoDbXJ3"},{"PodUID":"e0a6dee8-decc-11e7-9e96-c85b76944bc7","ContainerName":"e0a6df09-decc-11e7-9e96-c85b76944bc7","ResourceName":"domain2.com/resource2","DeviceIDs":["dev4"],"AllocResp":"CgwKBGtleTISBHZhbDM="}],"RegisteredDevices":{"domain1.com/resource1":["dev1","dev2"],"domain2.com/resource2":["dev3","dev4"]}}

This comment has been minimized.

@RenaudWasTaken

RenaudWasTaken Dec 12, 2017

Member

We really need to fix the internal checkpoint not being cleaned up bug...

This comment has been minimized.

@jiayingz

jiayingz Jan 24, 2018

Member

remove this file?

This comment has been minimized.

@ConnorDoyle

ConnorDoyle Jan 25, 2018

Member

Removed!

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

/hold
Wait until some of the long-standing PRs in the deviceplugin are merged.

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Dec 12, 2017

@RenaudWasTaken thanks, removed the checkpoint file.

@dims

This comment has been minimized.

Member

dims commented Dec 19, 2017

/unassign @dims

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Jan 23, 2018

/hold cancel

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Jan 23, 2018

@RenaudWasTaken

This comment has been minimized.

Member

RenaudWasTaken commented Jan 23, 2018

still /lgtm to me :)

@@ -0,0 +1 @@
{"PodDeviceEntries":[{"PodUID":"e0a6c528-decc-11e7-9e96-c85b76944bc7","ContainerName":"e0a6c5c4-decc-11e7-9e96-c85b76944bc7","ResourceName":"domain2.com/resource2","DeviceIDs":["dev3"],"AllocResp":"CgwKBGtleTISBHZhbDI="},{"PodUID":"e0a6c528-decc-11e7-9e96-c85b76944bc7","ContainerName":"e0a6c5c4-decc-11e7-9e96-c85b76944bc7","ResourceName":"domain1.com/resource1","DeviceIDs":["dev1","dev2"],"AllocResp":"CgwKBGtleTESBHZhbDESKgoVL2NvbnRhaW5lcl9kaXIxL2ZpbGUxEg9ob3N0X2RpcjEvZmlsZTEYARIqChUvY29udGFpbmVyX2RpcjEvZmlsZTISD2hvc3RfZGlyMS9maWxlMhgBGhkKCC9kZXYvYWFhEggvZGV2L2FhYRoDbXJ3GhkKCC9kZXYvYmJiEggvZGV2L2JiYhoDbXJ3GhkKCC9kZXYvY2NjEggvZGV2L2NjYxoDbXJ3"},{"PodUID":"e0a6dee8-decc-11e7-9e96-c85b76944bc7","ContainerName":"e0a6df09-decc-11e7-9e96-c85b76944bc7","ResourceName":"domain2.com/resource2","DeviceIDs":["dev4"],"AllocResp":"CgwKBGtleTISBHZhbDM="}],"RegisteredDevices":{"domain1.com/resource1":["dev1","dev2"],"domain2.com/resource2":["dev3","dev4"]}}

This comment has been minimized.

@jiayingz

jiayingz Jan 24, 2018

Member

remove this file?

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 24, 2018

@vikaschoudhary16

This comment has been minimized.

Member

vikaschoudhary16 commented Jan 24, 2018

/lgtm

@ConnorDoyle

This comment has been minimized.

Member

ConnorDoyle commented Jan 25, 2018

@vikaschoudhary16 @jiayingz @RenaudWasTaken could I get another lgtm when tests go green? Removed the checkpoint file I committed by accident.

@resouer

This comment has been minimized.

Member

resouer commented Jan 25, 2018

/lgtm

@vikaschoudhary16

This comment has been minimized.

Member

vikaschoudhary16 commented Jan 25, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorDoyle, dims, jiayingz, resouer, vikaschoudhary16

Associated issue: #58795

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 25, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 25, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit dd272ea into kubernetes:master Jan 25, 2018

11 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-verify
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
cla/linuxfoundation ConnorDoyle authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 25, 2018

@ConnorDoyle: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu e5667cf link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ConnorDoyle ConnorDoyle deleted the ConnorDoyle:rename-deviceplugin-package branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment